From: David Miller <davem@davemloft.net>
To: kuba@kernel.org
Cc: tlfalcon@linux.ibm.com, netdev@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, drt@linux.ibm.com
Subject: Re: [PATCH net-next] ibmvnic: Increase driver logging
Date: Wed, 15 Jul 2020 18:29:56 -0700 (PDT) [thread overview]
Message-ID: <20200715.182956.490791427431304861.davem@davemloft.net> (raw)
In-Reply-To: <20200715170632.11f0bf19@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
From: Jakub Kicinski <kuba@kernel.org>
Date: Wed, 15 Jul 2020 17:06:32 -0700
> On Wed, 15 Jul 2020 18:51:55 -0500 Thomas Falcon wrote:
>> free_netdev(netdev);
>> dev_set_drvdata(&dev->dev, NULL);
>> + netdev_info(netdev, "VNIC client device has been successfully removed.\n");
>
> A step too far, perhaps.
>
> In general this patch looks a little questionable IMHO, this amount of
> logging output is not commonly seen in drivers. All the the info
> messages are just static text, not even carrying any extra information.
> In an era of ftrace, and bpftrace, do we really need this?
Agreed, this is too much. This is debugging, and thus suitable for tracing
facilities, at best.
WARNING: multiple messages have this Message-ID (diff)
From: David Miller <davem@davemloft.net>
To: kuba@kernel.org
Cc: drt@linux.ibm.com, netdev@vger.kernel.org,
tlfalcon@linux.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH net-next] ibmvnic: Increase driver logging
Date: Wed, 15 Jul 2020 18:29:56 -0700 (PDT) [thread overview]
Message-ID: <20200715.182956.490791427431304861.davem@davemloft.net> (raw)
In-Reply-To: <20200715170632.11f0bf19@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
From: Jakub Kicinski <kuba@kernel.org>
Date: Wed, 15 Jul 2020 17:06:32 -0700
> On Wed, 15 Jul 2020 18:51:55 -0500 Thomas Falcon wrote:
>> free_netdev(netdev);
>> dev_set_drvdata(&dev->dev, NULL);
>> + netdev_info(netdev, "VNIC client device has been successfully removed.\n");
>
> A step too far, perhaps.
>
> In general this patch looks a little questionable IMHO, this amount of
> logging output is not commonly seen in drivers. All the the info
> messages are just static text, not even carrying any extra information.
> In an era of ftrace, and bpftrace, do we really need this?
Agreed, this is too much. This is debugging, and thus suitable for tracing
facilities, at best.
next prev parent reply other threads:[~2020-07-16 1:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-15 23:51 [PATCH net-next] ibmvnic: Increase driver logging Thomas Falcon
2020-07-15 23:51 ` Thomas Falcon
2020-07-16 0:06 ` Jakub Kicinski
2020-07-16 0:06 ` Jakub Kicinski
2020-07-16 1:29 ` David Miller [this message]
2020-07-16 1:29 ` David Miller
2020-07-16 15:59 ` Thomas Falcon
2020-07-16 15:59 ` Thomas Falcon
2020-07-16 16:07 ` Michal Suchánek
2020-07-16 16:07 ` Michal Suchánek
2020-07-16 20:22 ` Jakub Kicinski
2020-07-16 20:22 ` Jakub Kicinski
2020-07-17 0:26 ` Stephen Hemminger
2020-07-17 0:26 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715.182956.490791427431304861.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=drt@linux.ibm.com \
--cc=kuba@kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=tlfalcon@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.