All of lore.kernel.org
 help / color / mirror / Atom feed
* [renesas-drivers:master 69/80] drivers/net/ethernet/sfc/efx_common.c:1227:17: warning: 'enum pci_channel_state' declared inside parameter list will not be visible outside of this definition or declaration
@ 2020-07-14 17:22 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-07-14 17:22 UTC (permalink / raw)
  To: Bjorn Helgaas; +Cc: kbuild-all, linux-renesas-soc, Geert Uytterhoeven

[-- Attachment #1: Type: text/plain, Size: 4777 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git master
head:   541708cc1e6ad29fdb4c294831dfa855bd64487b
commit: 428d2a440d43ba81b698ec71de5125e4aeddf752 [69/80] Merge remote-tracking branch 'pci/next' into renesas-drivers
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 428d2a440d43ba81b698ec71de5125e4aeddf752
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

>> drivers/net/ethernet/sfc/efx_common.c:1227:17: warning: 'enum pci_channel_state' declared inside parameter list will not be visible outside of this definition or declaration
    1227 |            enum pci_channel_state state)
         |                 ^~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/sfc/efx_common.c:1227:35: error: parameter 2 ('state') has incomplete type
    1227 |            enum pci_channel_state state)
         |            ~~~~~~~~~~~~~~~~~~~~~~~^~~~~
>> drivers/net/ethernet/sfc/efx_common.c:1226:25: error: function declaration isn't a prototype [-Werror=strict-prototypes]
    1226 | static pci_ers_result_t efx_io_error_detected(struct pci_dev *pdev,
         |                         ^~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +1227 drivers/net/ethernet/sfc/efx_common.c

21ea21252eddb3c Edward Cree 2020-06-29  1221  
21ea21252eddb3c Edward Cree 2020-06-29  1222  /* A PCI error affecting this device was detected.
21ea21252eddb3c Edward Cree 2020-06-29  1223   * At this point MMIO and DMA may be disabled.
21ea21252eddb3c Edward Cree 2020-06-29  1224   * Stop the software path and request a slot reset.
21ea21252eddb3c Edward Cree 2020-06-29  1225   */
21ea21252eddb3c Edward Cree 2020-06-29 @1226  static pci_ers_result_t efx_io_error_detected(struct pci_dev *pdev,
21ea21252eddb3c Edward Cree 2020-06-29 @1227  					      enum pci_channel_state state)
21ea21252eddb3c Edward Cree 2020-06-29  1228  {
21ea21252eddb3c Edward Cree 2020-06-29  1229  	pci_ers_result_t status = PCI_ERS_RESULT_RECOVERED;
21ea21252eddb3c Edward Cree 2020-06-29  1230  	struct efx_nic *efx = pci_get_drvdata(pdev);
21ea21252eddb3c Edward Cree 2020-06-29  1231  
21ea21252eddb3c Edward Cree 2020-06-29  1232  	if (state == pci_channel_io_perm_failure)
21ea21252eddb3c Edward Cree 2020-06-29  1233  		return PCI_ERS_RESULT_DISCONNECT;
21ea21252eddb3c Edward Cree 2020-06-29  1234  
21ea21252eddb3c Edward Cree 2020-06-29  1235  	rtnl_lock();
21ea21252eddb3c Edward Cree 2020-06-29  1236  
21ea21252eddb3c Edward Cree 2020-06-29  1237  	if (efx->state != STATE_DISABLED) {
21ea21252eddb3c Edward Cree 2020-06-29  1238  		efx->state = STATE_RECOVERY;
21ea21252eddb3c Edward Cree 2020-06-29  1239  		efx->reset_pending = 0;
21ea21252eddb3c Edward Cree 2020-06-29  1240  
21ea21252eddb3c Edward Cree 2020-06-29  1241  		efx_device_detach_sync(efx);
21ea21252eddb3c Edward Cree 2020-06-29  1242  
21ea21252eddb3c Edward Cree 2020-06-29  1243  		efx_stop_all(efx);
21ea21252eddb3c Edward Cree 2020-06-29  1244  		efx_disable_interrupts(efx);
21ea21252eddb3c Edward Cree 2020-06-29  1245  
21ea21252eddb3c Edward Cree 2020-06-29  1246  		status = PCI_ERS_RESULT_NEED_RESET;
21ea21252eddb3c Edward Cree 2020-06-29  1247  	} else {
21ea21252eddb3c Edward Cree 2020-06-29  1248  		/* If the interface is disabled we don't want to do anything
21ea21252eddb3c Edward Cree 2020-06-29  1249  		 * with it.
21ea21252eddb3c Edward Cree 2020-06-29  1250  		 */
21ea21252eddb3c Edward Cree 2020-06-29  1251  		status = PCI_ERS_RESULT_RECOVERED;
21ea21252eddb3c Edward Cree 2020-06-29  1252  	}
21ea21252eddb3c Edward Cree 2020-06-29  1253  
21ea21252eddb3c Edward Cree 2020-06-29  1254  	rtnl_unlock();
21ea21252eddb3c Edward Cree 2020-06-29  1255  
21ea21252eddb3c Edward Cree 2020-06-29  1256  	pci_disable_device(pdev);
21ea21252eddb3c Edward Cree 2020-06-29  1257  
21ea21252eddb3c Edward Cree 2020-06-29  1258  	return status;
21ea21252eddb3c Edward Cree 2020-06-29  1259  }
21ea21252eddb3c Edward Cree 2020-06-29  1260  

:::::: The code at line 1227 was first introduced by commit
:::::: 21ea21252eddb3cea56845f58f87208062799bef sfc: commonise PCI error handlers

:::::: TO: Edward Cree <ecree@solarflare.com>
:::::: CC: David S. Miller <davem@davemloft.net>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 65223 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
* [renesas-drivers:master 69/80] drivers/net/ethernet/sfc/efx_common.c:1227:17: warning: 'enum pci_channel_state' declared inside parameter list will not be visible outside of this definition or declaration
@ 2020-07-14 17:22 ` kernel test robot
  0 siblings, 0 replies; 2+ messages in thread
From: kernel test robot @ 2020-07-14 17:22 UTC (permalink / raw)
  To: kbuild-all

[-- Attachment #1: Type: text/plain, Size: 4859 bytes --]

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git master
head:   541708cc1e6ad29fdb4c294831dfa855bd64487b
commit: 428d2a440d43ba81b698ec71de5125e4aeddf752 [69/80] Merge remote-tracking branch 'pci/next' into renesas-drivers
config: alpha-allyesconfig (attached as .config)
compiler: alpha-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        git checkout 428d2a440d43ba81b698ec71de5125e4aeddf752
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=alpha 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

>> drivers/net/ethernet/sfc/efx_common.c:1227:17: warning: 'enum pci_channel_state' declared inside parameter list will not be visible outside of this definition or declaration
    1227 |            enum pci_channel_state state)
         |                 ^~~~~~~~~~~~~~~~~
>> drivers/net/ethernet/sfc/efx_common.c:1227:35: error: parameter 2 ('state') has incomplete type
    1227 |            enum pci_channel_state state)
         |            ~~~~~~~~~~~~~~~~~~~~~~~^~~~~
>> drivers/net/ethernet/sfc/efx_common.c:1226:25: error: function declaration isn't a prototype [-Werror=strict-prototypes]
    1226 | static pci_ers_result_t efx_io_error_detected(struct pci_dev *pdev,
         |                         ^~~~~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +1227 drivers/net/ethernet/sfc/efx_common.c

21ea21252eddb3c Edward Cree 2020-06-29  1221  
21ea21252eddb3c Edward Cree 2020-06-29  1222  /* A PCI error affecting this device was detected.
21ea21252eddb3c Edward Cree 2020-06-29  1223   * At this point MMIO and DMA may be disabled.
21ea21252eddb3c Edward Cree 2020-06-29  1224   * Stop the software path and request a slot reset.
21ea21252eddb3c Edward Cree 2020-06-29  1225   */
21ea21252eddb3c Edward Cree 2020-06-29 @1226  static pci_ers_result_t efx_io_error_detected(struct pci_dev *pdev,
21ea21252eddb3c Edward Cree 2020-06-29 @1227  					      enum pci_channel_state state)
21ea21252eddb3c Edward Cree 2020-06-29  1228  {
21ea21252eddb3c Edward Cree 2020-06-29  1229  	pci_ers_result_t status = PCI_ERS_RESULT_RECOVERED;
21ea21252eddb3c Edward Cree 2020-06-29  1230  	struct efx_nic *efx = pci_get_drvdata(pdev);
21ea21252eddb3c Edward Cree 2020-06-29  1231  
21ea21252eddb3c Edward Cree 2020-06-29  1232  	if (state == pci_channel_io_perm_failure)
21ea21252eddb3c Edward Cree 2020-06-29  1233  		return PCI_ERS_RESULT_DISCONNECT;
21ea21252eddb3c Edward Cree 2020-06-29  1234  
21ea21252eddb3c Edward Cree 2020-06-29  1235  	rtnl_lock();
21ea21252eddb3c Edward Cree 2020-06-29  1236  
21ea21252eddb3c Edward Cree 2020-06-29  1237  	if (efx->state != STATE_DISABLED) {
21ea21252eddb3c Edward Cree 2020-06-29  1238  		efx->state = STATE_RECOVERY;
21ea21252eddb3c Edward Cree 2020-06-29  1239  		efx->reset_pending = 0;
21ea21252eddb3c Edward Cree 2020-06-29  1240  
21ea21252eddb3c Edward Cree 2020-06-29  1241  		efx_device_detach_sync(efx);
21ea21252eddb3c Edward Cree 2020-06-29  1242  
21ea21252eddb3c Edward Cree 2020-06-29  1243  		efx_stop_all(efx);
21ea21252eddb3c Edward Cree 2020-06-29  1244  		efx_disable_interrupts(efx);
21ea21252eddb3c Edward Cree 2020-06-29  1245  
21ea21252eddb3c Edward Cree 2020-06-29  1246  		status = PCI_ERS_RESULT_NEED_RESET;
21ea21252eddb3c Edward Cree 2020-06-29  1247  	} else {
21ea21252eddb3c Edward Cree 2020-06-29  1248  		/* If the interface is disabled we don't want to do anything
21ea21252eddb3c Edward Cree 2020-06-29  1249  		 * with it.
21ea21252eddb3c Edward Cree 2020-06-29  1250  		 */
21ea21252eddb3c Edward Cree 2020-06-29  1251  		status = PCI_ERS_RESULT_RECOVERED;
21ea21252eddb3c Edward Cree 2020-06-29  1252  	}
21ea21252eddb3c Edward Cree 2020-06-29  1253  
21ea21252eddb3c Edward Cree 2020-06-29  1254  	rtnl_unlock();
21ea21252eddb3c Edward Cree 2020-06-29  1255  
21ea21252eddb3c Edward Cree 2020-06-29  1256  	pci_disable_device(pdev);
21ea21252eddb3c Edward Cree 2020-06-29  1257  
21ea21252eddb3c Edward Cree 2020-06-29  1258  	return status;
21ea21252eddb3c Edward Cree 2020-06-29  1259  }
21ea21252eddb3c Edward Cree 2020-06-29  1260  

:::::: The code at line 1227 was first introduced by commit
:::::: 21ea21252eddb3cea56845f58f87208062799bef sfc: commonise PCI error handlers

:::::: TO: Edward Cree <ecree@solarflare.com>
:::::: CC: David S. Miller <davem@davemloft.net>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 65223 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-14 17:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-14 17:22 [renesas-drivers:master 69/80] drivers/net/ethernet/sfc/efx_common.c:1227:17: warning: 'enum pci_channel_state' declared inside parameter list will not be visible outside of this definition or declaration kernel test robot
2020-07-14 17:22 ` kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.