From: Lee Jones <lee.jones@linaro.org>
To: Olof Johansson <olof@lixom.net>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-pm@vger.kernel.org, Michael Ellerman <mpe@ellerman.id.au>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 05/13] cpufreq/arch: powerpc: pasemi: Move prototypes to shared header
Date: Wed, 15 Jul 2020 07:36:07 +0100 [thread overview]
Message-ID: <20200715063607.GQ1398296@dell> (raw)
In-Reply-To: <CAOesGMi1dfqPbFJ8YoUoJ75NdU1=XiNoYx+6+JLu44a4LuuYGA@mail.gmail.com>
On Tue, 14 Jul 2020, Olof Johansson wrote:
> On Tue, Jul 14, 2020 at 8:07 PM Viresh Kumar <viresh.kumar@linaro.org> wrote:
> >
> > On 14-07-20, 15:50, Lee Jones wrote:
> > > If function callers and providers do not share the same prototypes the
> > > compiler complains of missing prototypes. Fix this by moving the
> > > already existing prototypes out to a mutually convenient location.
> > >
> > > Fixes the following W=1 kernel build warning(s):
> > >
> > > drivers/cpufreq/pasemi-cpufreq.c:109:5: warning: no previous prototype for ‘check_astate’ [-Wmissing-prototypes]
> > > 109 | int check_astate(void)
> > > | ^~~~~~~~~~~~
> > > drivers/cpufreq/pasemi-cpufreq.c:114:6: warning: no previous prototype for ‘restore_astate’ [-Wmissing-prototypes]
> > > 114 | void restore_astate(int cpu)
> > > | ^~~~~~~~~~~~~~
> > >
> > > Cc: Olof Johansson <olof@lixom.net>
> > > Cc: Michael Ellerman <mpe@ellerman.id.au>
> > > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > > Cc: Paul Mackerras <paulus@samba.org>
> > > Cc: linuxppc-dev@lists.ozlabs.org
> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > ---
> > > arch/powerpc/platforms/pasemi/pasemi.h | 15 ------------
> >
> > Is there no sane way we can include this file directly to the cpufreq
> > file ?
>
> Yep. arch/powerpc seems to be in the search path for modules on powerpc, so:
>
> diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasemi-cpufreq.c
> index c66f566a854cb..815645170c4de 100644
> --- a/drivers/cpufreq/pasemi-cpufreq.c
> +++ b/drivers/cpufreq/pasemi-cpufreq.c
> @@ -22,6 +22,8 @@
> #include <asm/time.h>
> #include <asm/smp.h>
>
> +#include <platforms/pasemi/pasemi.h>
> +
> #define SDCASR_REG 0x0100
> #define SDCASR_REG_STRIDE 0x1000
> #define SDCPWR_CFGA0_REG 0x0100
I searched for "include.*platforms/" in drivers/, and was scared off
this method since no one else does this.
But if it's a reasonable solution, great. Will fix.
Thanks Olof.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Olof Johansson <olof@lixom.net>
Cc: linux-pm@vger.kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 05/13] cpufreq/arch: powerpc: pasemi: Move prototypes to shared header
Date: Wed, 15 Jul 2020 07:36:07 +0100 [thread overview]
Message-ID: <20200715063607.GQ1398296@dell> (raw)
In-Reply-To: <CAOesGMi1dfqPbFJ8YoUoJ75NdU1=XiNoYx+6+JLu44a4LuuYGA@mail.gmail.com>
On Tue, 14 Jul 2020, Olof Johansson wrote:
> On Tue, Jul 14, 2020 at 8:07 PM Viresh Kumar <viresh.kumar@linaro.org> wrote:
> >
> > On 14-07-20, 15:50, Lee Jones wrote:
> > > If function callers and providers do not share the same prototypes the
> > > compiler complains of missing prototypes. Fix this by moving the
> > > already existing prototypes out to a mutually convenient location.
> > >
> > > Fixes the following W=1 kernel build warning(s):
> > >
> > > drivers/cpufreq/pasemi-cpufreq.c:109:5: warning: no previous prototype for ‘check_astate’ [-Wmissing-prototypes]
> > > 109 | int check_astate(void)
> > > | ^~~~~~~~~~~~
> > > drivers/cpufreq/pasemi-cpufreq.c:114:6: warning: no previous prototype for ‘restore_astate’ [-Wmissing-prototypes]
> > > 114 | void restore_astate(int cpu)
> > > | ^~~~~~~~~~~~~~
> > >
> > > Cc: Olof Johansson <olof@lixom.net>
> > > Cc: Michael Ellerman <mpe@ellerman.id.au>
> > > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > > Cc: Paul Mackerras <paulus@samba.org>
> > > Cc: linuxppc-dev@lists.ozlabs.org
> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > ---
> > > arch/powerpc/platforms/pasemi/pasemi.h | 15 ------------
> >
> > Is there no sane way we can include this file directly to the cpufreq
> > file ?
>
> Yep. arch/powerpc seems to be in the search path for modules on powerpc, so:
>
> diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasemi-cpufreq.c
> index c66f566a854cb..815645170c4de 100644
> --- a/drivers/cpufreq/pasemi-cpufreq.c
> +++ b/drivers/cpufreq/pasemi-cpufreq.c
> @@ -22,6 +22,8 @@
> #include <asm/time.h>
> #include <asm/smp.h>
>
> +#include <platforms/pasemi/pasemi.h>
> +
> #define SDCASR_REG 0x0100
> #define SDCASR_REG_STRIDE 0x1000
> #define SDCPWR_CFGA0_REG 0x0100
I searched for "include.*platforms/" in drivers/, and was scared off
this method since no one else does this.
But if it's a reasonable solution, great. Will fix.
Thanks Olof.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Olof Johansson <olof@lixom.net>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
linux-pm@vger.kernel.org, Michael Ellerman <mpe@ellerman.id.au>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Paul Mackerras <paulus@samba.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 05/13] cpufreq/arch: powerpc: pasemi: Move prototypes to shared header
Date: Wed, 15 Jul 2020 07:36:07 +0100 [thread overview]
Message-ID: <20200715063607.GQ1398296@dell> (raw)
In-Reply-To: <CAOesGMi1dfqPbFJ8YoUoJ75NdU1=XiNoYx+6+JLu44a4LuuYGA@mail.gmail.com>
On Tue, 14 Jul 2020, Olof Johansson wrote:
> On Tue, Jul 14, 2020 at 8:07 PM Viresh Kumar <viresh.kumar@linaro.org> wrote:
> >
> > On 14-07-20, 15:50, Lee Jones wrote:
> > > If function callers and providers do not share the same prototypes the
> > > compiler complains of missing prototypes. Fix this by moving the
> > > already existing prototypes out to a mutually convenient location.
> > >
> > > Fixes the following W=1 kernel build warning(s):
> > >
> > > drivers/cpufreq/pasemi-cpufreq.c:109:5: warning: no previous prototype for ‘check_astate’ [-Wmissing-prototypes]
> > > 109 | int check_astate(void)
> > > | ^~~~~~~~~~~~
> > > drivers/cpufreq/pasemi-cpufreq.c:114:6: warning: no previous prototype for ‘restore_astate’ [-Wmissing-prototypes]
> > > 114 | void restore_astate(int cpu)
> > > | ^~~~~~~~~~~~~~
> > >
> > > Cc: Olof Johansson <olof@lixom.net>
> > > Cc: Michael Ellerman <mpe@ellerman.id.au>
> > > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > > Cc: Paul Mackerras <paulus@samba.org>
> > > Cc: linuxppc-dev@lists.ozlabs.org
> > > Signed-off-by: Lee Jones <lee.jones@linaro.org>
> > > ---
> > > arch/powerpc/platforms/pasemi/pasemi.h | 15 ------------
> >
> > Is there no sane way we can include this file directly to the cpufreq
> > file ?
>
> Yep. arch/powerpc seems to be in the search path for modules on powerpc, so:
>
> diff --git a/drivers/cpufreq/pasemi-cpufreq.c b/drivers/cpufreq/pasemi-cpufreq.c
> index c66f566a854cb..815645170c4de 100644
> --- a/drivers/cpufreq/pasemi-cpufreq.c
> +++ b/drivers/cpufreq/pasemi-cpufreq.c
> @@ -22,6 +22,8 @@
> #include <asm/time.h>
> #include <asm/smp.h>
>
> +#include <platforms/pasemi/pasemi.h>
> +
> #define SDCASR_REG 0x0100
> #define SDCASR_REG_STRIDE 0x1000
> #define SDCPWR_CFGA0_REG 0x0100
I searched for "include.*platforms/" in drivers/, and was scared off
this method since no one else does this.
But if it's a reasonable solution, great. Will fix.
Thanks Olof.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-15 6:36 UTC|newest]
Thread overview: 150+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-14 14:50 [PATCH 00/13] Rid W=1 warnings in CPUFreq Lee Jones
2020-07-14 14:50 ` Lee Jones
2020-07-14 14:50 ` [PATCH 01/13] cpufreq: freq_table: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-14 14:50 ` Lee Jones
2020-07-15 2:44 ` Viresh Kumar
2020-07-15 2:44 ` Viresh Kumar
2020-07-14 14:50 ` [PATCH 02/13] cpufreq: cpufreq: Demote lots of function headers unworthy of kerneldoc status Lee Jones
2020-07-14 14:50 ` Lee Jones
2020-07-15 2:49 ` Viresh Kumar
2020-07-15 2:49 ` Viresh Kumar
2020-07-15 6:47 ` Lee Jones
2020-07-15 6:47 ` Lee Jones
2020-07-15 7:09 ` Viresh Kumar
2020-07-15 7:09 ` Viresh Kumar
2020-07-14 14:50 ` [PATCH 03/13] cpufreq: cpufreq_governor: Demote store_sampling_rate() header to standard comment block Lee Jones
2020-07-14 14:50 ` Lee Jones
2020-07-15 2:52 ` Viresh Kumar
2020-07-15 2:52 ` Viresh Kumar
2020-07-15 6:45 ` Lee Jones
2020-07-15 6:45 ` Lee Jones
2020-07-15 7:08 ` Viresh Kumar
2020-07-15 7:08 ` Viresh Kumar
2020-07-15 7:31 ` Lee Jones
2020-07-15 7:31 ` Lee Jones
2020-07-15 8:02 ` Viresh Kumar
2020-07-15 8:02 ` Viresh Kumar
2020-07-15 8:15 ` Lee Jones
2020-07-15 8:15 ` Lee Jones
2020-07-14 14:50 ` [PATCH 04/13] cpufreq: sti-cpufreq: Fix some formatting and misspelling issues Lee Jones
2020-07-14 14:50 ` Lee Jones
2020-07-15 2:58 ` Viresh Kumar
2020-07-15 2:58 ` Viresh Kumar
2020-07-14 14:50 ` [PATCH 05/13] cpufreq/arch: powerpc: pasemi: Move prototypes to shared header Lee Jones
2020-07-14 14:50 ` Lee Jones
2020-07-14 14:50 ` Lee Jones
2020-07-15 3:07 ` Viresh Kumar
2020-07-15 3:07 ` Viresh Kumar
2020-07-15 3:07 ` Viresh Kumar
2020-07-15 3:49 ` Olof Johansson
2020-07-15 3:49 ` Olof Johansson
2020-07-15 3:49 ` Olof Johansson
2020-07-15 3:51 ` Viresh Kumar
2020-07-15 3:51 ` Viresh Kumar
2020-07-15 3:51 ` Viresh Kumar
2020-07-15 6:36 ` Lee Jones [this message]
2020-07-15 6:36 ` Lee Jones
2020-07-15 6:36 ` Lee Jones
2020-07-15 6:39 ` Viresh Kumar
2020-07-15 6:39 ` Viresh Kumar
2020-07-15 6:39 ` Viresh Kumar
2020-07-15 3:26 ` Olof Johansson
2020-07-15 3:26 ` Olof Johansson
2020-07-15 3:26 ` Olof Johansson
2020-07-15 6:33 ` Lee Jones
2020-07-15 6:33 ` Lee Jones
2020-07-15 6:33 ` Lee Jones
2020-07-15 6:46 ` Olof Johansson
2020-07-15 6:46 ` Olof Johansson
2020-07-15 6:46 ` Olof Johansson
2020-07-15 7:33 ` Lee Jones
2020-07-15 7:33 ` Lee Jones
2020-07-15 7:33 ` Lee Jones
2020-07-14 14:50 ` [PATCH 06/13] cpufreq: powernv-cpufreq: Functions only used in call-backs should be static Lee Jones
2020-07-14 14:50 ` Lee Jones
2020-07-14 14:50 ` Lee Jones
2020-07-15 3:07 ` Viresh Kumar
2020-07-15 3:07 ` Viresh Kumar
2020-07-15 3:07 ` Viresh Kumar
2020-07-14 14:50 ` [PATCH 07/13] cpufreq: powernv-cpufreq: Fix a bunch of kerneldoc related issues Lee Jones
2020-07-14 14:50 ` Lee Jones
2020-07-14 14:50 ` Lee Jones
2020-07-15 3:09 ` Viresh Kumar
2020-07-15 3:09 ` Viresh Kumar
2020-07-15 3:09 ` Viresh Kumar
2020-07-14 14:50 ` [PATCH 08/13] cpufreq: acpi-cpufreq: Take 'dummy' principle one stage further Lee Jones
2020-07-14 14:50 ` Lee Jones
2020-07-14 16:03 ` Rafael J. Wysocki
2020-07-14 16:03 ` Rafael J. Wysocki
2020-07-14 16:20 ` Robin Murphy
2020-07-14 16:20 ` Robin Murphy
2020-07-14 21:00 ` Lee Jones
2020-07-14 21:00 ` Lee Jones
2020-07-14 14:50 ` [PATCH 09/13] cpufreq: acpi-cpufreq: Remove unused ID structs Lee Jones
2020-07-14 14:50 ` Lee Jones
2020-07-14 15:58 ` Rafael J. Wysocki
2020-07-14 15:58 ` Rafael J. Wysocki
2020-07-14 21:03 ` Lee Jones
2020-07-14 21:03 ` Lee Jones
2020-07-15 3:24 ` Viresh Kumar
2020-07-15 3:24 ` Viresh Kumar
2020-07-15 3:27 ` Viresh Kumar
2020-07-15 3:27 ` Viresh Kumar
2020-07-15 6:37 ` Lee Jones
2020-07-15 6:37 ` Lee Jones
2020-07-15 11:27 ` Rafael J. Wysocki
2020-07-15 11:27 ` Rafael J. Wysocki
2020-07-15 11:34 ` Lee Jones
2020-07-15 11:34 ` Lee Jones
2020-07-15 11:44 ` Rafael J. Wysocki
2020-07-15 11:44 ` Rafael J. Wysocki
2020-07-15 11:50 ` Lee Jones
2020-07-15 11:50 ` Lee Jones
2020-07-15 12:07 ` Lee Jones
2020-07-15 12:07 ` Lee Jones
2020-07-15 12:11 ` Rafael J. Wysocki
2020-07-15 12:11 ` Rafael J. Wysocki
2020-07-15 12:09 ` Rafael J. Wysocki
2020-07-15 12:09 ` Rafael J. Wysocki
2020-07-15 12:16 ` Lee Jones
2020-07-15 12:16 ` Lee Jones
2020-07-15 12:30 ` Robin Murphy
2020-07-15 12:30 ` Robin Murphy
2020-07-15 12:38 ` Lee Jones
2020-07-15 12:38 ` Lee Jones
2020-07-14 14:50 ` [PATCH 10/13] cpufreq: powernow-k8: Make use of known set but not used variables Lee Jones
2020-07-14 14:50 ` Lee Jones
2020-07-14 17:43 ` Rafael J. Wysocki
2020-07-14 17:43 ` Rafael J. Wysocki
2020-07-14 21:01 ` Lee Jones
2020-07-14 21:01 ` Lee Jones
2020-07-14 14:50 ` [PATCH 11/13] cpufreq: pcc-cpufreq: Remove unused ID structs Lee Jones
2020-07-14 14:50 ` Lee Jones
2020-07-14 17:42 ` Rafael J. Wysocki
2020-07-14 17:42 ` Rafael J. Wysocki
2020-07-14 14:50 ` [PATCH 12/13] cpufreq: intel_pstate: Supply struct attribute description for get_aperf_mperf_shift() Lee Jones
2020-07-14 14:50 ` Lee Jones
2020-07-14 16:35 ` Rafael J. Wysocki
2020-07-14 16:35 ` Rafael J. Wysocki
2020-07-14 21:03 ` Lee Jones
2020-07-14 21:03 ` Lee Jones
2020-07-15 12:38 ` Rafael J. Wysocki
2020-07-15 12:38 ` Rafael J. Wysocki
2020-07-14 14:50 ` [PATCH 13/13] cpufreq: amd_freq_sensitivity: Remove unused ID structs Lee Jones
2020-07-14 14:50 ` Lee Jones
2020-07-14 17:15 ` Kim Phillips
2020-07-14 17:15 ` Kim Phillips
2020-07-14 21:02 ` Lee Jones
2020-07-14 21:02 ` Lee Jones
2020-07-14 21:13 ` Kim Phillips
2020-07-14 21:13 ` Kim Phillips
2020-07-15 6:47 ` Lee Jones
2020-07-15 6:47 ` Lee Jones
2020-07-15 3:36 ` [PATCH 00/13] Rid W=1 warnings in CPUFreq Viresh Kumar
2020-07-15 3:36 ` Viresh Kumar
2020-07-15 6:32 ` Lee Jones
2020-07-15 6:32 ` Lee Jones
2020-07-15 6:38 ` Viresh Kumar
2020-07-15 6:38 ` Viresh Kumar
2020-07-15 7:34 ` Lee Jones
2020-07-15 7:34 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200715063607.GQ1398296@dell \
--to=lee.jones@linaro.org \
--cc=benh@kernel.crashing.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=olof@lixom.net \
--cc=paulus@samba.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.