* [PATCH] usb: gadget: net2272: skip BAR1 on error handling paths in probe
@ 2020-07-15 16:40 Evgeny Novikov
0 siblings, 0 replies; only message in thread
From: Evgeny Novikov @ 2020-07-15 16:40 UTC (permalink / raw)
To: Felipe Balbi
Cc: Evgeny Novikov, Greg Kroah-Hartman, Christophe JAILLET,
Jason Yan, Arnd Bergmann, linux-usb, linux-kernel, ldv-project
net2272_rdk1_probe() skips "i == 1" (BAR1) during allocation of
resources. The patch does this on error hanling paths as well.
Found by Linux Driver Verification project (linuxtesting.org).
Signed-off-by: Evgeny Novikov <novikov@ispras.ru>
---
drivers/usb/gadget/udc/net2272.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/gadget/udc/net2272.c b/drivers/usb/gadget/udc/net2272.c
index 928057b206f1..639631d44b00 100644
--- a/drivers/usb/gadget/udc/net2272.c
+++ b/drivers/usb/gadget/udc/net2272.c
@@ -2370,6 +2370,8 @@ net2272_rdk1_probe(struct pci_dev *pdev, struct net2272 *dev)
err:
while (--i >= 0) {
+ if (i == 1)
+ continue; /* BAR1 unused */
iounmap(mem_mapped_addr[i]);
release_mem_region(pci_resource_start(pdev, i),
pci_resource_len(pdev, i));
--
2.16.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-07-15 16:40 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-15 16:40 [PATCH] usb: gadget: net2272: skip BAR1 on error handling paths in probe Evgeny Novikov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.