* [PATCH -next] s390/mm: Convert to DEFINE_SHOW_ATTRIBUTE
@ 2020-07-16 9:07 ` Qinglang Miao
0 siblings, 0 replies; 5+ messages in thread
From: Qinglang Miao @ 2020-07-16 9:07 UTC (permalink / raw)
To: Greg Kroah-Hartman, Heiko Carstens, Vasily Gorbik, Christian Borntraeger
Cc: linux-s390, linux-kernel
From: Chen Huang <chenhuang5@huawei.com>
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Chen Huang <chenhuang5@huawei.com>
---
arch/s390/mm/dump_pagetables.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/arch/s390/mm/dump_pagetables.c b/arch/s390/mm/dump_pagetables.c
index 9adb10a05..ce65bea17 100644
--- a/arch/s390/mm/dump_pagetables.c
+++ b/arch/s390/mm/dump_pagetables.c
@@ -261,17 +261,7 @@ static int ptdump_show(struct seq_file *m, void *v)
return 0;
}
-static int ptdump_open(struct inode *inode, struct file *filp)
-{
- return single_open(filp, ptdump_show, NULL);
-}
-
-static const struct file_operations ptdump_fops = {
- .open = ptdump_open,
- .read_iter = seq_read_iter,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(ptdump);
static int pt_dump_init(void)
{
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH -next] s390/mm: Convert to DEFINE_SHOW_ATTRIBUTE
@ 2020-07-16 9:07 ` Qinglang Miao
0 siblings, 0 replies; 5+ messages in thread
From: Qinglang Miao @ 2020-07-16 9:07 UTC (permalink / raw)
To: Greg Kroah-Hartman, Heiko Carstens, Vasily Gorbik, Christian Borntraeger
Cc: linux-s390, linux-kernel
From: Chen Huang <chenhuang5@huawei.com>
Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
Signed-off-by: Chen Huang <chenhuang5@huawei.com>
---
arch/s390/mm/dump_pagetables.c | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/arch/s390/mm/dump_pagetables.c b/arch/s390/mm/dump_pagetables.c
index 9adb10a05..ce65bea17 100644
--- a/arch/s390/mm/dump_pagetables.c
+++ b/arch/s390/mm/dump_pagetables.c
@@ -261,17 +261,7 @@ static int ptdump_show(struct seq_file *m, void *v)
return 0;
}
-static int ptdump_open(struct inode *inode, struct file *filp)
-{
- return single_open(filp, ptdump_show, NULL);
-}
-
-static const struct file_operations ptdump_fops = {
- .open = ptdump_open,
- .read_iter = seq_read_iter,
- .llseek = seq_lseek,
- .release = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(ptdump);
static int pt_dump_init(void)
{
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH -next] s390/mm: Convert to DEFINE_SHOW_ATTRIBUTE
2020-07-16 9:07 ` Qinglang Miao
(?)
@ 2020-07-16 11:26 ` Heiko Carstens
2020-07-17 1:19 ` miaoqinglang
-1 siblings, 1 reply; 5+ messages in thread
From: Heiko Carstens @ 2020-07-16 11:26 UTC (permalink / raw)
To: Qinglang Miao
Cc: Greg Kroah-Hartman, Vasily Gorbik, Christian Borntraeger,
linux-s390, linux-kernel, Sven Schnelle
On Thu, Jul 16, 2020 at 05:07:03PM +0800, Qinglang Miao wrote:
> From: Chen Huang <chenhuang5@huawei.com>
>
> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>
> Signed-off-by: Chen Huang <chenhuang5@huawei.com>
> ---
> arch/s390/mm/dump_pagetables.c | 12 +-----------
> 1 file changed, 1 insertion(+), 11 deletions(-)
Thanks for the patch, however we are going to convert the s390 page
table dumper to generic code, so I'm not going to apply any cleanup
patches for this code anymore.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] s390/mm: Convert to DEFINE_SHOW_ATTRIBUTE
2020-07-16 11:26 ` Heiko Carstens
@ 2020-07-17 1:19 ` miaoqinglang
0 siblings, 0 replies; 5+ messages in thread
From: miaoqinglang @ 2020-07-17 1:19 UTC (permalink / raw)
To: Heiko Carstens
Cc: Greg Kroah-Hartman, Vasily Gorbik, Christian Borntraeger,
linux-s390, linux-kernel, Sven Schnelle
在 2020/7/16 19:26, Heiko Carstens 写道:
> On Thu, Jul 16, 2020 at 05:07:03PM +0800, Qinglang Miao wrote:
>> From: Chen Huang <chenhuang5@huawei.com>
>>
>> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>>
>> Signed-off-by: Chen Huang <chenhuang5@huawei.com>
>> ---
>> arch/s390/mm/dump_pagetables.c | 12 +-----------
>> 1 file changed, 1 insertion(+), 11 deletions(-)
> Thanks for the patch, however we are going to convert the s390 page
> table dumper to generic code, so I'm not going to apply any cleanup
> patches for this code anymore.
Thanks for your replay, I'm glad to know that.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH -next] s390/mm: Convert to DEFINE_SHOW_ATTRIBUTE
@ 2020-07-17 1:19 ` miaoqinglang
0 siblings, 0 replies; 5+ messages in thread
From: miaoqinglang @ 2020-07-17 1:19 UTC (permalink / raw)
To: Heiko Carstens
Cc: Greg Kroah-Hartman, Vasily Gorbik, Christian Borntraeger,
linux-s390, linux-kernel, Sven Schnelle
锟斤拷 2020/7/16 19:26, Heiko Carstens 写锟斤拷:
> On Thu, Jul 16, 2020 at 05:07:03PM +0800, Qinglang Miao wrote:
>> From: Chen Huang <chenhuang5@huawei.com>
>>
>> Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.
>>
>> Signed-off-by: Chen Huang <chenhuang5@huawei.com>
>> ---
>> arch/s390/mm/dump_pagetables.c | 12 +-----------
>> 1 file changed, 1 insertion(+), 11 deletions(-)
> Thanks for the patch, however we are going to convert the s390 page
> table dumper to generic code, so I'm not going to apply any cleanup
> patches for this code anymore.
Thanks for your replay, I'm glad to know that.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-07-17 1:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-16 9:07 [PATCH -next] s390/mm: Convert to DEFINE_SHOW_ATTRIBUTE Qinglang Miao
2020-07-16 9:07 ` Qinglang Miao
2020-07-16 11:26 ` Heiko Carstens
2020-07-17 1:19 ` miaoqinglang
2020-07-17 1:19 ` miaoqinglang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.