From: Thierry Reding <thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Lorenzo Pieralisi <lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org>, Bjorn Helgaas <bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>, Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: Jon Hunter <jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>, linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH v2 2/2] PCI: tegra: Remove PLL power supplies Date: Thu, 16 Jul 2020 15:00:34 +0200 [thread overview] Message-ID: <20200716130034.GE535268@ulmo> (raw) In-Reply-To: <20200623145528.1658337-2-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> [-- Attachment #1: Type: text/plain, Size: 2647 bytes --] On Tue, Jun 23, 2020 at 04:55:28PM +0200, Thierry Reding wrote: > From: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> > > The Tegra PCI controller driver doesn't need to control the PLL power > supplies directly, but rather uses the pads provided by the XUSB pad > controller, which in turn is responsible for supplying power to the > PLLs. > > Signed-off-by: Thierry Reding <treding-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> > --- > drivers/pci/controller/pci-tegra.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) Hi Lorenzo, do you have any comments on this? Can we get this into v5.9? Thanks, Thierry > diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c > index 235b456698fc..f87a09d21eb0 100644 > --- a/drivers/pci/controller/pci-tegra.c > +++ b/drivers/pci/controller/pci-tegra.c > @@ -2025,7 +2025,7 @@ static int tegra_pcie_get_regulators(struct tegra_pcie *pcie, u32 lane_mask) > pcie->supplies[i++].supply = "hvdd-pex"; > pcie->supplies[i++].supply = "vddio-pexctl-aud"; > } else if (of_device_is_compatible(np, "nvidia,tegra210-pcie")) { > - pcie->num_supplies = 6; > + pcie->num_supplies = 3; > > pcie->supplies = devm_kcalloc(pcie->dev, pcie->num_supplies, > sizeof(*pcie->supplies), > @@ -2033,14 +2033,11 @@ static int tegra_pcie_get_regulators(struct tegra_pcie *pcie, u32 lane_mask) > if (!pcie->supplies) > return -ENOMEM; > > - pcie->supplies[i++].supply = "avdd-pll-uerefe"; > pcie->supplies[i++].supply = "hvddio-pex"; > pcie->supplies[i++].supply = "dvddio-pex"; > - pcie->supplies[i++].supply = "dvdd-pex-pll"; > - pcie->supplies[i++].supply = "hvdd-pex-pll-e"; > pcie->supplies[i++].supply = "vddio-pex-ctl"; > } else if (of_device_is_compatible(np, "nvidia,tegra124-pcie")) { > - pcie->num_supplies = 7; > + pcie->num_supplies = 4; > > pcie->supplies = devm_kcalloc(dev, pcie->num_supplies, > sizeof(*pcie->supplies), > @@ -2050,11 +2047,8 @@ static int tegra_pcie_get_regulators(struct tegra_pcie *pcie, u32 lane_mask) > > pcie->supplies[i++].supply = "avddio-pex"; > pcie->supplies[i++].supply = "dvddio-pex"; > - pcie->supplies[i++].supply = "avdd-pex-pll"; > pcie->supplies[i++].supply = "hvdd-pex"; > - pcie->supplies[i++].supply = "hvdd-pex-pll-e"; > pcie->supplies[i++].supply = "vddio-pex-ctl"; > - pcie->supplies[i++].supply = "avdd-pll-erefe"; > } else if (of_device_is_compatible(np, "nvidia,tegra30-pcie")) { > bool need_pexa = false, need_pexb = false; > > -- > 2.27.0 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Thierry Reding <thierry.reding@gmail.com> To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>, Bjorn Helgaas <bhelgaas@google.com>, Rob Herring <robh+dt@kernel.org> Cc: Jon Hunter <jonathanh@nvidia.com>, linux-pci@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v2 2/2] PCI: tegra: Remove PLL power supplies Date: Thu, 16 Jul 2020 15:00:34 +0200 [thread overview] Message-ID: <20200716130034.GE535268@ulmo> (raw) In-Reply-To: <20200623145528.1658337-2-thierry.reding@gmail.com> [-- Attachment #1: Type: text/plain, Size: 2589 bytes --] On Tue, Jun 23, 2020 at 04:55:28PM +0200, Thierry Reding wrote: > From: Thierry Reding <treding@nvidia.com> > > The Tegra PCI controller driver doesn't need to control the PLL power > supplies directly, but rather uses the pads provided by the XUSB pad > controller, which in turn is responsible for supplying power to the > PLLs. > > Signed-off-by: Thierry Reding <treding@nvidia.com> > --- > drivers/pci/controller/pci-tegra.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) Hi Lorenzo, do you have any comments on this? Can we get this into v5.9? Thanks, Thierry > diff --git a/drivers/pci/controller/pci-tegra.c b/drivers/pci/controller/pci-tegra.c > index 235b456698fc..f87a09d21eb0 100644 > --- a/drivers/pci/controller/pci-tegra.c > +++ b/drivers/pci/controller/pci-tegra.c > @@ -2025,7 +2025,7 @@ static int tegra_pcie_get_regulators(struct tegra_pcie *pcie, u32 lane_mask) > pcie->supplies[i++].supply = "hvdd-pex"; > pcie->supplies[i++].supply = "vddio-pexctl-aud"; > } else if (of_device_is_compatible(np, "nvidia,tegra210-pcie")) { > - pcie->num_supplies = 6; > + pcie->num_supplies = 3; > > pcie->supplies = devm_kcalloc(pcie->dev, pcie->num_supplies, > sizeof(*pcie->supplies), > @@ -2033,14 +2033,11 @@ static int tegra_pcie_get_regulators(struct tegra_pcie *pcie, u32 lane_mask) > if (!pcie->supplies) > return -ENOMEM; > > - pcie->supplies[i++].supply = "avdd-pll-uerefe"; > pcie->supplies[i++].supply = "hvddio-pex"; > pcie->supplies[i++].supply = "dvddio-pex"; > - pcie->supplies[i++].supply = "dvdd-pex-pll"; > - pcie->supplies[i++].supply = "hvdd-pex-pll-e"; > pcie->supplies[i++].supply = "vddio-pex-ctl"; > } else if (of_device_is_compatible(np, "nvidia,tegra124-pcie")) { > - pcie->num_supplies = 7; > + pcie->num_supplies = 4; > > pcie->supplies = devm_kcalloc(dev, pcie->num_supplies, > sizeof(*pcie->supplies), > @@ -2050,11 +2047,8 @@ static int tegra_pcie_get_regulators(struct tegra_pcie *pcie, u32 lane_mask) > > pcie->supplies[i++].supply = "avddio-pex"; > pcie->supplies[i++].supply = "dvddio-pex"; > - pcie->supplies[i++].supply = "avdd-pex-pll"; > pcie->supplies[i++].supply = "hvdd-pex"; > - pcie->supplies[i++].supply = "hvdd-pex-pll-e"; > pcie->supplies[i++].supply = "vddio-pex-ctl"; > - pcie->supplies[i++].supply = "avdd-pll-erefe"; > } else if (of_device_is_compatible(np, "nvidia,tegra30-pcie")) { > bool need_pexa = false, need_pexb = false; > > -- > 2.27.0 > [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-07-16 13:00 UTC|newest] Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-06-23 14:55 [PATCH v2 1/2] dt-bindings: pci: tegra: Remove PLL power supplies Thierry Reding 2020-06-23 14:55 ` Thierry Reding [not found] ` <20200623145528.1658337-1-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-06-23 14:55 ` [PATCH v2 2/2] PCI: " Thierry Reding 2020-06-23 14:55 ` Thierry Reding [not found] ` <20200623145528.1658337-2-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> 2020-07-16 13:00 ` Thierry Reding [this message] 2020-07-16 13:00 ` Thierry Reding 2020-07-16 14:07 ` Lorenzo Pieralisi 2020-07-16 14:07 ` Lorenzo Pieralisi [not found] ` <20200716140704.GA20249-LhTu/34fCX3ZROr8t4l/smS4ubULX0JqMm0uRHvK7Nw@public.gmane.org> 2020-07-16 15:06 ` Thierry Reding 2020-07-16 15:06 ` Thierry Reding 2020-07-27 16:21 ` Rob Herring 2020-07-27 17:21 ` Thierry Reding 2020-07-27 17:43 ` Rob Herring 2020-07-16 12:59 ` [PATCH v2 1/2] dt-bindings: pci: " Thierry Reding 2020-07-16 12:59 ` Thierry Reding 2020-07-17 10:48 ` Lorenzo Pieralisi 2020-07-17 10:48 ` Lorenzo Pieralisi 2020-07-27 16:17 ` Rob Herring 2020-07-28 10:20 ` Lorenzo Pieralisi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200716130034.GE535268@ulmo \ --to=thierry.reding-re5jqeeqqe8avxtiumwx3w@public.gmane.org \ --cc=bhelgaas-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org \ --cc=jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org \ --cc=linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=lorenzo.pieralisi-5wv7dgnIgG8@public.gmane.org \ --cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.