[PATCH 1/6] arm-toolchain/external-arm-toolchain: rename common include

[PATCH 1/6] arm-toolchain/external-arm-toolchain: rename common include

[Ross Burton]

From: Ross Burton <ross.burton@arm.com>

These recipes all used a common include
external-arm-toolchain-x86host.inc, but that name isn't very meaningful:
the recipes are for x86-64, there typically are more than x86-64
binaries available, and it's not for an external toolchain but
integrating a binary toolchain.

Rename the include to arm-binary-toolchain.inc, as they're all the Arm
binary toolchain.

Change-Id: I59f5faa7373686958e226db0aa68e7880d36400e
Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 ...ernal-arm-toolchain-x86host.inc => arm-binary-toolchain.inc} | 0
 .../recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb | 2 +-
 .../external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb  | 2 +-
 .../external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb | 2 +-
 4 files changed, 3 insertions(+), 3 deletions(-)
 rename meta-arm-toolchain/recipes-devtools/external-arm-toolchain/{external-arm-toolchain-x86host.inc => arm-binary-toolchain.inc} (100%)

diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain-x86host.inc b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
similarity index 100%
rename from meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain-x86host.inc
rename to meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb
index 4aeba68..7a7673b 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb
@@ -3,7 +3,7 @@
 # Copyright (c) 2020 Arm Limited
 #
 
-require external-arm-toolchain-x86host.inc
+require arm-binary-toolchain.inc
 
 SUMMARY = "Baremetal Armcompiler for Cortex-A, Cortex-R and Cortex-M processors"
 HOMEPAGE = "https://developer.arm.com/tools-and-software/embedded/arm-compiler/downloads/version-6"
diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
index a45fee0..020bbf8 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
@@ -1,7 +1,7 @@
 # Copyright (C) 2020 Texas Instruments Inc.
 # Released under the MIT license (see COPYING.MIT for the terms)
 
-require external-arm-toolchain-x86host.inc
+require arm-binary-toolchain.inc
 
 SUMMARY = "Baremetal GCC for Aarch64 processors"
 LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"
diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
index 6403fe1..77e44ce 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
@@ -1,7 +1,7 @@
 # Copyright (C) 2019 Garmin Ltd. or its subsidiaries
 # Released under the MIT license (see COPYING.MIT for the terms)
 
-require external-arm-toolchain-x86host.inc
+require arm-binary-toolchain.inc
 
 SUMMARY = "Baremetal GCC for ARM-R and ARM-M processors"
 LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"
-- 
2.26.2

[PATCH 2/6] arm-toolchain/gcc-aarch-none-elf: don't use GFLD as license checksum

[Ross Burton]

From: Ross Burton <ross.burton@arm.com>

The GFDL license statement isn't a good choice for the GCC license
checksum, instead use Copying.html from the documentation.

Change-Id: I265bb0add795f3de40f49f8c31127ac9215d2566
Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 .../external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
index 020bbf8..f156143 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
@@ -6,12 +6,11 @@ require arm-binary-toolchain.inc
 SUMMARY = "Baremetal GCC for Aarch64 processors"
 LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"
 
-LIC_FILES_CHKSUM = "file://share/doc/gcc/GNU-Free-Documentation-License.html;md5=cc1e9a49a59ce7e6ae5ef37cd16eca0c"
+LIC_FILES_CHKSUM = "file://share/doc/gcc/Copying.html;md5=c1df856e21b17e58b0adbe29cacf4bd4"
 
 PROVIDES = "virtual/aarch64-none-elf-gcc"
 
 SRC_URI = "https://developer.arm.com/-/media/Files/downloads/gnu-a/${PV}/binrel/gcc-arm-${PV}-x86_64-${BINNAME}.tar.xz"
-
 SRC_URI[sha256sum] = "36d2cbe7c2984f2c20f562ac2f3ba524c59151adfa8ee10f1326c88de337b6d1"
 
 S = "${WORKDIR}/gcc-arm-${PV}-x86_64-${BINNAME}"
-- 
2.26.2

[PATCH 3/6] arm-toolchain/recipes-devtools: move compatible host assignments

[Ross Burton]

From: Ross Burton <ross.burton@arm.com>

Some of the toolchains are available in more than just x86-64, so move
the COMPATIBLE_HOST assignment out of the include and into the recipes.

Change-Id: I10977593935bc7dc50196132d43541aed585cc18
Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 .../external-arm-toolchain/arm-binary-toolchain.inc             | 2 --
 .../recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb | 2 ++
 .../external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb  | 2 ++
 .../external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb | 2 ++
 4 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
index d262e39..d099481 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
@@ -1,5 +1,3 @@
-COMPATIBLE_HOST = "x86_64.*-linux"
-
 FILES_${PN} = "${datadir} ${bindir}"
 
 BINNAME = "${@d.getVar("BPN").strip("gcc-")}"
diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb
index 7a7673b..8fbb8d0 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb
@@ -26,6 +26,8 @@ PROVIDES = "virtual/armcompiler"
 
 ARMCLANG_VERSION = "DS500-BN-00026-r5p0-15rel0"
 
+COMPATIBLE_HOST = "x86_64.*-linux"
+
 SRC_URI = "https://developer.arm.com/-/media/Files/downloads/compiler/${ARMCLANG_VERSION}.tgz;subdir=${ARMCLANG_VERSION}"
 
 SRC_URI[md5sum] = "fbed6edf5eb211c45df7b8548a10535a"
diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
index f156143..5de0f96 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
@@ -3,6 +3,8 @@
 
 require arm-binary-toolchain.inc
 
+COMPATIBLE_HOST = "x86_64.*-linux"
+
 SUMMARY = "Baremetal GCC for Aarch64 processors"
 LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"
 
diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
index 77e44ce..dcc76a9 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
@@ -3,6 +3,8 @@
 
 require arm-binary-toolchain.inc
 
+COMPATIBLE_HOST = "x86_64.*-linux"
+
 SUMMARY = "Baremetal GCC for ARM-R and ARM-M processors"
 LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"
 
-- 
2.26.2

[PATCH 4/6] arm-toolchain/arm-binary-toolchain: more QA skipping

[Ross Burton]

From: Ross Burton <ross.burton@arm.com>

When building nativesdk or target forms of these recipes more QA tests
are executed, which produce more warnings. As these recipes are quite
special, skip more tests:

- arch, as we ship ilp32 binaries in aarch64 packages
- dev-so, as the entire toolchain is put into a single package

Change-Id: Ib72b224749642c912278f0d5601fe04b30afc25f
Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 .../external-arm-toolchain/arm-binary-toolchain.inc             | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
index d099481..2fbabfb 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
@@ -13,7 +13,7 @@ do_install() {
     done
 }
 
-INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps"
+INSANE_SKIP_${PN} = "already-stripped libdir staticdev file-rdeps arch dev-so"
 
 INHIBIT_SYSROOT_STRIP = "1"
 INHIBIT_PACKAGE_STRIP = "1"
-- 
2.26.2

[PATCH 5/6] arm-toolchain/gcc-aarch64-none-elf: support aarch64 hosts

[Ross Burton]

From: Ross Burton <ross.burton@arm.com>

This binary toolchain is also available for aarch64, so support fetching
that too.

Change-Id: I788fcd95c30b97f095593059e85de9a99710be05
Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 .../gcc-aarch64-none-elf_9.2-2019.12.bb             | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
index 5de0f96..221c07a 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
@@ -3,16 +3,19 @@
 
 require arm-binary-toolchain.inc
 
-COMPATIBLE_HOST = "x86_64.*-linux"
+COMPATIBLE_HOST = "(x86_64|aarch64).*-linux"
 
 SUMMARY = "Baremetal GCC for Aarch64 processors"
 LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"
 
-LIC_FILES_CHKSUM = "file://share/doc/gcc/Copying.html;md5=c1df856e21b17e58b0adbe29cacf4bd4"
+LIC_FILES_CHKSUM = "${@d.getVar(d.expand("LIC_FILES_CHKSUM_${HOST_ARCH}"))}"
+LIC_FILES_CHKSUM_aarch64 = "file://share/doc/gcc/Copying.html;md5=1b548d9c341b3b5c82bc88551964aa60"
+LIC_FILES_CHKSUM_x86-64 = "file://share/doc/gcc/Copying.html;md5=c1df856e21b17e58b0adbe29cacf4bd4"
 
 PROVIDES = "virtual/aarch64-none-elf-gcc"
 
-SRC_URI = "https://developer.arm.com/-/media/Files/downloads/gnu-a/${PV}/binrel/gcc-arm-${PV}-x86_64-${BINNAME}.tar.xz"
-SRC_URI[sha256sum] = "36d2cbe7c2984f2c20f562ac2f3ba524c59151adfa8ee10f1326c88de337b6d1"
+SRC_URI = "https://developer.arm.com/-/media/Files/downloads/gnu-a/${PV}/binrel/gcc-arm-${PV}-${HOST_ARCH}-${BINNAME}.tar.xz;name=gnu-a-${HOST_ARCH}"
+SRC_URI[gnu-a-x86_64.sha256sum] = "36d2cbe7c2984f2c20f562ac2f3ba524c59151adfa8ee10f1326c88de337b6d1"
+SRC_URI[gnu-a-aarch64.sha256sum] = "041ca53bdd434b1a48f32161e957da1b84543c373d1881e2fd84a1579f87f243"
 
-S = "${WORKDIR}/gcc-arm-${PV}-x86_64-${BINNAME}"
+S = "${WORKDIR}/gcc-arm-${PV}-${HOST_ARCH}-${BINNAME}"
-- 
2.26.2

[PATCH 6/6] arm-toolchain/gcc-arm-none-eabi: support aarch64 hosts

[Ross Burton]

From: Ross Burton <ross.burton@arm.com>

This binary toolchain is also available for aarch64, so support fetching
that too.

Change-Id: I6206d8a9b4221d8461070d0cb7fff40c712c3df0
Signed-off-by: Ross Burton <ross.burton@arm.com>
---
 .../gcc-arm-none-eabi_9-2019-q4-major.bb                 | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
index dcc76a9..ede9ae9 100644
--- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
+++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
@@ -3,7 +3,7 @@
 
 require arm-binary-toolchain.inc
 
-COMPATIBLE_HOST = "x86_64.*-linux"
+COMPATIBLE_HOST = "(x86_64|aarch64).*-linux"
 
 SUMMARY = "Baremetal GCC for ARM-R and ARM-M processors"
 LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"
@@ -12,7 +12,6 @@ LIC_FILES_CHKSUM = "file://share/doc/gcc-arm-none-eabi/license.txt;md5=c18349634
 
 PROVIDES = "virtual/arm-none-eabi-gcc"
 
-SRC_URI = "https://developer.arm.com/-/media/Files/downloads/gnu-rm/9-2019q4/${BPN}-${PV}-x86_64-linux.tar.bz2"
-
-SRC_URI[md5sum] = "fe0029de4f4ec43cf7008944e34ff8cc"
-SRC_URI[sha256sum] = "bcd840f839d5bf49279638e9f67890b2ef3a7c9c7a9b25271e83ec4ff41d177a"
+SRC_URI = "https://developer.arm.com/-/media/Files/downloads/gnu-rm/9-2019q4/${BPN}-${PV}-${HOST_ARCH}-linux.tar.bz2;name=gnu-rm-${HOST_ARCH}"
+SRC_URI[gnu-rm-x86_64.sha256sum] = "bcd840f839d5bf49279638e9f67890b2ef3a7c9c7a9b25271e83ec4ff41d177a"
+SRC_URI[gnu-rm-aarch64.sha256sum] = "1f5b9309006737950b2218250e6bb392e2d68d4f1a764fe66be96e2a78888d83"
-- 
2.26.2

Re: [meta-arm] [PATCH 1/6] arm-toolchain/external-arm-toolchain: rename common include

[Sumit Garg]

On Thu, 16 Jul 2020 at 20:25, Ross Burton <ross@burtonini.com> wrote:
>
> From: Ross Burton <ross.burton@arm.com>
>
> These recipes all used a common include
> external-arm-toolchain-x86host.inc, but that name isn't very meaningful:
> the recipes are for x86-64, there typically are more than x86-64
> binaries available, and it's not for an external toolchain but
> integrating a binary toolchain.
>
> Rename the include to arm-binary-toolchain.inc, as they're all the Arm
> binary toolchain.
>
> Change-Id: I59f5faa7373686958e226db0aa68e7880d36400e
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
>  ...ernal-arm-toolchain-x86host.inc => arm-binary-toolchain.inc} | 0
>  .../recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb | 2 +-
>  .../external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb  | 2 +-
>  .../external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb | 2 +-
>  4 files changed, 3 insertions(+), 3 deletions(-)
>  rename meta-arm-toolchain/recipes-devtools/external-arm-toolchain/{external-arm-toolchain-x86host.inc => arm-binary-toolchain.inc} (100%)
>

Looks good to me. For the series:

Reviewed-by: Sumit Garg <sumit.garg@linaro.org>

-Sumit

> diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain-x86host.inc b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
> similarity index 100%
> rename from meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain-x86host.inc
> rename to meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
> diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb
> index 4aeba68..7a7673b 100644
> --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb
> +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb
> @@ -3,7 +3,7 @@
>  # Copyright (c) 2020 Arm Limited
>  #
>
> -require external-arm-toolchain-x86host.inc
> +require arm-binary-toolchain.inc
>
>  SUMMARY = "Baremetal Armcompiler for Cortex-A, Cortex-R and Cortex-M processors"
>  HOMEPAGE = "https://developer.arm.com/tools-and-software/embedded/arm-compiler/downloads/version-6"
> diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
> index a45fee0..020bbf8 100644
> --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
> +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
> @@ -1,7 +1,7 @@
>  # Copyright (C) 2020 Texas Instruments Inc.
>  # Released under the MIT license (see COPYING.MIT for the terms)
>
> -require external-arm-toolchain-x86host.inc
> +require arm-binary-toolchain.inc
>
>  SUMMARY = "Baremetal GCC for Aarch64 processors"
>  LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"
> diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
> index 6403fe1..77e44ce 100644
> --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
> +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
> @@ -1,7 +1,7 @@
>  # Copyright (C) 2019 Garmin Ltd. or its subsidiaries
>  # Released under the MIT license (see COPYING.MIT for the terms)
>
> -require external-arm-toolchain-x86host.inc
> +require arm-binary-toolchain.inc
>
>  SUMMARY = "Baremetal GCC for ARM-R and ARM-M processors"
>  LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"
> --
> 2.26.2
>
> 

Re: [meta-arm] [PATCH 1/6] arm-toolchain/external-arm-toolchain: rename common include

[Jon Mason]

On Fri, Jul 17, 2020 at 12:15:28PM +0530, Sumit Garg wrote:
> On Thu, 16 Jul 2020 at 20:25, Ross Burton <ross@burtonini.com> wrote:
> >
> > From: Ross Burton <ross.burton@arm.com>
> >
> > These recipes all used a common include
> > external-arm-toolchain-x86host.inc, but that name isn't very meaningful:
> > the recipes are for x86-64, there typically are more than x86-64
> > binaries available, and it's not for an external toolchain but
> > integrating a binary toolchain.
> >
> > Rename the include to arm-binary-toolchain.inc, as they're all the Arm
> > binary toolchain.
> >
> > Change-Id: I59f5faa7373686958e226db0aa68e7880d36400e
> > Signed-off-by: Ross Burton <ross.burton@arm.com>
> > ---
> >  ...ernal-arm-toolchain-x86host.inc => arm-binary-toolchain.inc} | 0
> >  .../recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb | 2 +-
> >  .../external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb  | 2 +-
> >  .../external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb | 2 +-
> >  4 files changed, 3 insertions(+), 3 deletions(-)
> >  rename meta-arm-toolchain/recipes-devtools/external-arm-toolchain/{external-arm-toolchain-x86host.inc => arm-binary-toolchain.inc} (100%)
> >
> 
> Looks good to me. For the series:
> 
> Reviewed-by: Sumit Garg <sumit.garg@linaro.org>

Series applied to master.

Thanks,
Jon

> 
> -Sumit
> 
> > diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain-x86host.inc b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
> > similarity index 100%
> > rename from meta-arm-toolchain/recipes-devtools/external-arm-toolchain/external-arm-toolchain-x86host.inc
> > rename to meta-arm-toolchain/recipes-devtools/external-arm-toolchain/arm-binary-toolchain.inc
> > diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb
> > index 4aeba68..7a7673b 100644
> > --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb
> > +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/armcompiler_6.13.bb
> > @@ -3,7 +3,7 @@
> >  # Copyright (c) 2020 Arm Limited
> >  #
> >
> > -require external-arm-toolchain-x86host.inc
> > +require arm-binary-toolchain.inc
> >
> >  SUMMARY = "Baremetal Armcompiler for Cortex-A, Cortex-R and Cortex-M processors"
> >  HOMEPAGE = "https://developer.arm.com/tools-and-software/embedded/arm-compiler/downloads/version-6"
> > diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
> > index a45fee0..020bbf8 100644
> > --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
> > +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-aarch64-none-elf_9.2-2019.12.bb
> > @@ -1,7 +1,7 @@
> >  # Copyright (C) 2020 Texas Instruments Inc.
> >  # Released under the MIT license (see COPYING.MIT for the terms)
> >
> > -require external-arm-toolchain-x86host.inc
> > +require arm-binary-toolchain.inc
> >
> >  SUMMARY = "Baremetal GCC for Aarch64 processors"
> >  LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"
> > diff --git a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
> > index 6403fe1..77e44ce 100644
> > --- a/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
> > +++ b/meta-arm-toolchain/recipes-devtools/external-arm-toolchain/gcc-arm-none-eabi_9-2019-q4-major.bb
> > @@ -1,7 +1,7 @@
> >  # Copyright (C) 2019 Garmin Ltd. or its subsidiaries
> >  # Released under the MIT license (see COPYING.MIT for the terms)
> >
> > -require external-arm-toolchain-x86host.inc
> > +require arm-binary-toolchain.inc
> >
> >  SUMMARY = "Baremetal GCC for ARM-R and ARM-M processors"
> >  LICENSE = "GPL-3.0-with-GCC-exception & GPLv3"
> > --
> > 2.26.2
> >
> > 

>