* [dpdk-dev] [PATCH v1 0/2] enable security feature for security tests @ 2020-07-16 15:29 David Coyle 2020-07-16 15:29 ` [dpdk-dev] [PATCH v1 1/2] test/crypto: " David Coyle 2020-07-16 15:29 ` [dpdk-dev] [PATCH v1 2/2] app/crypto-perf: " David Coyle 0 siblings, 2 replies; 10+ messages in thread From: David Coyle @ 2020-07-16 15:29 UTC (permalink / raw) To: akhil.goyal, declan.doherty, pablo.de.lara.guarch, fiona.trahe Cc: dev, brendan.ryan, mairtin.oloingsigh, David Coyle The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the ff_disable device configuration option for all cryptodev unit tests and crypto performance tests, including security related tests. These patches update the crypto test tools to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP security tests. David Coyle (2): test/crypto: enable security feature for security tests app/crypto-perf: enable security feature for security tests app/test-crypto-perf/main.c | 7 +++++-- app/test/test_cryptodev.c | 22 ++++++++++++++++++---- 2 files changed, 23 insertions(+), 6 deletions(-) -- 2.17.1 ^ permalink raw reply [flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH v1 1/2] test/crypto: enable security feature for security tests 2020-07-16 15:29 [dpdk-dev] [PATCH v1 0/2] enable security feature for security tests David Coyle @ 2020-07-16 15:29 ` David Coyle 2020-07-16 17:05 ` Akhil Goyal 2020-07-17 18:17 ` De Lara Guarch, Pablo 2020-07-16 15:29 ` [dpdk-dev] [PATCH v1 2/2] app/crypto-perf: " David Coyle 1 sibling, 2 replies; 10+ messages in thread From: David Coyle @ 2020-07-16 15:29 UTC (permalink / raw) To: akhil.goyal, declan.doherty, pablo.de.lara.guarch, fiona.trahe Cc: dev, brendan.ryan, mairtin.oloingsigh, David Coyle The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the ff_disable device configuration option for all cryptodev tests, including security related tests. This patch updates the cryptodev unit tests to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP security tests. Fixes: ea31f2b4f547 ("test/crypto: add DOCSIS security cases") Signed-off-by: David Coyle <david.coyle@intel.com> --- app/test/test_cryptodev.c | 22 ++++++++++++++++++---- 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 42e47059a..3d3548bb4 100644 --- a/app/test/test_cryptodev.c +++ b/app/test/test_cryptodev.c @@ -631,7 +631,7 @@ testsuite_teardown(void) } static int -ut_setup(void) +dev_configure_and_start(uint64_t ff_disable) { struct crypto_testsuite_params *ts_params = &testsuite_params; struct crypto_unittest_params *ut_params = &unittest_params; @@ -643,7 +643,7 @@ ut_setup(void) /* Reconfigure device to default parameters */ ts_params->conf.socket_id = SOCKET_ID_ANY; - ts_params->conf.ff_disable = RTE_CRYPTODEV_FF_SECURITY; + ts_params->conf.ff_disable = ff_disable; ts_params->qp_conf.nb_descriptors = MAX_NUM_OPS_INFLIGHT; ts_params->qp_conf.mp_session = ts_params->session_mpool; ts_params->qp_conf.mp_session_private = ts_params->session_priv_mpool; @@ -673,6 +673,20 @@ ut_setup(void) return TEST_SUCCESS; } +static int +ut_setup(void) +{ + /* Configure and start the device with security feature disabled */ + return dev_configure_and_start(RTE_CRYPTODEV_FF_SECURITY); +} + +static int +ut_setup_security(void) +{ + /* Configure and start the device with no features disabled */ + return dev_configure_and_start(0); +} + static void ut_teardown(void) { @@ -12533,9 +12547,9 @@ static struct unit_test_suite cryptodev_testsuite = { test_verify_auth_aes_cmac_cipher_null_test_case_1), #ifdef RTE_LIBRTE_SECURITY - TEST_CASE_ST(ut_setup, ut_teardown, + TEST_CASE_ST(ut_setup_security, ut_teardown, test_PDCP_PROTO_all), - TEST_CASE_ST(ut_setup, ut_teardown, + TEST_CASE_ST(ut_setup_security, ut_teardown, test_DOCSIS_PROTO_all), #endif TEST_CASES_END() /**< NULL terminate unit test array */ -- 2.17.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v1 1/2] test/crypto: enable security feature for security tests 2020-07-16 15:29 ` [dpdk-dev] [PATCH v1 1/2] test/crypto: " David Coyle @ 2020-07-16 17:05 ` Akhil Goyal 2020-07-18 21:18 ` Akhil Goyal 2020-07-17 18:17 ` De Lara Guarch, Pablo 1 sibling, 1 reply; 10+ messages in thread From: Akhil Goyal @ 2020-07-16 17:05 UTC (permalink / raw) To: David Coyle, declan.doherty, pablo.de.lara.guarch, fiona.trahe Cc: dev, brendan.ryan, mairtin.oloingsigh > The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the > ff_disable device configuration option for all cryptodev tests, > including security related tests. This patch updates the cryptodev unit > tests to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP > security tests. > > Fixes: ea31f2b4f547 ("test/crypto: add DOCSIS security cases") > > Signed-off-by: David Coyle <david.coyle@intel.com> > --- Acked-by: Akhil Goyal <akhil.goyal@nxp.com> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v1 1/2] test/crypto: enable security feature for security tests 2020-07-16 17:05 ` Akhil Goyal @ 2020-07-18 21:18 ` Akhil Goyal 0 siblings, 0 replies; 10+ messages in thread From: Akhil Goyal @ 2020-07-18 21:18 UTC (permalink / raw) To: David Coyle, declan.doherty, pablo.de.lara.guarch, fiona.trahe Cc: dev, brendan.ryan, mairtin.oloingsigh > > > > The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the > > ff_disable device configuration option for all cryptodev tests, > > including security related tests. This patch updates the cryptodev unit > > tests to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP > > security tests. > > > > Fixes: ea31f2b4f547 ("test/crypto: add DOCSIS security cases") > > > > Signed-off-by: David Coyle <david.coyle@intel.com> > > --- > Acked-by: Akhil Goyal <akhil.goyal@nxp.com> Patchset applied to dpdk-next-crypto Thanks. ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v1 1/2] test/crypto: enable security feature for security tests 2020-07-16 15:29 ` [dpdk-dev] [PATCH v1 1/2] test/crypto: " David Coyle 2020-07-16 17:05 ` Akhil Goyal @ 2020-07-17 18:17 ` De Lara Guarch, Pablo 2020-07-18 20:07 ` Akhil Goyal 1 sibling, 1 reply; 10+ messages in thread From: De Lara Guarch, Pablo @ 2020-07-17 18:17 UTC (permalink / raw) To: Coyle, David, akhil.goyal, Doherty, Declan, Trahe, Fiona Cc: dev, Ryan, Brendan, O'loingsigh, Mairtin > -----Original Message----- > From: Coyle, David <david.coyle@intel.com> > Sent: Thursday, July 16, 2020 4:30 PM > To: akhil.goyal@nxp.com; Doherty, Declan <declan.doherty@intel.com>; De > Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona > <fiona.trahe@intel.com> > Cc: dev@dpdk.org; Ryan, Brendan <brendan.ryan@intel.com>; O'loingsigh, > Mairtin <mairtin.oloingsigh@intel.com>; Coyle, David <david.coyle@intel.com> > Subject: [PATCH v1 1/2] test/crypto: enable security feature for security tests > > The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the ff_disable > device configuration option for all cryptodev tests, including security related > tests. This patch updates the cryptodev unit tests to not disable > RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP security tests. > > Fixes: ea31f2b4f547 ("test/crypto: add DOCSIS security cases") > > Signed-off-by: David Coyle <david.coyle@intel.com> Actually, since PDCP security tests were added in previous releases, this could be backported, right? Commit d883e6e71 ("test/crypto: add PDCP C-Plane encap cases") added PDCP test cases and the ff_disable option was already present. Akhil, do you think we need to backport this? Pablo ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v1 1/2] test/crypto: enable security feature for security tests 2020-07-17 18:17 ` De Lara Guarch, Pablo @ 2020-07-18 20:07 ` Akhil Goyal 0 siblings, 0 replies; 10+ messages in thread From: Akhil Goyal @ 2020-07-18 20:07 UTC (permalink / raw) To: De Lara Guarch, Pablo, Coyle, David, Doherty, Declan, Trahe, Fiona Cc: dev, Ryan, Brendan, O'loingsigh, Mairtin Hi Pablo, > > > > The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the > ff_disable > > device configuration option for all cryptodev tests, including security related > > tests. This patch updates the cryptodev unit tests to not disable > > RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP security tests. > > > > Fixes: ea31f2b4f547 ("test/crypto: add DOCSIS security cases") > > > > Signed-off-by: David Coyle <david.coyle@intel.com> > > Actually, since PDCP security tests were added in previous releases, this could be > backported, right? Commit d883e6e71 ("test/crypto: add PDCP C-Plane encap > cases") added PDCP test cases and the ff_disable option was already present. > Akhil, do you think we need to backport this? > Good catch, but currently PDCP is only supported by NXP platforms and we do not do anything in dev_configure(), so the change will not make any difference. I believe many PMDs are also not doing anything in the dev_configure(). So I believe there is no need to backport this patch. NXP will fix this in the PMDs when it is required. Regards, Akhil ^ permalink raw reply [flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH v1 2/2] app/crypto-perf: enable security feature for security tests 2020-07-16 15:29 [dpdk-dev] [PATCH v1 0/2] enable security feature for security tests David Coyle 2020-07-16 15:29 ` [dpdk-dev] [PATCH v1 1/2] test/crypto: " David Coyle @ 2020-07-16 15:29 ` David Coyle 2020-07-16 17:01 ` Akhil Goyal 2020-07-17 18:19 ` De Lara Guarch, Pablo 1 sibling, 2 replies; 10+ messages in thread From: David Coyle @ 2020-07-16 15:29 UTC (permalink / raw) To: akhil.goyal, declan.doherty, pablo.de.lara.guarch, fiona.trahe Cc: dev, brendan.ryan, mairtin.oloingsigh, David Coyle The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the ff_disable device configuration option for all crypto performance tests, including security related tests. This patch updates the crypto performance tool to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP security tests. Fixes: d4a131a9498d ("test/crypto-perf: support DOCSIS protocol") Signed-off-by: David Coyle <david.coyle@intel.com> --- app/test-crypto-perf/main.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c index edeea9c1b..8f8e580e4 100644 --- a/app/test-crypto-perf/main.c +++ b/app/test-crypto-perf/main.c @@ -203,10 +203,13 @@ cperf_initialize_cryptodev(struct cperf_options *opts, uint8_t *enabled_cdevs) struct rte_cryptodev_config conf = { .nb_queue_pairs = opts->nb_qps, .socket_id = socket_id, - .ff_disable = RTE_CRYPTODEV_FF_SECURITY | - RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO, + .ff_disable = RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO, }; + if (opts->op_type != CPERF_PDCP && + opts->op_type != CPERF_DOCSIS) + conf.ff_disable |= RTE_CRYPTODEV_FF_SECURITY; + struct rte_cryptodev_qp_conf qp_conf = { .nb_descriptors = opts->nb_descriptors }; -- 2.17.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v1 2/2] app/crypto-perf: enable security feature for security tests 2020-07-16 15:29 ` [dpdk-dev] [PATCH v1 2/2] app/crypto-perf: " David Coyle @ 2020-07-16 17:01 ` Akhil Goyal 2020-07-17 18:19 ` De Lara Guarch, Pablo 1 sibling, 0 replies; 10+ messages in thread From: Akhil Goyal @ 2020-07-16 17:01 UTC (permalink / raw) To: David Coyle, declan.doherty, pablo.de.lara.guarch, fiona.trahe Cc: dev, brendan.ryan, mairtin.oloingsigh > > The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the > ff_disable device configuration option for all crypto performance tests, > including security related tests. This patch updates the crypto > performance tool to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and > PDCP security tests. > > Fixes: d4a131a9498d ("test/crypto-perf: support DOCSIS protocol") > > Signed-off-by: David Coyle <david.coyle@intel.com> > --- Acked-by: Akhil Goyal <akhil.goyal@nxp.com> ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v1 2/2] app/crypto-perf: enable security feature for security tests 2020-07-16 15:29 ` [dpdk-dev] [PATCH v1 2/2] app/crypto-perf: " David Coyle 2020-07-16 17:01 ` Akhil Goyal @ 2020-07-17 18:19 ` De Lara Guarch, Pablo 2020-07-18 20:08 ` Akhil Goyal 1 sibling, 1 reply; 10+ messages in thread From: De Lara Guarch, Pablo @ 2020-07-17 18:19 UTC (permalink / raw) To: Coyle, David, akhil.goyal, Doherty, Declan, Trahe, Fiona Cc: dev, Ryan, Brendan, O'loingsigh, Mairtin > -----Original Message----- > From: Coyle, David <david.coyle@intel.com> > Sent: Thursday, July 16, 2020 4:30 PM > To: akhil.goyal@nxp.com; Doherty, Declan <declan.doherty@intel.com>; De > Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona > <fiona.trahe@intel.com> > Cc: dev@dpdk.org; Ryan, Brendan <brendan.ryan@intel.com>; O'loingsigh, > Mairtin <mairtin.oloingsigh@intel.com>; Coyle, David <david.coyle@intel.com> > Subject: [PATCH v1 2/2] app/crypto-perf: enable security feature for security > tests > > The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the ff_disable > device configuration option for all crypto performance tests, including security > related tests. This patch updates the crypto performance tool to not disable > RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP security tests. > > Fixes: d4a131a9498d ("test/crypto-perf: support DOCSIS protocol") > > Signed-off-by: David Coyle <david.coyle@intel.com> Same comment as on the first patch of this set, but with commit 8fd2b5a60d1 ("app/crypto-perf: support PDCP") Thanks, Pablo ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [dpdk-dev] [PATCH v1 2/2] app/crypto-perf: enable security feature for security tests 2020-07-17 18:19 ` De Lara Guarch, Pablo @ 2020-07-18 20:08 ` Akhil Goyal 0 siblings, 0 replies; 10+ messages in thread From: Akhil Goyal @ 2020-07-18 20:08 UTC (permalink / raw) To: De Lara Guarch, Pablo, Coyle, David, Doherty, Declan, Trahe, Fiona Cc: dev, Ryan, Brendan, O'loingsigh, Mairtin > > The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the > ff_disable > > device configuration option for all crypto performance tests, including security > > related tests. This patch updates the crypto performance tool to not disable > > RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP security tests. > > > > Fixes: d4a131a9498d ("test/crypto-perf: support DOCSIS protocol") > > > > Signed-off-by: David Coyle <david.coyle@intel.com> > > Same comment as on the first patch of this set, but with commit 8fd2b5a60d1 > ("app/crypto-perf: support PDCP") > No need to backport this as well as explained in the 1st patch. ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-07-18 21:18 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-07-16 15:29 [dpdk-dev] [PATCH v1 0/2] enable security feature for security tests David Coyle 2020-07-16 15:29 ` [dpdk-dev] [PATCH v1 1/2] test/crypto: " David Coyle 2020-07-16 17:05 ` Akhil Goyal 2020-07-18 21:18 ` Akhil Goyal 2020-07-17 18:17 ` De Lara Guarch, Pablo 2020-07-18 20:07 ` Akhil Goyal 2020-07-16 15:29 ` [dpdk-dev] [PATCH v1 2/2] app/crypto-perf: " David Coyle 2020-07-16 17:01 ` Akhil Goyal 2020-07-17 18:19 ` De Lara Guarch, Pablo 2020-07-18 20:08 ` Akhil Goyal
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.