From: Alan Stern <stern@rowland.harvard.edu>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org,
Janusz Krzysztofik <jmkrzyszt@gmail.com>,
Tony Lindgren <tony@atomide.com>
Subject: Re: [PATCH 2/2 v2] usb: ohci-omap: Convert to use GPIO descriptors
Date: Thu, 16 Jul 2020 11:41:13 -0400 [thread overview]
Message-ID: <20200716154113.GD1112537@rowland.harvard.edu> (raw)
In-Reply-To: <20200716123433.155854-2-linus.walleij@linaro.org>
On Thu, Jul 16, 2020 at 02:34:33PM +0200, Linus Walleij wrote:
> The OMAP1 OHCI driver is using the legacy GPIO API to grab some
> random GPIO lines. One is from the TPS65010 chip and used for
> power, another one is for overcurrent and while the driver picks
> this line it doesn't watch it at all.
If the driver doesn't use this GPIO, why keep the code to grab it?
> Convert the driver and the OMAP1 OSK board file to pass these
> two GPIOs as machine descrived GPIO descriptors.
-----------------------------^
>
> Cc: Janusz Krzysztofik <jmkrzyszt@gmail.com>
> Cc: Tony Lindgren <tony@atomide.com>
> Cc: Alan Stern <stern@rowland.harvard.edu>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
Aside from this I don't have any objections.
Alan Stern
next prev parent reply other threads:[~2020-07-16 15:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 12:34 [PATCH 1/2 v2] usb: ohci-omap: Create private state container Linus Walleij
2020-07-16 12:34 ` [PATCH 2/2 v2] usb: ohci-omap: Convert to use GPIO descriptors Linus Walleij
2020-07-16 15:41 ` Alan Stern [this message]
2020-07-17 13:49 ` Linus Walleij
2020-07-17 14:33 ` Alan Stern
2020-07-16 15:38 ` [PATCH 1/2 v2] usb: ohci-omap: Create private state container Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200716154113.GD1112537@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=gregkh@linuxfoundation.org \
--cc=jmkrzyszt@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-usb@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.