Re: [PATCH 2/2 v2] usb: ohci-omap: Convert to use GPIO descriptors

[Linus Walleij <linus.walleij@linaro.org>]

On Thu, Jul 16, 2020 at 5:41 PM Alan Stern <stern@rowland.harvard.edu> wrote:
> On Thu, Jul 16, 2020 at 02:34:33PM +0200, Linus Walleij wrote:
> > The OMAP1 OHCI driver is using the legacy GPIO API to grab some
> > random GPIO lines. One is from the TPS65010 chip and used for
> > power, another one is for overcurrent and while the driver picks
> > this line it doesn't watch it at all.
>
> If the driver doesn't use this GPIO, why keep the code to grab it?

I think it gives a hint to someone who later tries to debug
problems with the hardware that they should maybe go and
complete this overcurrent feature.

Keeping with the paradigm that a patch should be one technological
step (converting to GPIO descriptors) that should be a
third patch (retireing dead code). But I can certainly add a
patch like that if required.

> > Convert the driver and the OMAP1 OSK board file to pass these
> > two GPIOs as machine descrived GPIO descriptors.
> -----------------------------^

Oooups.

> > Cc: Janusz Krzysztofik <jmkrzyszt@gmail.com>
> > Cc: Tony Lindgren <tony@atomide.com>
> > Cc: Alan Stern <stern@rowland.harvard.edu>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
>
> Aside from this I don't have any objections.

Does that qualify as an ACK or do you still want me to remove
the overcurrent template code?

Yours,
Linus Walleij