All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] x86/split_lock: Enumerate split lock feature on Sapphire Rapids
@ 2020-06-26 21:55 Fenghua Yu
  2020-07-16 19:37 ` Fenghua Yu
  0 siblings, 1 reply; 5+ messages in thread
From: Fenghua Yu @ 2020-06-26 21:55 UTC (permalink / raw)
  To: Thomas Gleixner, Borislav Petkov, Ingo Molnar, Peter Zijlstra,
	Tony Luck, Ashok Raj, Ravi V Shankar
  Cc: x86, linux-kernel, Fenghua Yu

Add Sapphire Rapids processor to CPU list to enumerate split lock
feature.

Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Reviewed-by: Tony Luck <tony.luck@intel.com>
---
 arch/x86/kernel/cpu/intel.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index c25a67a34bd3..dca069ad6671 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -1148,6 +1148,7 @@ static const struct x86_cpu_id split_lock_cpu_ids[] __initconst = {
 	X86_MATCH_INTEL_FAM6_MODEL(ATOM_TREMONT_L,	1),
 	X86_MATCH_INTEL_FAM6_MODEL(TIGERLAKE_L,		1),
 	X86_MATCH_INTEL_FAM6_MODEL(TIGERLAKE,		1),
+	X86_MATCH_INTEL_FAM6_MODEL(SAPPHIRERAPIDS_X,	1),
 	{}
 };
 
-- 
2.19.1


^ permalink raw reply related	[flat|nested] 5+ messages in thread
* Re: [PATCH] x86/split_lock: Enumerate split lock feature on Sapphire Rapids
  2020-06-26 21:55 [PATCH] x86/split_lock: Enumerate split lock feature on Sapphire Rapids Fenghua Yu
@ 2020-07-16 19:37 ` Fenghua Yu
  2020-07-16 19:50   ` Peter Zijlstra
  0 siblings, 1 reply; 5+ messages in thread
From: Fenghua Yu @ 2020-07-16 19:37 UTC (permalink / raw)
  To: Thomas Gleixner, Borislav Petkov, Ingo Molnar, Peter Zijlstra,
	Tony Luck, Ashok Raj, Ravi V Shankar
  Cc: x86, linux-kernel

Hi, Thomas, Boris, Ingo,

On Fri, Jun 26, 2020 at 02:55:34PM -0700, Fenghua Yu wrote:
> Add Sapphire Rapids processor to CPU list to enumerate split lock
> feature.
> 
> Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> Reviewed-by: Tony Luck <tony.luck@intel.com>
> ---
>  arch/x86/kernel/cpu/intel.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
> index c25a67a34bd3..dca069ad6671 100644
> --- a/arch/x86/kernel/cpu/intel.c
> +++ b/arch/x86/kernel/cpu/intel.c
> @@ -1148,6 +1148,7 @@ static const struct x86_cpu_id split_lock_cpu_ids[] __initconst = {
>  	X86_MATCH_INTEL_FAM6_MODEL(ATOM_TREMONT_L,	1),
>  	X86_MATCH_INTEL_FAM6_MODEL(TIGERLAKE_L,		1),
>  	X86_MATCH_INTEL_FAM6_MODEL(TIGERLAKE,		1),
> +	X86_MATCH_INTEL_FAM6_MODEL(SAPPHIRERAPIDS_X,	1),
>  	{}
>  };

Any comment on this patch?

Thanks.

-Fenghua

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] x86/split_lock: Enumerate split lock feature on Sapphire Rapids
  2020-07-16 19:37 ` Fenghua Yu
@ 2020-07-16 19:50   ` Peter Zijlstra
  2020-07-16 19:53     ` Luck, Tony
  2020-07-16 20:13     ` Fenghua Yu
  0 siblings, 2 replies; 5+ messages in thread
From: Peter Zijlstra @ 2020-07-16 19:50 UTC (permalink / raw)
  To: Fenghua Yu
  Cc: Thomas Gleixner, Borislav Petkov, Ingo Molnar, Tony Luck,
	Ashok Raj, Ravi V Shankar, x86, linux-kernel

On Thu, Jul 16, 2020 at 12:37:00PM -0700, Fenghua Yu wrote:
> Hi, Thomas, Boris, Ingo,
> 
> On Fri, Jun 26, 2020 at 02:55:34PM -0700, Fenghua Yu wrote:
> > Add Sapphire Rapids processor to CPU list to enumerate split lock
> > feature.
> > 
> > Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> > Reviewed-by: Tony Luck <tony.luck@intel.com>
> > ---
> >  arch/x86/kernel/cpu/intel.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
> > index c25a67a34bd3..dca069ad6671 100644
> > --- a/arch/x86/kernel/cpu/intel.c
> > +++ b/arch/x86/kernel/cpu/intel.c
> > @@ -1148,6 +1148,7 @@ static const struct x86_cpu_id split_lock_cpu_ids[] __initconst = {
> >  	X86_MATCH_INTEL_FAM6_MODEL(ATOM_TREMONT_L,	1),
> >  	X86_MATCH_INTEL_FAM6_MODEL(TIGERLAKE_L,		1),
> >  	X86_MATCH_INTEL_FAM6_MODEL(TIGERLAKE,		1),
> > +	X86_MATCH_INTEL_FAM6_MODEL(SAPPHIRERAPIDS_X,	1),
> >  	{}
> >  };
> 
> Any comment on this patch?

The only comment I have is that us needing it is ludicrous :/ What's the
bloody point of having it 'enumerated' if you then still have to use FMS
lists.

There's nowhere near enough cursing in the comment that goes with that
list.

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] x86/split_lock: Enumerate split lock feature on Sapphire Rapids
  2020-07-16 19:50   ` Peter Zijlstra
@ 2020-07-16 19:53     ` Luck, Tony
  2020-07-16 20:13     ` Fenghua Yu
  1 sibling, 0 replies; 5+ messages in thread
From: Luck, Tony @ 2020-07-16 19:53 UTC (permalink / raw)
  To: Peter Zijlstra
  Cc: Fenghua Yu, Thomas Gleixner, Borislav Petkov, Ingo Molnar,
	Ashok Raj, Ravi V Shankar, x86, linux-kernel

On Thu, Jul 16, 2020 at 09:50:10PM +0200, Peter Zijlstra wrote:
> On Thu, Jul 16, 2020 at 12:37:00PM -0700, Fenghua Yu wrote:
> > Hi, Thomas, Boris, Ingo,
> > 
> > On Fri, Jun 26, 2020 at 02:55:34PM -0700, Fenghua Yu wrote:
> > > Add Sapphire Rapids processor to CPU list to enumerate split lock
> > > feature.
> > > 
> > > Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
> > > Reviewed-by: Tony Luck <tony.luck@intel.com>
> > > ---
> > >  arch/x86/kernel/cpu/intel.c | 1 +
> > >  1 file changed, 1 insertion(+)
> > > 
> > > diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
> > > index c25a67a34bd3..dca069ad6671 100644
> > > --- a/arch/x86/kernel/cpu/intel.c
> > > +++ b/arch/x86/kernel/cpu/intel.c
> > > @@ -1148,6 +1148,7 @@ static const struct x86_cpu_id split_lock_cpu_ids[] __initconst = {
> > >  	X86_MATCH_INTEL_FAM6_MODEL(ATOM_TREMONT_L,	1),
> > >  	X86_MATCH_INTEL_FAM6_MODEL(TIGERLAKE_L,		1),
> > >  	X86_MATCH_INTEL_FAM6_MODEL(TIGERLAKE,		1),
> > > +	X86_MATCH_INTEL_FAM6_MODEL(SAPPHIRERAPIDS_X,	1),
> > >  	{}
> > >  };
> > 
> > Any comment on this patch?
> 
> The only comment I have is that us needing it is ludicrous :/ What's the
> bloody point of having it 'enumerated' if you then still have to use FMS
> lists.
> 
> There's nowhere near enough cursing in the comment that goes with that
> list.

Code of conduct suggests that we avoid such language :-)

-Tony

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] x86/split_lock: Enumerate split lock feature on Sapphire Rapids
  2020-07-16 19:50   ` Peter Zijlstra
  2020-07-16 19:53     ` Luck, Tony
@ 2020-07-16 20:13     ` Fenghua Yu
  1 sibling, 0 replies; 5+ messages in thread
From: Fenghua Yu @ 2020-07-16 20:13 UTC (permalink / raw)
  To: Peter Zijlstra
  Cc: Thomas Gleixner, Borislav Petkov, Ingo Molnar, Tony Luck,
	Ashok Raj, Ravi V Shankar, x86, linux-kernel

Hi, Peter,

On Thu, Jul 16, 2020 at 09:50:10PM +0200, Peter Zijlstra wrote:
> On Thu, Jul 16, 2020 at 12:37:00PM -0700, Fenghua Yu wrote:
> > Hi, Thomas, Boris, Ingo,
> > 
> > On Fri, Jun 26, 2020 at 02:55:34PM -0700, Fenghua Yu wrote:
> The only comment I have is that us needing it is ludicrous :/ What's the
> bloody point of having it 'enumerated' if you then still have to use FMS
> lists.
> 
> There's nowhere near enough cursing in the comment that goes with that
> list.

Tony answered Thomas' similar question at
https://lore.kernel.org/lkml/20200416223335.GA23759@agluck-desk2.amr.corp.intel.com/

Is that sufficient enough to answer your question?

Thanks.

-Fenghua

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-07-16 20:13 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-26 21:55 [PATCH] x86/split_lock: Enumerate split lock feature on Sapphire Rapids Fenghua Yu
2020-07-16 19:37 ` Fenghua Yu
2020-07-16 19:50   ` Peter Zijlstra
2020-07-16 19:53     ` Luck, Tony
2020-07-16 20:13     ` Fenghua Yu

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.