* [PATCH -next] block: make blk_timeout_init() static
@ 2020-07-17 10:00 Wei Yongjun
2020-07-17 13:14 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2020-07-17 10:00 UTC (permalink / raw)
To: Hulk Robot, Jens Axboe; +Cc: Wei Yongjun, linux-block
The sparse tool complains as follows:
block/blk-timeout.c:93:12: warning:
symbol 'blk_timeout_init' was not declared. Should it be static?
Function blk_timeout_init() is not used outside ofblk-timeout.c, so
marks it static.
Fixes: 9054650fac24 ("block: relax jiffies rounding for timeouts")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
block/blk-timeout.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/blk-timeout.c b/block/blk-timeout.c
index 8ab8a82825cd..4c1fc3417460 100644
--- a/block/blk-timeout.c
+++ b/block/blk-timeout.c
@@ -90,7 +90,7 @@ EXPORT_SYMBOL_GPL(blk_abort_request);
static unsigned long blk_timeout_mask __read_mostly;
-int __init blk_timeout_init(void)
+static int __init blk_timeout_init(void)
{
blk_timeout_mask = roundup_pow_of_two(HZ) - 1;
return 0;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] block: make blk_timeout_init() static
2020-07-17 10:00 [PATCH -next] block: make blk_timeout_init() static Wei Yongjun
@ 2020-07-17 13:14 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2020-07-17 13:14 UTC (permalink / raw)
To: Wei Yongjun, Hulk Robot; +Cc: linux-block
On 7/17/20 4:00 AM, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> block/blk-timeout.c:93:12: warning:
> symbol 'blk_timeout_init' was not declared. Should it be static?
>
> Function blk_timeout_init() is not used outside ofblk-timeout.c, so
> marks it static.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-17 13:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-17 10:00 [PATCH -next] block: make blk_timeout_init() static Wei Yongjun
2020-07-17 13:14 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.