All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Claudiu Manoil <claudiu.manoil@nxp.com>
Cc: "David S . Miller" <davem@davemloft.net>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 6/6] enetc: Add adaptive interrupt coalescing
Date: Fri, 17 Jul 2020 12:30:14 -0700	[thread overview]
Message-ID: <20200717123014.4a68dad4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <1595000224-6883-7-git-send-email-claudiu.manoil@nxp.com>

On Fri, 17 Jul 2020 18:37:04 +0300 Claudiu Manoil wrote:
> +	if (tx_ictt == ENETC_TXIC_TIMETHR)
> +		ic_mode |= ENETC_IC_TX_OPTIMAL;

Doesn't seem you ever read/check the ENETC_IC_TX_OPTIMAL flag?

  reply	other threads:[~2020-07-17 19:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-17 15:36 [PATCH net-next v2 0/6] Add adaptive interrupt coalescing Claudiu Manoil
2020-07-17 15:36 ` [PATCH net-next v2 1/6] enetc: Refine buffer descriptor ring sizes Claudiu Manoil
2020-07-17 15:37 ` [PATCH net-next v2 2/6] enetc: Factor out the traffic start/stop procedures Claudiu Manoil
2020-07-17 15:37 ` [PATCH net-next v2 3/6] enetc: Fix interrupt coalescing register naming Claudiu Manoil
2020-07-17 15:37 ` [PATCH net-next v2 4/6] enetc: Drop redundant ____cacheline_aligned_in_smp Claudiu Manoil
2020-07-17 15:37 ` [PATCH net-next v2 5/6] enetc: Add interrupt coalescing support Claudiu Manoil
2020-07-17 19:32   ` Jakub Kicinski
2020-07-18 17:20     ` Claudiu Manoil
2020-07-20 16:58       ` Jakub Kicinski
2020-07-21  8:00         ` Claudiu Manoil
2020-07-17 15:37 ` [PATCH net-next v2 6/6] enetc: Add adaptive interrupt coalescing Claudiu Manoil
2020-07-17 19:30   ` Jakub Kicinski [this message]
2020-07-18 17:20     ` Claudiu Manoil
2020-07-21  8:05       ` Claudiu Manoil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200717123014.4a68dad4@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=claudiu.manoil@nxp.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.