All of lore.kernel.org
 help / color / mirror / Atom feed
From: Claudiu Manoil <claudiu.manoil@nxp.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH net-next v2 5/6] enetc: Add interrupt coalescing support
Date: Tue, 21 Jul 2020 08:00:46 +0000	[thread overview]
Message-ID: <DB8PR04MB67644D35E9D45F757CB4F76396780@DB8PR04MB6764.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200720095846.18a1ea73@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>

>-----Original Message-----
>From: Jakub Kicinski <kuba@kernel.org>
>Sent: Monday, July 20, 2020 7:59 PM
[...]
>Subject: Re: [PATCH net-next v2 5/6] enetc: Add interrupt coalescing support
>
>On Sat, 18 Jul 2020 20:20:10 +0300 Claudiu Manoil wrote:
>> On 17.07.2020 22:32, Jakub Kicinski wrote:
>> > On Fri, 17 Jul 2020 18:37:03 +0300 Claudiu Manoil wrote:
>> >> +	if (ic->rx_max_coalesced_frames != ENETC_RXIC_PKTTHR)
>> >> +		netif_warn(priv, hw, ndev, "rx-frames fixed to %d\n",
>> >> +			   ENETC_RXIC_PKTTHR);
>> >> +
>> >> +	if (ic->tx_max_coalesced_frames != ENETC_TXIC_PKTTHR)
>> >> +		netif_warn(priv, hw, ndev, "tx-frames fixed to %d\n",
>> >> +			   ENETC_TXIC_PKTTHR);
>> >
>> > On second thought - why not return an error here? Since only one value
>> > is supported seems like the right way to communicate to the users that
>> > they can't change this.
>>
>> Do you mean to return -EOPNOTSUPP without any error message instead?
>
>Yes.
>
>> If so, I think it's less punishing not to return an error code and
>> invalidate the rest of the ethtool -C parameters that might have been
>> correct if the user forgets that rx/tx-frames cannot be changed.
>
>IMHO if configuring manually - user can correct the params on the CLI.
>If there's an orchestration system trying to configure those - it's
>better to return an error and alert the administrator than confuse
>the orchestration by allowing a write which is then not reflected
>on read.
>

Good point, ok.  Updated accordingly in v3.
Thanks.

  reply	other threads:[~2020-07-21  8:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-17 15:36 [PATCH net-next v2 0/6] Add adaptive interrupt coalescing Claudiu Manoil
2020-07-17 15:36 ` [PATCH net-next v2 1/6] enetc: Refine buffer descriptor ring sizes Claudiu Manoil
2020-07-17 15:37 ` [PATCH net-next v2 2/6] enetc: Factor out the traffic start/stop procedures Claudiu Manoil
2020-07-17 15:37 ` [PATCH net-next v2 3/6] enetc: Fix interrupt coalescing register naming Claudiu Manoil
2020-07-17 15:37 ` [PATCH net-next v2 4/6] enetc: Drop redundant ____cacheline_aligned_in_smp Claudiu Manoil
2020-07-17 15:37 ` [PATCH net-next v2 5/6] enetc: Add interrupt coalescing support Claudiu Manoil
2020-07-17 19:32   ` Jakub Kicinski
2020-07-18 17:20     ` Claudiu Manoil
2020-07-20 16:58       ` Jakub Kicinski
2020-07-21  8:00         ` Claudiu Manoil [this message]
2020-07-17 15:37 ` [PATCH net-next v2 6/6] enetc: Add adaptive interrupt coalescing Claudiu Manoil
2020-07-17 19:30   ` Jakub Kicinski
2020-07-18 17:20     ` Claudiu Manoil
2020-07-21  8:05       ` Claudiu Manoil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DB8PR04MB67644D35E9D45F757CB4F76396780@DB8PR04MB6764.eurprd04.prod.outlook.com \
    --to=claudiu.manoil@nxp.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.