* [PATCH net-next] ipvs: missing unlock in ip_vs_expire_nodest_conn_flush()
@ 2020-07-17 14:10 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2020-07-17 14:10 UTC (permalink / raw)
To: Wensong Zhang
Cc: Simon Horman, Julian Anastasov, Pablo Neira Ayuso,
Jozsef Kadlecsik, Florian Westphal, Jakub Kicinski,
Andrew Sy Kim, lvs-devel, netfilter-devel, coreteam,
kernel-janitors
We can't return without calling rcu_read_unlock().
Fixes: 04231e52d355 ("ipvs: queue delayed work to expire no destination connections if expire_nodest_conn=1")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
net/netfilter/ipvs/ip_vs_conn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/ipvs/ip_vs_conn.c b/net/netfilter/ipvs/ip_vs_conn.c
index a5e9b2d55e57..a90b8eac16ac 100644
--- a/net/netfilter/ipvs/ip_vs_conn.c
+++ b/net/netfilter/ipvs/ip_vs_conn.c
@@ -1422,7 +1422,7 @@ void ip_vs_expire_nodest_conn_flush(struct netns_ipvs *ipvs)
/* netns clean up started, abort delayed work */
if (!ipvs->enable)
- return;
+ break;
}
rcu_read_unlock();
}
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH net-next] ipvs: missing unlock in ip_vs_expire_nodest_conn_flush()
@ 2020-07-17 14:10 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2020-07-17 14:10 UTC (permalink / raw)
To: Wensong Zhang
Cc: Simon Horman, Julian Anastasov, Pablo Neira Ayuso,
Jozsef Kadlecsik, Florian Westphal, Jakub Kicinski,
Andrew Sy Kim, lvs-devel, netfilter-devel, coreteam,
kernel-janitors
We can't return without calling rcu_read_unlock().
Fixes: 04231e52d355 ("ipvs: queue delayed work to expire no destination connections if expire_nodest_conn=1")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
net/netfilter/ipvs/ip_vs_conn.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/netfilter/ipvs/ip_vs_conn.c b/net/netfilter/ipvs/ip_vs_conn.c
index a5e9b2d55e57..a90b8eac16ac 100644
--- a/net/netfilter/ipvs/ip_vs_conn.c
+++ b/net/netfilter/ipvs/ip_vs_conn.c
@@ -1422,7 +1422,7 @@ void ip_vs_expire_nodest_conn_flush(struct netns_ipvs *ipvs)
/* netns clean up started, abort delayed work */
if (!ipvs->enable)
- return;
+ break;
}
rcu_read_unlock();
}
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-17 14:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-17 14:10 [PATCH net-next] ipvs: missing unlock in ip_vs_expire_nodest_conn_flush() Dan Carpenter
2020-07-17 14:10 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.