All of lore.kernel.org
 help / color / mirror / Atom feed
From: Changbin Du <changbin.du@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org, Changbin Du <changbin.du@gmail.com>
Subject: [PATCH v7 09/18] perf ftrace: add support for trace option sleep-time
Date: Sat, 18 Jul 2020 14:48:17 +0800	[thread overview]
Message-ID: <20200718064826.9865-10-changbin.du@gmail.com> (raw)
In-Reply-To: <20200718064826.9865-1-changbin.du@gmail.com>

This adds an option '--graph-opts nosleep-time' which allow us
only to measure on-CPU time. This option is function_graph tracer
only.

Signed-off-by: Changbin Du <changbin.du@gmail.com>

---
v3: switch to uniform option --graph-opts.
v2: option name '--nosleep-time' -> '--graph-nosleep-time'.
---
 tools/perf/Documentation/perf-ftrace.txt |  4 +++
 tools/perf/builtin-ftrace.c              | 41 ++++++++++++++++++++++++
 2 files changed, 45 insertions(+)

diff --git a/tools/perf/Documentation/perf-ftrace.txt b/tools/perf/Documentation/perf-ftrace.txt
index 5a5069306141..2968a34239a4 100644
--- a/tools/perf/Documentation/perf-ftrace.txt
+++ b/tools/perf/Documentation/perf-ftrace.txt
@@ -98,6 +98,10 @@ OPTIONS
 --graph-depth=::
 	Set max depth for function graph tracer to follow
 
+--graph-opts::
+	List of options allowed to set:
+	  nosleep-time - Measure on-CPU time only for function_graph tracer.
+
 SEE ALSO
 --------
 linkperf:perf-record[1], linkperf:perf-trace[1]
diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c
index e7c8697294f0..835f810985f0 100644
--- a/tools/perf/builtin-ftrace.c
+++ b/tools/perf/builtin-ftrace.c
@@ -42,6 +42,7 @@ struct perf_ftrace {
 	unsigned long		percpu_buffer_size;
 	bool			inherit;
 	int			func_stack_trace;
+	int			graph_nosleep_time;
 };
 
 struct filter_entry {
@@ -203,6 +204,7 @@ static void reset_tracing_options(struct perf_ftrace *ftrace __maybe_unused)
 {
 	write_tracing_option_file("function-fork", "0");
 	write_tracing_option_file("func_stack_trace", "0");
+	write_tracing_option_file("sleep-time", "1");
 }
 
 static int reset_tracing_files(struct perf_ftrace *ftrace __maybe_unused)
@@ -384,6 +386,17 @@ static int set_tracing_trace_inherit(struct perf_ftrace *ftrace)
 	return 0;
 }
 
+static int set_tracing_sleep_time(struct perf_ftrace *ftrace)
+{
+	if (!ftrace->graph_nosleep_time)
+		return 0;
+
+	if (write_tracing_option_file("sleep-time", "0") < 0)
+		return -1;
+
+	return 0;
+}
+
 static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv)
 {
 	char *trace_file;
@@ -463,6 +476,11 @@ static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv)
 		goto out_reset;
 	}
 
+	if (set_tracing_sleep_time(ftrace) < 0) {
+		pr_err("failed to set tracing option sleep-time\n");
+		goto out_reset;
+	}
+
 	if (write_tracing_file("current_tracer", ftrace->tracer) < 0) {
 		pr_err("failed to set current_tracer to %s\n", ftrace->tracer);
 		goto out_reset;
@@ -636,6 +654,26 @@ static int parse_func_tracer_opts(const struct option *opt,
 	return 0;
 }
 
+static int parse_graph_tracer_opts(const struct option *opt,
+				  const char *str, int unset)
+{
+	int ret;
+	struct perf_ftrace *ftrace = (struct perf_ftrace *) opt->value;
+	struct sublevel_option graph_tracer_opts[] = {
+		{ .name = "nosleep-time",	.value_ptr = &ftrace->graph_nosleep_time },
+		{ .name = NULL, }
+	};
+
+	if (unset)
+		return 0;
+
+	ret = perf_parse_sublevel_options(str, graph_tracer_opts);
+	if (ret)
+		return ret;
+
+	return 0;
+}
+
 int cmd_ftrace(int argc, const char **argv)
 {
 	int ret;
@@ -676,6 +714,9 @@ int cmd_ftrace(int argc, const char **argv)
 		     "Set nograph filter on given functions", parse_filter_func),
 	OPT_INTEGER('D', "graph-depth", &ftrace.graph_depth,
 		    "Max depth for function graph tracer"),
+	OPT_CALLBACK(0, "graph-opts", &ftrace, "options",
+		     "graph tracer options, available options: nosleep-time",
+		     parse_graph_tracer_opts),
 	OPT_CALLBACK('m', "buffer-size", &ftrace.percpu_buffer_size, "size",
 		     "size of per cpu buffer", parse_buffer_size),
 	OPT_BOOLEAN(0, "inherit", &ftrace.inherit,
-- 
2.25.1


  parent reply	other threads:[~2020-07-18  6:49 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-18  6:48 [PATCH v7 00/18] perf: ftrace enhancement Changbin Du
2020-07-18  6:48 ` [PATCH v7 01/18] perf ftrace: select function/function_graph tracer automatically Changbin Du
2020-08-04 12:51   ` Arnaldo Carvalho de Melo
2020-08-06  0:14     ` Changbin Du
2020-08-06  1:05       ` Arnaldo Carvalho de Melo
2020-08-08  2:22         ` Changbin Du
2020-07-18  6:48 ` [PATCH v7 02/18] perf ftrace: add option '-F/--funcs' to list available functions Changbin Du
2020-07-18  6:48 ` [PATCH v7 03/18] perf ftrace: factor out function write_tracing_file_int() Changbin Du
2020-07-18  6:48 ` [PATCH v7 04/18] perf ftrace: add option '-m/--buffer-size' to set per-cpu buffer size Changbin Du
2020-07-18  6:48 ` [PATCH v7 05/18] perf ftrace: show trace column header Changbin Du
2020-07-18  6:48 ` [PATCH v7 06/18] perf ftrace: add option '--inherit' to trace children processes Changbin Du
2020-07-18  6:48 ` [PATCH v7 07/18] perf: util: add general function to parse sublevel options Changbin Du
2020-07-18  6:48 ` [PATCH v7 08/18] perf ftrace: add support for tracing option 'func_stack_trace' Changbin Du
2020-07-18  6:48 ` Changbin Du [this message]
2020-07-18  6:48 ` [PATCH v7 10/18] perf ftrace: add support for trace option funcgraph-irqs Changbin Du
2020-07-18  6:48 ` [PATCH v7 11/18] perf ftrace: add support for tracing option 'irq-info' Changbin Du
2020-07-18  6:48 ` [PATCH v7 12/18] perf ftrace: add option 'verbose' to show more info for graph tracer Changbin Du
2020-07-18  6:48 ` [PATCH v7 13/18] perf ftrace: add support for trace option tracing_thresh Changbin Du
2020-07-18  6:48 ` [PATCH v7 14/18] perf: ftrace: allow set graph depth by '--graph-opts' Changbin Du
2020-07-18  6:48 ` [PATCH v7 15/18] perf ftrace: add option -D/--delay to delay tracing Changbin Du
2020-07-18  6:48 ` [PATCH v7 16/18] perf ftrace: add option --tid to filter by thread id Changbin Du
2020-07-18  6:48 ` [PATCH v7 17/18] perf: ftrace: Add set_tracing_options() to set all trace options Changbin Du
2020-07-18  6:48 ` [PATCH v7 18/18] perf ftrace: add change log Changbin Du
2020-07-21 13:39 ` [PATCH v7 00/18] perf: ftrace enhancement Namhyung Kim
2020-07-31 17:35 ` Changbin Du
2020-07-31 22:42   ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200718064826.9865-10-changbin.du@gmail.com \
    --to=changbin.du@gmail.com \
    --cc=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.