All of lore.kernel.org
 help / color / mirror / Atom feed
From: Changbin Du <changbin.du@gmail.com>
To: Jiri Olsa <jolsa@redhat.com>, Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
	Ingo Molnar <mingo@redhat.com>,
	Namhyung Kim <namhyung@kernel.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org, Changbin Du <changbin.du@gmail.com>
Subject: [PATCH v7 13/18] perf ftrace: add support for trace option tracing_thresh
Date: Sat, 18 Jul 2020 14:48:21 +0800	[thread overview]
Message-ID: <20200718064826.9865-14-changbin.du@gmail.com> (raw)
In-Reply-To: <20200718064826.9865-1-changbin.du@gmail.com>

This adds an option '--graph-opts thresh' to setup trace duration
threshold for funcgraph tracer.

$ sudo ./perf ftrace -G '*' --graph-opts thresh=100
 3) ! 184.060 us  |    } /* schedule */
 3) ! 185.600 us  |  } /* exit_to_usermode_loop */
 2) ! 225.989 us  |    } /* schedule_idle */
 2) # 4140.051 us |  } /* do_idle */

Signed-off-by: Changbin Du <changbin.du@gmail.com>
---
 tools/perf/Documentation/perf-ftrace.txt |  1 +
 tools/perf/builtin-ftrace.c              | 26 +++++++++++++++++++++++-
 2 files changed, 26 insertions(+), 1 deletion(-)

diff --git a/tools/perf/Documentation/perf-ftrace.txt b/tools/perf/Documentation/perf-ftrace.txt
index 319ec6375228..96e5e8d7f65c 100644
--- a/tools/perf/Documentation/perf-ftrace.txt
+++ b/tools/perf/Documentation/perf-ftrace.txt
@@ -104,6 +104,7 @@ OPTIONS
 	  nosleep-time - Measure on-CPU time only for function_graph tracer.
 	  noirqs       - Ignore functions that happen inside interrupt.
 	  verbose      - Show process names, PIDs, timestamps, etc.
+	  thresh=<n>   - Setup trace duration threshold in microseconds.
 
 SEE ALSO
 --------
diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c
index 0d893d97691d..5d948239bd70 100644
--- a/tools/perf/builtin-ftrace.c
+++ b/tools/perf/builtin-ftrace.c
@@ -46,6 +46,7 @@ struct perf_ftrace {
 	int			graph_nosleep_time;
 	int			graph_noirqs;
 	int			graph_verbose;
+	int			graph_thresh;
 };
 
 struct filter_entry {
@@ -232,6 +233,9 @@ static int reset_tracing_files(struct perf_ftrace *ftrace __maybe_unused)
 	if (write_tracing_file("max_graph_depth", "0") < 0)
 		return -1;
 
+	if (write_tracing_file("tracing_thresh", "0") < 0)
+		return -1;
+
 	reset_tracing_filters();
 	reset_tracing_options(ftrace);
 	return 0;
@@ -444,6 +448,20 @@ static int set_tracing_funcgraph_verbose(struct perf_ftrace *ftrace)
 	return 0;
 }
 
+static int set_tracing_thresh(struct perf_ftrace *ftrace)
+{
+	int ret;
+
+	if (ftrace->graph_thresh == 0)
+		return 0;
+
+	ret = write_tracing_file_int("tracing_thresh", ftrace->graph_thresh);
+	if (ret < 0)
+		return ret;
+
+	return 0;
+}
+
 static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv)
 {
 	char *trace_file;
@@ -543,6 +561,11 @@ static int __cmd_ftrace(struct perf_ftrace *ftrace, int argc, const char **argv)
 		goto out_reset;
 	}
 
+	if (set_tracing_thresh(ftrace) < 0) {
+		pr_err("failed to set tracing thresh\n");
+		goto out_reset;
+	}
+
 	if (write_tracing_file("current_tracer", ftrace->tracer) < 0) {
 		pr_err("failed to set current_tracer to %s\n", ftrace->tracer);
 		goto out_reset;
@@ -726,6 +749,7 @@ static int parse_graph_tracer_opts(const struct option *opt,
 		{ .name = "nosleep-time",	.value_ptr = &ftrace->graph_nosleep_time },
 		{ .name = "noirqs",		.value_ptr = &ftrace->graph_noirqs },
 		{ .name = "verbose",		.value_ptr = &ftrace->graph_verbose },
+		{ .name = "thresh",		.value_ptr = &ftrace->graph_thresh },
 		{ .name = NULL, }
 	};
 
@@ -780,7 +804,7 @@ int cmd_ftrace(int argc, const char **argv)
 	OPT_INTEGER('D', "graph-depth", &ftrace.graph_depth,
 		    "Max depth for function graph tracer"),
 	OPT_CALLBACK(0, "graph-opts", &ftrace, "options",
-		     "graph tracer options, available options: nosleep-time,noirqs,verbose",
+		     "graph tracer options, available options: nosleep-time,noirqs,verbose,thresh=<n>",
 		     parse_graph_tracer_opts),
 	OPT_CALLBACK('m', "buffer-size", &ftrace.percpu_buffer_size, "size",
 		     "size of per cpu buffer", parse_buffer_size),
-- 
2.25.1


  parent reply	other threads:[~2020-07-18  6:50 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-18  6:48 [PATCH v7 00/18] perf: ftrace enhancement Changbin Du
2020-07-18  6:48 ` [PATCH v7 01/18] perf ftrace: select function/function_graph tracer automatically Changbin Du
2020-08-04 12:51   ` Arnaldo Carvalho de Melo
2020-08-06  0:14     ` Changbin Du
2020-08-06  1:05       ` Arnaldo Carvalho de Melo
2020-08-08  2:22         ` Changbin Du
2020-07-18  6:48 ` [PATCH v7 02/18] perf ftrace: add option '-F/--funcs' to list available functions Changbin Du
2020-07-18  6:48 ` [PATCH v7 03/18] perf ftrace: factor out function write_tracing_file_int() Changbin Du
2020-07-18  6:48 ` [PATCH v7 04/18] perf ftrace: add option '-m/--buffer-size' to set per-cpu buffer size Changbin Du
2020-07-18  6:48 ` [PATCH v7 05/18] perf ftrace: show trace column header Changbin Du
2020-07-18  6:48 ` [PATCH v7 06/18] perf ftrace: add option '--inherit' to trace children processes Changbin Du
2020-07-18  6:48 ` [PATCH v7 07/18] perf: util: add general function to parse sublevel options Changbin Du
2020-07-18  6:48 ` [PATCH v7 08/18] perf ftrace: add support for tracing option 'func_stack_trace' Changbin Du
2020-07-18  6:48 ` [PATCH v7 09/18] perf ftrace: add support for trace option sleep-time Changbin Du
2020-07-18  6:48 ` [PATCH v7 10/18] perf ftrace: add support for trace option funcgraph-irqs Changbin Du
2020-07-18  6:48 ` [PATCH v7 11/18] perf ftrace: add support for tracing option 'irq-info' Changbin Du
2020-07-18  6:48 ` [PATCH v7 12/18] perf ftrace: add option 'verbose' to show more info for graph tracer Changbin Du
2020-07-18  6:48 ` Changbin Du [this message]
2020-07-18  6:48 ` [PATCH v7 14/18] perf: ftrace: allow set graph depth by '--graph-opts' Changbin Du
2020-07-18  6:48 ` [PATCH v7 15/18] perf ftrace: add option -D/--delay to delay tracing Changbin Du
2020-07-18  6:48 ` [PATCH v7 16/18] perf ftrace: add option --tid to filter by thread id Changbin Du
2020-07-18  6:48 ` [PATCH v7 17/18] perf: ftrace: Add set_tracing_options() to set all trace options Changbin Du
2020-07-18  6:48 ` [PATCH v7 18/18] perf ftrace: add change log Changbin Du
2020-07-21 13:39 ` [PATCH v7 00/18] perf: ftrace enhancement Namhyung Kim
2020-07-31 17:35 ` Changbin Du
2020-07-31 22:42   ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200718064826.9865-14-changbin.du@gmail.com \
    --to=changbin.du@gmail.com \
    --cc=acme@kernel.org \
    --cc=jolsa@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.