From: Jonathan Cameron <jic23@kernel.org> To: Lee Jones <lee.jones@linaro.org> Cc: knaack.h@gmx.de, lars@metafoo.de, pmeerw@pmeerw.net, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, Tiberiu Breana <tiberiu.a.breana@intel.com> Subject: Re: [PATCH 02/30] iio: accel: bma220_spi: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Date: Sat, 18 Jul 2020 15:26:32 +0100 [thread overview] Message-ID: <20200718152632.3bf5686a@archlinux> (raw) In-Reply-To: <20200716135928.1456727-3-lee.jones@linaro.org> On Thu, 16 Jul 2020 14:59:00 +0100 Lee Jones <lee.jones@linaro.org> wrote: > Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, > struct 'bma220_acpi_id' becomes defined but unused. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/accel/bma220_spi.c:312:36: warning: ‘bma220_acpi_id’ defined but not used [-Wunused-const-variable=] > 312 | static const struct acpi_device_id bma220_acpi_id[] = { > | ^~~~~~~~~~~~~~ > > Cc: Tiberiu Breana <tiberiu.a.breana@intel.com> > Signed-off-by: Lee Jones <lee.jones@linaro.org> Applied to the togreg branch of iio.git and pushed out as testing for the autobulders to play with it. Thanks, Jonathan > --- > drivers/iio/accel/bma220_spi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iio/accel/bma220_spi.c b/drivers/iio/accel/bma220_spi.c > index cae905039cb62..439618d815594 100644 > --- a/drivers/iio/accel/bma220_spi.c > +++ b/drivers/iio/accel/bma220_spi.c > @@ -309,12 +309,14 @@ static const struct spi_device_id bma220_spi_id[] = { > {} > }; > > +#ifdef CONFIG_ACPI > static const struct acpi_device_id bma220_acpi_id[] = { > {"BMA0220", 0}, > {} > }; > > MODULE_DEVICE_TABLE(spi, bma220_spi_id); > +#endif > > static struct spi_driver bma220_driver = { > .driver = {
WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org> To: Lee Jones <lee.jones@linaro.org> Cc: lars@metafoo.de, linux-iio@vger.kernel.org, Tiberiu Breana <tiberiu.a.breana@intel.com>, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, knaack.h@gmx.de, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 02/30] iio: accel: bma220_spi: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Date: Sat, 18 Jul 2020 15:26:32 +0100 [thread overview] Message-ID: <20200718152632.3bf5686a@archlinux> (raw) In-Reply-To: <20200716135928.1456727-3-lee.jones@linaro.org> On Thu, 16 Jul 2020 14:59:00 +0100 Lee Jones <lee.jones@linaro.org> wrote: > Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, > struct 'bma220_acpi_id' becomes defined but unused. > > Fixes the following W=1 kernel build warning(s): > > drivers/iio/accel/bma220_spi.c:312:36: warning: ‘bma220_acpi_id’ defined but not used [-Wunused-const-variable=] > 312 | static const struct acpi_device_id bma220_acpi_id[] = { > | ^~~~~~~~~~~~~~ > > Cc: Tiberiu Breana <tiberiu.a.breana@intel.com> > Signed-off-by: Lee Jones <lee.jones@linaro.org> Applied to the togreg branch of iio.git and pushed out as testing for the autobulders to play with it. Thanks, Jonathan > --- > drivers/iio/accel/bma220_spi.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iio/accel/bma220_spi.c b/drivers/iio/accel/bma220_spi.c > index cae905039cb62..439618d815594 100644 > --- a/drivers/iio/accel/bma220_spi.c > +++ b/drivers/iio/accel/bma220_spi.c > @@ -309,12 +309,14 @@ static const struct spi_device_id bma220_spi_id[] = { > {} > }; > > +#ifdef CONFIG_ACPI > static const struct acpi_device_id bma220_acpi_id[] = { > {"BMA0220", 0}, > {} > }; > > MODULE_DEVICE_TABLE(spi, bma220_spi_id); > +#endif > > static struct spi_driver bma220_driver = { > .driver = { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-18 14:26 UTC|newest] Thread overview: 142+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-16 13:58 [PATCH 00/30] First batch of W=1 fixes for IIO Lee Jones 2020-07-16 13:58 ` Lee Jones 2020-07-16 13:58 ` [PATCH 01/30] iio: adc: ad_sigma_delta: Remove unused variable 'ret' Lee Jones 2020-07-16 13:58 ` Lee Jones 2020-07-18 14:24 ` Jonathan Cameron 2020-07-18 14:24 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 02/30] iio: accel: bma220_spi: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 14:26 ` Jonathan Cameron [this message] 2020-07-18 14:26 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 03/30] iio: common: ms_sensors: ms_sensors_i2c: Fix misspelling of parameter 'client' Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 14:27 ` Jonathan Cameron 2020-07-18 14:27 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 04/30] iio: adc: ad7298: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 14:30 ` Jonathan Cameron 2020-07-18 14:30 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 05/30] iio: chemical: sgp30: Add description for sgp_read_cmd()'s 'duration_us' Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 14:33 ` Jonathan Cameron 2020-07-18 14:33 ` Jonathan Cameron 2020-09-17 18:33 ` Jonathan Cameron 2020-09-17 18:33 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 06/30] iio: adc: ad7923: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 14:35 ` Jonathan Cameron 2020-07-18 14:35 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 07/30] iio: dac: ad5360: Fix kerneldoc attribute formatting for 'lock' Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 14:36 ` Jonathan Cameron 2020-07-18 14:36 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 08/30] iio: dac: ad5380: " Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 14:36 ` Jonathan Cameron 2020-07-18 14:36 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 09/30] iio: dummy: iio_simple_dummy: Demote unworthy kerneldocs and correct misspelling Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 14:39 ` Jonathan Cameron 2020-07-18 14:39 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 10/30] iio: dummy: iio_simple_dummy: Add newline after function-end Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 14:40 ` Jonathan Cameron 2020-07-18 14:40 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 11/30] iio: dac: ad5421: Fix kerneldoc attribute formatting for 'lock' Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 14:42 ` Jonathan Cameron 2020-07-18 14:42 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 12/30] iio: gyro: adis16080: Fix formatting issue and compiler attribute ordering Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 14:54 ` Jonathan Cameron 2020-07-18 14:54 ` Jonathan Cameron 2020-09-17 18:33 ` Jonathan Cameron 2020-09-17 18:33 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 13/30] iio: dummy: iio_simple_dummy_events: Demote file header and supply descriptions for val2 params Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 14:55 ` Jonathan Cameron 2020-07-18 14:55 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 14/30] iio: dac: ad5064: Value returned by ad5064_vref_name may not be 'const * const' Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 14:57 ` Jonathan Cameron 2020-07-18 14:57 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 15/30] iio: dummy: iio_dummy_evgen: Demote file header and supply description for 'irq_sim_domain' Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 9:24 ` Bartosz Golaszewski 2020-07-18 9:24 ` Bartosz Golaszewski 2020-07-18 15:00 ` Jonathan Cameron 2020-07-18 15:00 ` Jonathan Cameron 2020-09-17 18:32 ` Jonathan Cameron 2020-09-17 18:32 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 16/30] iio: adc: ad7887: Demote seemingly unintentional kerneldoc header Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 15:01 ` Jonathan Cameron 2020-07-18 15:01 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 17/30] iio: adc: ad7949: Fix misspelling issue and compiler attribute ordering Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 15:03 ` Jonathan Cameron 2020-07-18 15:03 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 18/30] iio: dummy: iio_simple_dummy_buffer: Demote file header and correct misspelling Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 15:02 ` Jonathan Cameron 2020-07-18 15:02 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 19/30] iio: dac: ad5064: Fix a few kerneldoc misdemeanours Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 15:04 ` Jonathan Cameron 2020-07-18 15:04 ` Jonathan Cameron 2020-09-17 18:31 ` Jonathan Cameron 2020-09-17 18:31 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 20/30] iio: dac: ad5446: Complete 'struct ad5446_state' doc and demote unworthy kerneldocs Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 15:05 ` Jonathan Cameron 2020-07-18 15:05 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 21/30] iio: dac: ad5449: Fix kerneldoc attribute formatting for 'lock' Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 15:06 ` Jonathan Cameron 2020-07-18 15:06 ` Jonathan Cameron 2020-07-18 15:07 ` Jonathan Cameron 2020-07-18 15:07 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 22/30] iio: dac: ad5755: " Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 15:08 ` Jonathan Cameron 2020-07-18 15:08 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 23/30] iio: dac: ad5758: Move and fix-up kerneldoc header and demote unworthy kerneldoc Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 15:09 ` Jonathan Cameron 2020-07-18 15:09 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 24/30] iio: dac: ad5761: Fix kerneldoc attribute formatting for 'lock' Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 15:10 ` Jonathan Cameron 2020-07-18 15:10 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 25/30] iio: dac: ad5764: Fix misdocumenting and formatting error Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 15:10 ` Jonathan Cameron 2020-07-18 15:10 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 26/30] iio: dac: ad5791: Complete 'struct ad5791_chip_info' documentation Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 15:12 ` Jonathan Cameron 2020-07-18 15:12 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 27/30] iio: light: cm32181: Fix formatting and docrot issues in cm32181_acpi_get_cpm() Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 15:14 ` Jonathan Cameron 2020-07-18 15:14 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 28/30] iio: magnetometer: mmc35240: Fix function header formatting Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 15:16 ` Jonathan Cameron 2020-07-18 15:16 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 29/30] iio: imu: kmx61: Fix formatting in kerneldoc function headers Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 15:17 ` Jonathan Cameron 2020-07-18 15:17 ` Jonathan Cameron 2020-07-16 13:59 ` [PATCH 30/30] iio: dac: ad7303: Complete 'struct ad7303_state' doc and reorder compiler attribute Lee Jones 2020-07-16 13:59 ` Lee Jones 2020-07-18 15:18 ` Jonathan Cameron 2020-07-18 15:18 ` Jonathan Cameron 2020-09-17 18:29 ` Jonathan Cameron 2020-09-17 18:29 ` Jonathan Cameron 2020-09-17 18:30 ` Jonathan Cameron 2020-09-17 18:30 ` Jonathan Cameron 2020-07-18 14:42 ` [PATCH 00/30] First batch of W=1 fixes for IIO Jonathan Cameron 2020-07-18 14:42 ` Jonathan Cameron 2020-07-20 7:51 ` Lee Jones 2020-07-20 7:51 ` Lee Jones
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200718152632.3bf5686a@archlinux \ --to=jic23@kernel.org \ --cc=knaack.h@gmx.de \ --cc=lars@metafoo.de \ --cc=lee.jones@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-iio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pmeerw@pmeerw.net \ --cc=tiberiu.a.breana@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.