All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Crt Mori <cmo@melexis.com>
Cc: Lee Jones <lee.jones@linaro.org>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Peter Meerwald <pmeerw@pmeerw.net>,
	linux-arm-kernel@lists.infradead.org,
	Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
	Linux Iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 09/30] iio: temperature: mlx90632: Function parameter descriptions must match exactly
Date: Sat, 18 Jul 2020 16:42:27 +0100	[thread overview]
Message-ID: <20200718164227.0e31c078@archlinux> (raw)
In-Reply-To: <CAKv63uvMb1R2OyBwFuCTU+E5YQfHwBB+bqRP+jXO9yn4e2Wu6w@mail.gmail.com>

On Fri, 17 Jul 2020 21:48:06 +0200
Crt Mori <cmo@melexis.com> wrote:

> Acked-by: Crt Mori <cmo@melexis.com>
> 
> On Fri, 17 Jul 2020 at 18:56, Lee Jones <lee.jones@linaro.org> wrote:
> >
> > '*'s are not welcome in kerneldoc parameter names.
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> >  drivers/iio/temperature/mlx90632.c:175: warning: Function parameter or member 'data' not described in 'mlx90632_perform_measurement'
> >
> > Cc: Crt Mori <cmo@melexis.com>
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
I got lazy on bothering about the addition of optional brackets.

Applied,

Thanks,

Jonathan

> > ---
> >  drivers/iio/temperature/mlx90632.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/temperature/mlx90632.c b/drivers/iio/temperature/mlx90632.c
> > index eaca6ba068646..b9a8089be3f63 100644
> > --- a/drivers/iio/temperature/mlx90632.c
> > +++ b/drivers/iio/temperature/mlx90632.c
> > @@ -164,8 +164,8 @@ static s32 mlx90632_pwr_continuous(struct regmap *regmap)
> >  }
> >
> >  /**
> > - * mlx90632_perform_measurement - Trigger and retrieve current measurement cycle
> > - * @*data: pointer to mlx90632_data object containing regmap information
> > + * mlx90632_perform_measurement() - Trigger and retrieve current measurement cycle
> > + * @data: pointer to mlx90632_data object containing regmap information
> >   *
> >   * Perform a measurement and return latest measurement cycle position reported
> >   * by sensor. This is a blocking function for 500ms, as that is default sensor
> > --
> > 2.25.1
> >  


WARNING: multiple messages have this Message-ID (diff)
From: Jonathan Cameron <jic23@kernel.org>
To: Crt Mori <cmo@melexis.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	Linux Iio <linux-iio@vger.kernel.org>,
	Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
	Peter Meerwald <pmeerw@pmeerw.net>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Lee Jones <lee.jones@linaro.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 09/30] iio: temperature: mlx90632: Function parameter descriptions must match exactly
Date: Sat, 18 Jul 2020 16:42:27 +0100	[thread overview]
Message-ID: <20200718164227.0e31c078@archlinux> (raw)
In-Reply-To: <CAKv63uvMb1R2OyBwFuCTU+E5YQfHwBB+bqRP+jXO9yn4e2Wu6w@mail.gmail.com>

On Fri, 17 Jul 2020 21:48:06 +0200
Crt Mori <cmo@melexis.com> wrote:

> Acked-by: Crt Mori <cmo@melexis.com>
> 
> On Fri, 17 Jul 2020 at 18:56, Lee Jones <lee.jones@linaro.org> wrote:
> >
> > '*'s are not welcome in kerneldoc parameter names.
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> >  drivers/iio/temperature/mlx90632.c:175: warning: Function parameter or member 'data' not described in 'mlx90632_perform_measurement'
> >
> > Cc: Crt Mori <cmo@melexis.com>
> > Signed-off-by: Lee Jones <lee.jones@linaro.org>
I got lazy on bothering about the addition of optional brackets.

Applied,

Thanks,

Jonathan

> > ---
> >  drivers/iio/temperature/mlx90632.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/iio/temperature/mlx90632.c b/drivers/iio/temperature/mlx90632.c
> > index eaca6ba068646..b9a8089be3f63 100644
> > --- a/drivers/iio/temperature/mlx90632.c
> > +++ b/drivers/iio/temperature/mlx90632.c
> > @@ -164,8 +164,8 @@ static s32 mlx90632_pwr_continuous(struct regmap *regmap)
> >  }
> >
> >  /**
> > - * mlx90632_perform_measurement - Trigger and retrieve current measurement cycle
> > - * @*data: pointer to mlx90632_data object containing regmap information
> > + * mlx90632_perform_measurement() - Trigger and retrieve current measurement cycle
> > + * @data: pointer to mlx90632_data object containing regmap information
> >   *
> >   * Perform a measurement and return latest measurement cycle position reported
> >   * by sensor. This is a blocking function for 500ms, as that is default sensor
> > --
> > 2.25.1
> >  


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-07-18 15:42 UTC|newest]

Thread overview: 131+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-17 16:55 [PATCH 00/30] Second batch of W=1 fixes for IIO Lee Jones
2020-07-17 16:55 ` Lee Jones
2020-07-17 16:55 ` [PATCH 01/30] iio: adc: ti_am335x_adc: Remove a couple of unused 'read' variables Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 15:30   ` Jonathan Cameron
2020-07-18 15:30     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 02/30] iio: adc: twl4030-madc: Remove set but unused variables 'len' Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 15:32   ` Jonathan Cameron
2020-07-18 15:32     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 03/30] iio: adc: twl4030-madc: Fix misnamed struct attribute Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 15:33   ` Jonathan Cameron
2020-07-18 15:33     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 04/30] iio: magnetometer: hmc5843: 'hmc5843_pm_ops' is unused in 1 of 3 files including hmc5843_core.h Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 15:34   ` Jonathan Cameron
2020-07-18 15:34     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 05/30] iio: adc: twl6030-gpadc: Fix some misdocumentation and formatting issues Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 15:38   ` Jonathan Cameron
2020-07-18 15:38     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 06/30] iio: dac: ltc2632: Fix formatting in kerneldoc struct header Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 15:39   ` Jonathan Cameron
2020-07-18 15:39     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 07/30] iio: light: si1145: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 15:40   ` Jonathan Cameron
2020-07-18 15:40     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 08/30] iio: resolver: ad2s1200: Change ordering of compiler attribute macro Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 15:41   ` Jonathan Cameron
2020-07-18 15:41     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 09/30] iio: temperature: mlx90632: Function parameter descriptions must match exactly Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-17 19:48   ` Crt Mori
2020-07-17 19:48     ` Crt Mori
2020-07-18 15:42     ` Jonathan Cameron [this message]
2020-07-18 15:42       ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 10/30] iio: light: us5182d: Fix formatting in kerneldoc function block Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 15:44   ` Jonathan Cameron
2020-07-18 15:44     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 11/30] iio: adc: ad799x: Demote seemingly unintentional kerneldoc header Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 15:47   ` Jonathan Cameron
2020-07-18 15:47     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 12/30] iio: dac: ad5504: Fix formatting errors and demote non-compliant kerneldoc Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 15:48   ` Jonathan Cameron
2020-07-18 15:48     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 13/30] iio: adc: at91_adc: Fix 'bad line' warning Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 15:48   ` Jonathan Cameron
2020-07-18 15:48     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 14/30] iio: adc: at91-sama5d2_adc: Struct kerneldoc titles need to start with 'struct ' Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 15:49   ` Jonathan Cameron
2020-07-18 15:49     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 15/30] iio: adc: cpcap-adc: Demote seemingly unintentional kerneldoc header Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 15:50   ` Jonathan Cameron
2020-07-18 15:50     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 16/30] iio: accel: sca3000: Fix 2 misspellings and demote nonconforming kerneldocs Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 15:51   ` Jonathan Cameron
2020-07-18 15:51     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 17/30] iio: gyro: adxrs450: Change ordering of compiler attribute macro Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 15:52   ` Jonathan Cameron
2020-07-18 15:52     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 18/30] iio: gyro: fxas21002c: Move 'fxas21002c_reg_fields' to the only file its used Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 15:54   ` Jonathan Cameron
2020-07-18 15:54     ` Jonathan Cameron
2020-07-22 20:20   ` Rui Miguel Silva
2020-07-22 20:20     ` Rui Miguel Silva
2020-07-17 16:55 ` [PATCH 19/30] iio: imu: st_lsm6dsx: st_lsm6dsx: Reorder 'inline' declaration Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 15:54   ` Jonathan Cameron
2020-07-18 15:54     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 20/30] iio: adc: max1363: Fix kerneldoc attribute formatting for 'lock' Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 15:56   ` Jonathan Cameron
2020-07-18 15:56     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 21/30] iio: adc: max9611: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 15:59   ` Jonathan Cameron
2020-07-18 15:59     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 22/30] iio: adc: mcp320x: Change ordering of compiler attribute macro Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 16:00   ` Jonathan Cameron
2020-07-18 16:00     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 23/30] iio: adc: palmas_gpadc: Demote non-conforming kerneldoc header Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 16:01   ` Jonathan Cameron
2020-07-18 16:01     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 24/30] iio: imu: inv_mpu6050: inv_mpu_core: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 16:02   ` Jonathan Cameron
2020-07-18 16:02     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 25/30] iio: imu: inv_mpu6050: inv_mpu_ring: Demote seemingly unintentional kerneldoc header Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 16:03   ` Jonathan Cameron
2020-07-18 16:03     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 26/30] iio: adc: qcom-pm8xxx-xoadc: Demote standard comment block and supply missing description Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-17 20:15   ` Bjorn Andersson
2020-07-17 20:15     ` Bjorn Andersson
2020-07-18 16:06     ` Jonathan Cameron
2020-07-18 16:06       ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 27/30] iio: magnetometer: ak8974: Add description for ak8974's 'scan' attribute Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 16:08   ` Jonathan Cameron
2020-07-18 16:08     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 28/30] iio: imu: st_lsm6dsx: st_lsm6dsx_shub: Demote obvious misuse of kerneldoc to standard comment blocks Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 16:13   ` Jonathan Cameron
2020-07-18 16:13     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 29/30] iio: imu: st_lsm6dsx: st_lsm6dsx: Mark 'st_lsm6dsx_accel_ext_info' as __maybe_unused Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-18 16:14   ` Jonathan Cameron
2020-07-18 16:14     ` Jonathan Cameron
2020-07-17 16:55 ` [PATCH 30/30] iio: adc: rockchip_saradc: Demote Demote seemingly unintentional kerneldoc header Lee Jones
2020-07-17 16:55   ` Lee Jones
2020-07-17 19:10   ` Heiko Stübner
2020-07-17 19:10     ` Heiko Stübner
2020-07-17 19:10     ` Heiko Stübner
2020-07-18 16:15     ` Jonathan Cameron
2020-07-18 16:15       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200718164227.0e31c078@archlinux \
    --to=jic23@kernel.org \
    --cc=cmo@melexis.com \
    --cc=knaack.h@gmx.de \
    --cc=lars@metafoo.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.