From: Suraj Upadhyay <usuraj35@gmail.com> To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rts5208: rtsx: Replace depracated MSI API Date: Sun, 19 Jul 2020 10:04:50 +0530 [thread overview] Message-ID: <20200719043450.GB28510@blackclown> (raw) In-Reply-To: <20200718154030.GA28042@blackclown> On Sat, Jul 18, 2020 at 09:10:30PM +0530, Suraj Upadhyay wrote: > Replace depracated pci_enable_msi with pci_alloc_irq_vectors. > > Signed-off-by: Suraj Upadhyay <usuraj35@gmail.com> > --- > drivers/staging/rts5208/rtsx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Hii, don't merge this patch. It is still incomplete. It doesn't replace pci_disable_msi. I hope this didn't cause any annoyances. Thanks, Suraj Upadhyay. > diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c > index e28e162d004e..b39d3f8b54df 100644 > --- a/drivers/staging/rts5208/rtsx.c > +++ b/drivers/staging/rts5208/rtsx.c > @@ -310,7 +310,7 @@ static int __maybe_unused rtsx_resume(struct device *dev_d) > pci_set_master(pci); > > if (chip->msi_en) { > - if (pci_enable_msi(pci) < 0) > + if (pci_alloc_irq_vectors(pci, 1, 1, PCI_IRQ_MSI) < 0) > chip->msi_en = 0; > } > > @@ -881,7 +881,7 @@ static int rtsx_probe(struct pci_dev *pci, > dev_info(&pci->dev, "pci->irq = %d\n", pci->irq); > > if (dev->chip->msi_en) { > - if (pci_enable_msi(pci) < 0) > + if (pci_alloc_irq_vectors(pci, 1, 1, PCI_IRQ_MSI) < 0) > dev->chip->msi_en = 0; > } > > -- > 2.17.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Suraj Upadhyay <usuraj35@gmail.com> To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] staging: rts5208: rtsx: Replace depracated MSI API Date: Sun, 19 Jul 2020 10:04:50 +0530 [thread overview] Message-ID: <20200719043450.GB28510@blackclown> (raw) In-Reply-To: <20200718154030.GA28042@blackclown> On Sat, Jul 18, 2020 at 09:10:30PM +0530, Suraj Upadhyay wrote: > Replace depracated pci_enable_msi with pci_alloc_irq_vectors. > > Signed-off-by: Suraj Upadhyay <usuraj35@gmail.com> > --- > drivers/staging/rts5208/rtsx.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > Hii, don't merge this patch. It is still incomplete. It doesn't replace pci_disable_msi. I hope this didn't cause any annoyances. Thanks, Suraj Upadhyay. > diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c > index e28e162d004e..b39d3f8b54df 100644 > --- a/drivers/staging/rts5208/rtsx.c > +++ b/drivers/staging/rts5208/rtsx.c > @@ -310,7 +310,7 @@ static int __maybe_unused rtsx_resume(struct device *dev_d) > pci_set_master(pci); > > if (chip->msi_en) { > - if (pci_enable_msi(pci) < 0) > + if (pci_alloc_irq_vectors(pci, 1, 1, PCI_IRQ_MSI) < 0) > chip->msi_en = 0; > } > > @@ -881,7 +881,7 @@ static int rtsx_probe(struct pci_dev *pci, > dev_info(&pci->dev, "pci->irq = %d\n", pci->irq); > > if (dev->chip->msi_en) { > - if (pci_enable_msi(pci) < 0) > + if (pci_alloc_irq_vectors(pci, 1, 1, PCI_IRQ_MSI) < 0) > dev->chip->msi_en = 0; > } > > -- > 2.17.1 > _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-07-19 4:35 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-18 15:40 [PATCH v2] staging: rts5208: rtsx: Replace depracated MSI API Suraj Upadhyay 2020-07-18 15:40 ` Suraj Upadhyay 2020-07-19 4:34 ` Suraj Upadhyay [this message] 2020-07-19 4:34 ` Suraj Upadhyay 2020-07-19 14:34 Suraj Upadhyay 2020-07-19 14:34 ` Suraj Upadhyay
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200719043450.GB28510@blackclown \ --to=usuraj35@gmail.com \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.