* [PATCH] net: ag71xx: add missed clk_disable_unprepare in error path of probe
@ 2020-07-20 1:46 Huang Guobin
0 siblings, 0 replies; 3+ messages in thread
From: Huang Guobin @ 2020-07-20 1:46 UTC (permalink / raw)
To: linux-kernel
The ag71xx_mdio_probe() forgets to call clk_disable_unprepare() when
of_reset_control_get_exclusive() failed. Add the missed call to fix it.
Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Huang Guobin <huangguobin4@huawei.com>
---
drivers/net/ethernet/atheros/ag71xx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c
index 112edbd30823..38cce66ef212 100644
--- a/drivers/net/ethernet/atheros/ag71xx.c
+++ b/drivers/net/ethernet/atheros/ag71xx.c
@@ -556,7 +556,8 @@ static int ag71xx_mdio_probe(struct ag71xx *ag)
ag->mdio_reset = of_reset_control_get_exclusive(np, "mdio");
if (IS_ERR(ag->mdio_reset)) {
netif_err(ag, probe, ndev, "Failed to get reset mdio.\n");
- return PTR_ERR(ag->mdio_reset);
+ err = PTR_ERR(ag->mdio_reset);
+ goto mdio_err_put_clk;
}
mii_bus->name = "ag71xx_mdio";
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] net: ag71xx: add missed clk_disable_unprepare in error path of probe
2020-07-20 1:46 Huang Guobin
@ 2020-07-21 1:38 ` David Miller
0 siblings, 0 replies; 3+ messages in thread
From: David Miller @ 2020-07-21 1:38 UTC (permalink / raw)
To: huangguobin4; +Cc: netdev
From: Huang Guobin <huangguobin4@huawei.com>
Date: Sun, 19 Jul 2020 21:46:14 -0400
> The ag71xx_mdio_probe() forgets to call clk_disable_unprepare() when
> of_reset_control_get_exclusive() failed. Add the missed call to fix it.
>
> Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Huang Guobin <huangguobin4@huawei.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] net: ag71xx: add missed clk_disable_unprepare in error path of probe
@ 2020-07-20 1:46 Huang Guobin
2020-07-21 1:38 ` David Miller
0 siblings, 1 reply; 3+ messages in thread
From: Huang Guobin @ 2020-07-20 1:46 UTC (permalink / raw)
To: netdev
The ag71xx_mdio_probe() forgets to call clk_disable_unprepare() when
of_reset_control_get_exclusive() failed. Add the missed call to fix it.
Fixes: d51b6ce441d3 ("net: ethernet: add ag71xx driver")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Huang Guobin <huangguobin4@huawei.com>
---
drivers/net/ethernet/atheros/ag71xx.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/atheros/ag71xx.c b/drivers/net/ethernet/atheros/ag71xx.c
index 112edbd30823..38cce66ef212 100644
--- a/drivers/net/ethernet/atheros/ag71xx.c
+++ b/drivers/net/ethernet/atheros/ag71xx.c
@@ -556,7 +556,8 @@ static int ag71xx_mdio_probe(struct ag71xx *ag)
ag->mdio_reset = of_reset_control_get_exclusive(np, "mdio");
if (IS_ERR(ag->mdio_reset)) {
netif_err(ag, probe, ndev, "Failed to get reset mdio.\n");
- return PTR_ERR(ag->mdio_reset);
+ err = PTR_ERR(ag->mdio_reset);
+ goto mdio_err_put_clk;
}
mii_bus->name = "ag71xx_mdio";
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-21 1:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-20 1:46 [PATCH] net: ag71xx: add missed clk_disable_unprepare in error path of probe Huang Guobin
-- strict thread matches above, loose matches on Subject: below --
2020-07-20 1:46 Huang Guobin
2020-07-21 1:38 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.