[PATCH v2 1/2] ARM: dts: imx6qdl-sabresd: Add an mdio node

[PATCH v2 1/2] ARM: dts: imx6qdl-sabresd: Add an mdio node

[Fabio Estevam]

imx6qdl-sabresd has an Atheros AR8031 Ethernet PHY at address 1.

The AR8031 provides a 125MHz clock to the ENET_REF_CLK i.MX6 pin.

Improve the Ethernet representation by adding an mdio node with such
information.

An advantage of adding the mdio node is that the AR8031 initialization
code in the mx6sabresd board file in U-Boot can totally be removed.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v1:
- None. Only inverted the order of the patches

 arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
index 28b35ccb3757..6524ad4b0010 100644
--- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
@@ -203,9 +203,20 @@
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
 	phy-mode = "rgmii-id";
+	phy-handle = <&phy>;
 	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
 	fsl,magic-packet;
 	status = "okay";
+
+	mdio {
+		#address-cells = <1>;
+		#size-cells = <0>;
+
+		phy: ethernet-phy@1 {
+			reg = <1>;
+			qca,clk-out-frequency = <125000000>;
+		};
+	};
 };
 
 &hdmi {
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

[PATCH v2 2/2] ARM: dts: imx6qdl-sabresd: Pass reset-assert-us

[Fabio Estevam]

According to the AR8031 datasheet:

"When using crystal, clock is generated internally after the power is
stable. In order to get reliable power-on-reset, it is recommended to
keep asserting the reset low signal long enough (10 ms) to ensure the
clock is stable and clock-to-reset (1 ms) requirement is satisfied."

Pass the 'reset-assert-us' property to describe such requirement.

While at it, use the 'reset-gpios' property inside the the mdio
node instead of the deprecated usage of 'phy-reset-gpios'.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v1:
- Use reset-gpios and reset-assert-us inside the mdio node
instead of the deprecated usage of phy-reset-gpios (Soeren)

 arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
index 6524ad4b0010..5597d45fffda 100644
--- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
@@ -204,7 +204,6 @@
 	pinctrl-0 = <&pinctrl_enet>;
 	phy-mode = "rgmii-id";
 	phy-handle = <&phy>;
-	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
 	fsl,magic-packet;
 	status = "okay";
 
@@ -215,6 +214,8 @@
 		phy: ethernet-phy@1 {
 			reg = <1>;
 			qca,clk-out-frequency = <125000000>;
+			reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
+			reset-assert-us = <10000>;
 		};
 	};
 };
-- 
2.17.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 1/2] ARM: dts: imx6qdl-sabresd: Add an mdio node

[Sören Moch]

On 13.07.20 15:04, Fabio Estevam wrote:
> imx6qdl-sabresd has an Atheros AR8031 Ethernet PHY at address 1.
>
> The AR8031 provides a 125MHz clock to the ENET_REF_CLK i.MX6 pin.
>
> Improve the Ethernet representation by adding an mdio node with such
> information.
>
> An advantage of adding the mdio node is that the AR8031 initialization
> code in the mx6sabresd board file in U-Boot can totally be removed.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Reviewed-by: Soeren Moch <smoch@web.de>

Thanks,
Soeren

> ---
> Changes since v1:
> - None. Only inverted the order of the patches
>
>  arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 11 +++++++++++
>  1 file changed, 11 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> index 28b35ccb3757..6524ad4b0010 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> @@ -203,9 +203,20 @@
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_enet>;
>  	phy-mode = "rgmii-id";
> +	phy-handle = <&phy>;
>  	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
>  	fsl,magic-packet;
>  	status = "okay";
> +
> +	mdio {
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +
> +		phy: ethernet-phy@1 {
> +			reg = <1>;
> +			qca,clk-out-frequency = <125000000>;
> +		};
> +	};
>  };
>
>  &hdmi {


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 2/2] ARM: dts: imx6qdl-sabresd: Pass reset-assert-us

[Soeren Moch]

On 13.07.20 15:04, Fabio Estevam wrote:
> According to the AR8031 datasheet:
>
> "When using crystal, clock is generated internally after the power is
> stable. In order to get reliable power-on-reset, it is recommended to
> keep asserting the reset low signal long enough (10 ms) to ensure the
> clock is stable and clock-to-reset (1 ms) requirement is satisfied."
>
> Pass the 'reset-assert-us' property to describe such requirement.
>
> While at it, use the 'reset-gpios' property inside the the mdio
> node instead of the deprecated usage of 'phy-reset-gpios'.
>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Reviewed-by: Soeren Moch <smoch@web.de>

Thanks,
Soeren

> ---
> Changes since v1:
> - Use reset-gpios and reset-assert-us inside the mdio node
> instead of the deprecated usage of phy-reset-gpios (Soeren)
>
>  arch/arm/boot/dts/imx6qdl-sabresd.dtsi | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> index 6524ad4b0010..5597d45fffda 100644
> --- a/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-sabresd.dtsi
> @@ -204,7 +204,6 @@
>  	pinctrl-0 = <&pinctrl_enet>;
>  	phy-mode = "rgmii-id";
>  	phy-handle = <&phy>;
> -	phy-reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
>  	fsl,magic-packet;
>  	status = "okay";
>
> @@ -215,6 +214,8 @@
>  		phy: ethernet-phy@1 {
>  			reg = <1>;
>  			qca,clk-out-frequency = <125000000>;
> +			reset-gpios = <&gpio1 25 GPIO_ACTIVE_LOW>;
> +			reset-assert-us = <10000>;
>  		};
>  	};
>  };


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: [PATCH v2 1/2] ARM: dts: imx6qdl-sabresd: Add an mdio node

[Shawn Guo]

On Mon, Jul 13, 2020 at 10:04:15AM -0300, Fabio Estevam wrote:
> imx6qdl-sabresd has an Atheros AR8031 Ethernet PHY at address 1.
> 
> The AR8031 provides a 125MHz clock to the ENET_REF_CLK i.MX6 pin.
> 
> Improve the Ethernet representation by adding an mdio node with such
> information.
> 
> An advantage of adding the mdio node is that the AR8031 initialization
> code in the mx6sabresd board file in U-Boot can totally be removed.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>

Applied both, thanks.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel