From: Vaibhav Gupta <vaibhavgupta40@gmail.com> To: Damien Le Moal <Damien.LeMoal@wdc.com> Cc: Bjorn Helgaas <helgaas@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, Bjorn Helgaas <bjorn@helgaas.com>, Vaibhav Gupta <vaibhav.varodek@gmail.com>, Jens Axboe <axboe@kernel.dk>, Joshua Morris <josh.h.morris@us.ibm.com>, Philip Kelleher <pjk1939@linux.ibm.com>, "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-kernel-mentees@lists.linuxfoundation.org" <linux-kernel-mentees@lists.linuxfoundation.org>, Shuah Khan <skhan@linuxfoundation.org> Subject: Re: [PATCH v1 3/3] skd: use generic power management Date: Tue, 21 Jul 2020 12:34:40 +0530 [thread overview] Message-ID: <20200721070440.GA51743@gmail.com> (raw) In-Reply-To: <CY4PR04MB3751EB3DA357A6856B3337D0E7780@CY4PR04MB3751.namprd04.prod.outlook.com> On Tue, Jul 21, 2020 at 02:49:06AM +0000, Damien Le Moal wrote: > On 2020/07/20 22:18, Vaibhav Gupta wrote: > > On Mon, Jul 20, 2020 at 12:52:14PM +0000, Damien Le Moal wrote: > >> On 2020/07/17 17:10, Vaibhav Gupta wrote: > >>> Change function parameter in both .suspend() and .resume() to > >>> "struct device*" type. Use to_pci_dev() to get "struct pci_dev*" variable. > >>> > >>> Compile-tested only. > >> > >> I do not think this belongs into the commit message. This was mentioned in the > >> cover letter. > >> > > The messages in cover letter and commit message are bit similar. But the commit > > message has patch specific changes mentioned in it. > > My point was about the "compile-tested only" mention in the commit message. That > should be mentioned in the cover letter only. The goal of the patch review > process is also to get these patches tested by others if you do not have access > to the hardware. That is fine, and I can test for the skd driver. But a patch > mentioning that it is untested cannot be applied, for obvious reasons :) > > So I only requested that you remove the "compiled tested only" note. The commit > message could be simpler too, see followup comment. > Oh okay. Thanks for clarification and pointing this out :) . From now on, I will put "Compile-tested only." message only in cover letters. Thanks. --Vaibhav Gupta > > > -- > Damien Le Moal > Western Digital Research
WARNING: multiple messages have this Message-ID (diff)
From: Vaibhav Gupta <vaibhavgupta40@gmail.com> To: Damien Le Moal <Damien.LeMoal@wdc.com> Cc: Jens Axboe <axboe@kernel.dk>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>, Bjorn Helgaas <helgaas@kernel.org>, Bjorn Helgaas <bhelgaas@google.com>, Philip Kelleher <pjk1939@linux.ibm.com>, "linux-kernel-mentees@lists.linuxfoundation.org" <linux-kernel-mentees@lists.linuxfoundation.org>, Joshua Morris <josh.h.morris@us.ibm.com> Subject: Re: [Linux-kernel-mentees] [PATCH v1 3/3] skd: use generic power management Date: Tue, 21 Jul 2020 12:34:40 +0530 [thread overview] Message-ID: <20200721070440.GA51743@gmail.com> (raw) In-Reply-To: <CY4PR04MB3751EB3DA357A6856B3337D0E7780@CY4PR04MB3751.namprd04.prod.outlook.com> On Tue, Jul 21, 2020 at 02:49:06AM +0000, Damien Le Moal wrote: > On 2020/07/20 22:18, Vaibhav Gupta wrote: > > On Mon, Jul 20, 2020 at 12:52:14PM +0000, Damien Le Moal wrote: > >> On 2020/07/17 17:10, Vaibhav Gupta wrote: > >>> Change function parameter in both .suspend() and .resume() to > >>> "struct device*" type. Use to_pci_dev() to get "struct pci_dev*" variable. > >>> > >>> Compile-tested only. > >> > >> I do not think this belongs into the commit message. This was mentioned in the > >> cover letter. > >> > > The messages in cover letter and commit message are bit similar. But the commit > > message has patch specific changes mentioned in it. > > My point was about the "compile-tested only" mention in the commit message. That > should be mentioned in the cover letter only. The goal of the patch review > process is also to get these patches tested by others if you do not have access > to the hardware. That is fine, and I can test for the skd driver. But a patch > mentioning that it is untested cannot be applied, for obvious reasons :) > > So I only requested that you remove the "compiled tested only" note. The commit > message could be simpler too, see followup comment. > Oh okay. Thanks for clarification and pointing this out :) . From now on, I will put "Compile-tested only." message only in cover letters. Thanks. --Vaibhav Gupta > > > -- > Damien Le Moal > Western Digital Research _______________________________________________ Linux-kernel-mentees mailing list Linux-kernel-mentees@lists.linuxfoundation.org https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
next prev parent reply other threads:[~2020-07-21 7:06 UTC|newest] Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-17 8:09 [PATCH v1 0/3] block: use generic power management Vaibhav Gupta 2020-07-17 8:09 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-17 8:09 ` [PATCH v1 1/3] mtip32xx: " Vaibhav Gupta 2020-07-17 8:09 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-17 8:09 ` [PATCH v1 2/3] rsxx: " Vaibhav Gupta 2020-07-17 8:09 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-17 8:09 ` [PATCH v1 3/3] skd: " Vaibhav Gupta 2020-07-17 8:09 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-20 12:52 ` Damien Le Moal 2020-07-20 12:52 ` [Linux-kernel-mentees] " Damien Le Moal 2020-07-20 13:16 ` Vaibhav Gupta 2020-07-20 13:16 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-21 2:49 ` Damien Le Moal 2020-07-21 2:49 ` [Linux-kernel-mentees] " Damien Le Moal 2020-07-21 7:04 ` Vaibhav Gupta [this message] 2020-07-21 7:04 ` Vaibhav Gupta 2020-07-20 13:29 ` [PATCH v2 0/3] block: " Vaibhav Gupta 2020-07-20 13:29 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-20 13:30 ` [PATCH v2 1/3] mtip32xx: " Vaibhav Gupta 2020-07-20 13:30 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-20 13:30 ` [PATCH v2 2/3] rsxx: " Vaibhav Gupta 2020-07-20 13:30 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-20 13:30 ` [PATCH v2 3/3] skd: " Vaibhav Gupta 2020-07-20 13:30 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-21 2:57 ` Damien Le Moal 2020-07-21 2:57 ` [Linux-kernel-mentees] " Damien Le Moal 2020-07-21 7:09 ` Vaibhav Gupta 2020-07-21 7:09 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-22 6:28 ` Damien Le Moal 2020-07-22 6:28 ` [Linux-kernel-mentees] " Damien Le Moal 2020-07-22 7:21 ` Vaibhav Gupta 2020-07-22 7:21 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-22 8:33 ` [PATCH v3 0/3] block: " Vaibhav Gupta 2020-07-22 8:33 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-22 8:33 ` [PATCH v3 1/3] mtip32xx: " Vaibhav Gupta 2020-07-22 8:33 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-22 8:33 ` [PATCH v3 2/3] rsxx: " Vaibhav Gupta 2020-07-22 8:33 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-22 8:33 ` [PATCH v3 3/3] skd: " Vaibhav Gupta 2020-07-22 8:33 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-27 2:14 ` Damien Le Moal 2020-07-27 2:14 ` [Linux-kernel-mentees] " Damien Le Moal 2020-08-17 7:55 ` [PATCH v3 0/3] block: " Vaibhav Gupta 2020-08-17 7:55 ` [Linux-kernel-mentees] " Vaibhav Gupta 2021-01-14 11:54 ` [PATCH v4 " Vaibhav Gupta 2021-01-14 11:54 ` [Linux-kernel-mentees] " Vaibhav Gupta 2021-01-14 11:54 ` [PATCH v4 1/3] mtip32xx: " Vaibhav Gupta 2021-01-14 11:54 ` [Linux-kernel-mentees] " Vaibhav Gupta 2021-01-14 11:54 ` [PATCH v4 2/3] rsxx: " Vaibhav Gupta 2021-01-14 11:54 ` [Linux-kernel-mentees] " Vaibhav Gupta 2021-01-14 11:54 ` [PATCH v4 3/3] skd: " Vaibhav Gupta 2021-01-14 11:54 ` [Linux-kernel-mentees] " Vaibhav Gupta 2020-07-22 17:52 ` [PATCH v2 " Bjorn Helgaas 2020-07-22 17:52 ` [Linux-kernel-mentees] " Bjorn Helgaas 2020-07-22 18:07 ` Vaibhav Gupta 2020-07-22 18:07 ` [Linux-kernel-mentees] " Vaibhav Gupta
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200721070440.GA51743@gmail.com \ --to=vaibhavgupta40@gmail.com \ --cc=Damien.LeMoal@wdc.com \ --cc=axboe@kernel.dk \ --cc=bhelgaas@google.com \ --cc=bjorn@helgaas.com \ --cc=helgaas@kernel.org \ --cc=josh.h.morris@us.ibm.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-kernel-mentees@lists.linuxfoundation.org \ --cc=linux-kernel@vger.kernel.org \ --cc=pjk1939@linux.ibm.com \ --cc=skhan@linuxfoundation.org \ --cc=vaibhav.varodek@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.