From: kernel test robot <lkp@intel.com>
To: Magnus Karlsson <magnus.karlsson@intel.com>,
bjorn.topel@intel.com, ast@kernel.org, daniel@iogearbox.net,
netdev@vger.kernel.org, jonathan.lemon@gmail.com,
maximmi@mellanox.com
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
bpf@vger.kernel.org, jeffrey.t.kirsher@intel.com,
anthony.l.nguyen@intel.com
Subject: Re: [PATCH bpf-next v3 04/14] xsk: move fill and completion rings to buffer pool
Date: Tue, 21 Jul 2020 07:53:09 +0800 [thread overview]
Message-ID: <202007210758.fYtjWEpY%lkp@intel.com> (raw)
In-Reply-To: <1595236694-12749-5-git-send-email-magnus.karlsson@intel.com>
[-- Attachment #1: Type: text/plain, Size: 2578 bytes --]
Hi Magnus,
I love your patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Magnus-Karlsson/xsk-support-shared-umems-between-devices-and-queues/20200720-180143
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project cf1105069648446d58adfb7a6cc590013d6886ba)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> net/xdp/xsk_diag.c:88:72: error: no member named 'fq' in 'struct xdp_umem'
du.n_fill_ring_empty = xs->umem ? xskq_nb_queue_empty_descs(xs->umem->fq) : 0;
~~~~~~~~ ^
1 error generated.
vim +88 net/xdp/xsk_diag.c
a36b38aa2af6114 Björn Töpel 2019-01-24 80
0d80cb4612aa32d Ciara Loftus 2020-07-08 81 static int xsk_diag_put_stats(const struct xdp_sock *xs, struct sk_buff *nlskb)
0d80cb4612aa32d Ciara Loftus 2020-07-08 82 {
0d80cb4612aa32d Ciara Loftus 2020-07-08 83 struct xdp_diag_stats du = {};
0d80cb4612aa32d Ciara Loftus 2020-07-08 84
0d80cb4612aa32d Ciara Loftus 2020-07-08 85 du.n_rx_dropped = xs->rx_dropped;
0d80cb4612aa32d Ciara Loftus 2020-07-08 86 du.n_rx_invalid = xskq_nb_invalid_descs(xs->rx);
0d80cb4612aa32d Ciara Loftus 2020-07-08 87 du.n_rx_full = xs->rx_queue_full;
0d80cb4612aa32d Ciara Loftus 2020-07-08 @88 du.n_fill_ring_empty = xs->umem ? xskq_nb_queue_empty_descs(xs->umem->fq) : 0;
0d80cb4612aa32d Ciara Loftus 2020-07-08 89 du.n_tx_invalid = xskq_nb_invalid_descs(xs->tx);
0d80cb4612aa32d Ciara Loftus 2020-07-08 90 du.n_tx_ring_empty = xskq_nb_queue_empty_descs(xs->tx);
0d80cb4612aa32d Ciara Loftus 2020-07-08 91 return nla_put(nlskb, XDP_DIAG_STATS, sizeof(du), &du);
0d80cb4612aa32d Ciara Loftus 2020-07-08 92 }
0d80cb4612aa32d Ciara Loftus 2020-07-08 93
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 75359 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH bpf-next v3 04/14] xsk: move fill and completion rings to buffer pool
Date: Tue, 21 Jul 2020 07:53:09 +0800 [thread overview]
Message-ID: <202007210758.fYtjWEpY%lkp@intel.com> (raw)
In-Reply-To: <1595236694-12749-5-git-send-email-magnus.karlsson@intel.com>
[-- Attachment #1: Type: text/plain, Size: 2630 bytes --]
Hi Magnus,
I love your patch! Yet something to improve:
[auto build test ERROR on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Magnus-Karlsson/xsk-support-shared-umems-between-devices-and-queues/20200720-180143
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 12.0.0 (https://github.com/llvm/llvm-project cf1105069648446d58adfb7a6cc590013d6886ba)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
>> net/xdp/xsk_diag.c:88:72: error: no member named 'fq' in 'struct xdp_umem'
du.n_fill_ring_empty = xs->umem ? xskq_nb_queue_empty_descs(xs->umem->fq) : 0;
~~~~~~~~ ^
1 error generated.
vim +88 net/xdp/xsk_diag.c
a36b38aa2af6114 Björn Töpel 2019-01-24 80
0d80cb4612aa32d Ciara Loftus 2020-07-08 81 static int xsk_diag_put_stats(const struct xdp_sock *xs, struct sk_buff *nlskb)
0d80cb4612aa32d Ciara Loftus 2020-07-08 82 {
0d80cb4612aa32d Ciara Loftus 2020-07-08 83 struct xdp_diag_stats du = {};
0d80cb4612aa32d Ciara Loftus 2020-07-08 84
0d80cb4612aa32d Ciara Loftus 2020-07-08 85 du.n_rx_dropped = xs->rx_dropped;
0d80cb4612aa32d Ciara Loftus 2020-07-08 86 du.n_rx_invalid = xskq_nb_invalid_descs(xs->rx);
0d80cb4612aa32d Ciara Loftus 2020-07-08 87 du.n_rx_full = xs->rx_queue_full;
0d80cb4612aa32d Ciara Loftus 2020-07-08 @88 du.n_fill_ring_empty = xs->umem ? xskq_nb_queue_empty_descs(xs->umem->fq) : 0;
0d80cb4612aa32d Ciara Loftus 2020-07-08 89 du.n_tx_invalid = xskq_nb_invalid_descs(xs->tx);
0d80cb4612aa32d Ciara Loftus 2020-07-08 90 du.n_tx_ring_empty = xskq_nb_queue_empty_descs(xs->tx);
0d80cb4612aa32d Ciara Loftus 2020-07-08 91 return nla_put(nlskb, XDP_DIAG_STATS, sizeof(du), &du);
0d80cb4612aa32d Ciara Loftus 2020-07-08 92 }
0d80cb4612aa32d Ciara Loftus 2020-07-08 93
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 75359 bytes --]
next prev parent reply other threads:[~2020-07-21 0:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-20 9:18 [PATCH bpf-next v3 00/14] xsk: support shared umems between devices and queues Magnus Karlsson
2020-07-20 9:18 ` [PATCH bpf-next v3 01/14] xsk: i40e: ice: ixgbe: mlx5: pass buffer pool to driver instead of umem Magnus Karlsson
2020-07-20 9:18 ` [PATCH bpf-next v3 02/14] xsk: i40e: ice: ixgbe: mlx5: rename xsk zero-copy driver interfaces Magnus Karlsson
2020-07-20 9:18 ` [PATCH bpf-next v3 03/14] xsk: create and free buffer pool independently from umem Magnus Karlsson
2020-07-20 9:18 ` [PATCH bpf-next v3 04/14] xsk: move fill and completion rings to buffer pool Magnus Karlsson
2020-07-20 11:45 ` kernel test robot
2020-07-20 11:45 ` kernel test robot
2020-07-20 13:23 ` Magnus Karlsson
2020-07-20 23:53 ` kernel test robot [this message]
2020-07-20 23:53 ` kernel test robot
2020-07-20 9:18 ` [PATCH bpf-next v3 05/14] xsk: move queue_id, dev and need_wakeup " Magnus Karlsson
2020-07-20 9:18 ` [PATCH bpf-next v3 06/14] xsk: move xsk_tx_list and its lock " Magnus Karlsson
2020-07-20 9:18 ` [PATCH bpf-next v3 07/14] xsk: move addrs from buffer pool to umem Magnus Karlsson
2020-07-20 9:18 ` [PATCH bpf-next v3 08/14] xsk: enable sharing of dma mappings Magnus Karlsson
2020-07-20 9:18 ` [PATCH bpf-next v3 09/14] xsk: rearrange internal structs for better performance Magnus Karlsson
2020-07-20 9:18 ` [PATCH bpf-next v3 10/14] xsk: add shared umem support between queue ids Magnus Karlsson
2020-07-20 9:18 ` [PATCH bpf-next v3 11/14] xsk: add shared umem support between devices Magnus Karlsson
2020-07-20 9:18 ` [PATCH bpf-next v3 12/14] libbpf: support shared umems between queues and devices Magnus Karlsson
2020-07-20 9:18 ` [PATCH bpf-next v3 13/14] samples/bpf: add new sample xsk_fwd.c Magnus Karlsson
2020-07-20 9:18 ` [PATCH bpf-next v3 14/14] xsk: documentation for XDP_SHARED_UMEM between queues and netdevs Magnus Karlsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202007210758.fYtjWEpY%lkp@intel.com \
--to=lkp@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=ast@kernel.org \
--cc=bjorn.topel@intel.com \
--cc=bpf@vger.kernel.org \
--cc=clang-built-linux@googlegroups.com \
--cc=daniel@iogearbox.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jonathan.lemon@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=magnus.karlsson@intel.com \
--cc=maximmi@mellanox.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.