* [PATCH] generic: add missing runtime checks for mknod/mkfifo
@ 2020-07-21 9:38 Vladimir Zapolskiy
0 siblings, 0 replies; only message in thread
From: Vladimir Zapolskiy @ 2020-07-21 9:38 UTC (permalink / raw)
To: Eryu Guan, Eric Sandeen; +Cc: fstests
Some generic tests explicitly run 'mknod' or 'mkfifo' command, however
the correspondent runtime check is missing, this results in a test
failure instead of selecting not to execute the test.
The change adds _require_mknod check to the next generic tests:
* generic/157
* generic/158
* generic/294
* generic/423
Signed-off-by: Vladimir Zapolskiy <vladimir@tuxera.com>
---
tests/generic/157 | 1 +
tests/generic/158 | 1 +
tests/generic/294 | 1 +
tests/generic/423 | 1 +
4 files changed, 4 insertions(+)
diff --git a/tests/generic/157 b/tests/generic/157
index 09b42bc9d8c8..cdd29af30dd1 100755
--- a/tests/generic/157
+++ b/tests/generic/157
@@ -31,6 +31,7 @@ _cleanup()
_supported_os Linux
_require_test_reflink
_require_scratch_reflink
+_require_mknod
rm -f $seqres.full
diff --git a/tests/generic/158 b/tests/generic/158
index 369aad8b2eb5..173090a3d40c 100755
--- a/tests/generic/158
+++ b/tests/generic/158
@@ -31,6 +31,7 @@ _cleanup()
_supported_os Linux
_require_test_dedupe
_require_scratch_dedupe
+_require_mknod
rm -f $seqres.full
diff --git a/tests/generic/294 b/tests/generic/294
index 32c89b039374..bc13185e937c 100755
--- a/tests/generic/294
+++ b/tests/generic/294
@@ -33,6 +33,7 @@ _supported_fs generic
_supported_os Linux
_require_scratch
_require_symlinks
+_require_mknod
rm -f $seqres.full
_scratch_mkfs > $seqres.full 2>&1 || _fail "Could not mkfs scratch device"
diff --git a/tests/generic/423 b/tests/generic/423
index 6db55fd6f757..fd538a1b029d 100755
--- a/tests/generic/423
+++ b/tests/generic/423
@@ -39,6 +39,7 @@ _require_test_program "stat_test"
_require_test_program "af_unix"
_require_statx
_require_symlinks
+_require_mknod
function check_stat () {
$here/src/stat_test $* || echo stat_test failed
--
2.25.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-07-21 9:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21 9:38 [PATCH] generic: add missing runtime checks for mknod/mkfifo Vladimir Zapolskiy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.