From: Jakub Kicinski <kuba@kernel.org>
To: Ioana Ciornei <ioana.ciornei@nxp.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 3/3] dpaa2-eth: add support for TBF offload
Date: Tue, 21 Jul 2020 12:31:08 -0700 [thread overview]
Message-ID: <20200721123108.25da923a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200721163825.9462-4-ioana.ciornei@nxp.com>
On Tue, 21 Jul 2020 19:38:25 +0300 Ioana Ciornei wrote:
> React to TC_SETUP_QDISC_TBF and configure the egress shaper as
> appropriate with the maximum rate and burst size requested by the user.
> TBF can only be offloaded on DPAA2 when it's the root qdisc, ie it's a
> per port shaper.
>
> Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Problems that Jesper run into make me wonder if we should always return
-EOPNOTSUPP as an error from drivers from the root Qdisc. Maybe that's
a larger problem, we already have drivers returning other errors.
next prev parent reply other threads:[~2020-07-21 19:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 16:38 [PATCH net-next 0/3] dpaa2-eth: add support for TBF offload Ioana Ciornei
2020-07-21 16:38 ` [PATCH net-next 1/3] dpaa2-eth: move the mqprio setup into a separate function Ioana Ciornei
2020-07-21 16:38 ` [PATCH net-next 2/3] dpaa2-eth: add API for Tx shaping Ioana Ciornei
2020-07-21 16:38 ` [PATCH net-next 3/3] dpaa2-eth: add support for TBF offload Ioana Ciornei
2020-07-21 19:31 ` Jakub Kicinski [this message]
2020-07-21 19:31 ` [PATCH net-next 0/3] " Jakub Kicinski
2020-07-21 23:24 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721123108.25da923a@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ioana.ciornei@nxp.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.