* [PATCH][next] phy: qualcomm: fix setting of tx_deamp_3_5db when device property read fails
@ 2020-07-21 15:06 ` Colin King
0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2020-07-21 15:06 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Kishon Vijay Abraham I, Vinod Koul,
Ansuel Smith, linux-arm-msm
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently when reading of the device property for "qcom,tx-deamp_3_5db"
fails the default is being assigned incorrectly to phy_dwc3->rx_eq. This
looks like a copy-n-paste error and in fact should be assigning the
default instead to phy_dwc3->tx_deamp_3_5db
Addresses-Coverity: ("Copy-paste error")
Fixes: ef19b117b834 ("phy: qualcomm: add qcom ipq806x dwc usb phy driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c b/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c
index a7241bf110d7..71f257b4a7f5 100644
--- a/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c
+++ b/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c
@@ -531,7 +531,7 @@ static int qcom_ipq806x_usb_phy_probe(struct platform_device *pdev)
if (device_property_read_u32(&pdev->dev, "qcom,tx-deamp_3_5db",
&phy_dwc3->tx_deamp_3_5db))
- phy_dwc3->rx_eq = SSPHY_TX_DEEMPH_3_5DB;
+ phy_dwc3->tx_deamp_3_5db = SSPHY_TX_DEEMPH_3_5DB;
if (device_property_read_u32(&pdev->dev, "qcom,mpll", &phy_dwc3->mpll))
phy_dwc3->mpll = SSPHY_MPLL_VALUE;
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH][next] phy: qualcomm: fix setting of tx_deamp_3_5db when device property read fails
@ 2020-07-21 15:06 ` Colin King
0 siblings, 0 replies; 4+ messages in thread
From: Colin King @ 2020-07-21 15:06 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Kishon Vijay Abraham I, Vinod Koul,
Ansuel Smith, linux-arm-msm
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently when reading of the device property for "qcom,tx-deamp_3_5db"
fails the default is being assigned incorrectly to phy_dwc3->rx_eq. This
looks like a copy-n-paste error and in fact should be assigning the
default instead to phy_dwc3->tx_deamp_3_5db
Addresses-Coverity: ("Copy-paste error")
Fixes: ef19b117b834 ("phy: qualcomm: add qcom ipq806x dwc usb phy driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c b/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c
index a7241bf110d7..71f257b4a7f5 100644
--- a/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c
+++ b/drivers/phy/qualcomm/phy-qcom-ipq806x-usb.c
@@ -531,7 +531,7 @@ static int qcom_ipq806x_usb_phy_probe(struct platform_device *pdev)
if (device_property_read_u32(&pdev->dev, "qcom,tx-deamp_3_5db",
&phy_dwc3->tx_deamp_3_5db))
- phy_dwc3->rx_eq = SSPHY_TX_DEEMPH_3_5DB;
+ phy_dwc3->tx_deamp_3_5db = SSPHY_TX_DEEMPH_3_5DB;
if (device_property_read_u32(&pdev->dev, "qcom,mpll", &phy_dwc3->mpll))
phy_dwc3->mpll = SSPHY_MPLL_VALUE;
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH][next] phy: qualcomm: fix setting of tx_deamp_3_5db when device property read fails
2020-07-21 15:06 ` Colin King
@ 2020-07-21 17:54 ` Vinod Koul
-1 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2020-07-21 17:42 UTC (permalink / raw)
To: Colin King
Cc: Andy Gross, Bjorn Andersson, Kishon Vijay Abraham I,
Ansuel Smith, linux-arm-msm, kernel-janitors, linux-kernel
On 21-07-20, 16:06, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently when reading of the device property for "qcom,tx-deamp_3_5db"
> fails the default is being assigned incorrectly to phy_dwc3->rx_eq. This
> looks like a copy-n-paste error and in fact should be assigning the
> default instead to phy_dwc3->tx_deamp_3_5db
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH][next] phy: qualcomm: fix setting of tx_deamp_3_5db when device property read fails
@ 2020-07-21 17:54 ` Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2020-07-21 17:54 UTC (permalink / raw)
To: Colin King
Cc: Andy Gross, Bjorn Andersson, Kishon Vijay Abraham I,
Ansuel Smith, linux-arm-msm, kernel-janitors, linux-kernel
On 21-07-20, 16:06, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Currently when reading of the device property for "qcom,tx-deamp_3_5db"
> fails the default is being assigned incorrectly to phy_dwc3->rx_eq. This
> looks like a copy-n-paste error and in fact should be assigning the
> default instead to phy_dwc3->tx_deamp_3_5db
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-21 17:54 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-21 15:06 [PATCH][next] phy: qualcomm: fix setting of tx_deamp_3_5db when device property read fails Colin King
2020-07-21 15:06 ` Colin King
2020-07-21 17:42 ` Vinod Koul
2020-07-21 17:54 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.