All of lore.kernel.org
 help / color / mirror / Atom feed
From: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
To: <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Cc: <nicolas.ferre@microchip.com>, <claudiu.beznea@microchip.com>,
	<davem@davemloft.net>, <kuba@kernel.org>, <andrew@lunn.ch>,
	<f.fainelli@gmail.com>, <robh+dt@kernel.org>,
	<alexandre.belloni@bootlin.com>,
	<ludovic.desroches@microchip.com>,
	"Codrin Ciubotariu" <codrin.ciubotariu@microchip.com>
Subject: [PATCH net-next v2 2/7] dt-bindings: net: macb: use an MDIO node as a container for PHY nodes
Date: Tue, 21 Jul 2020 20:13:11 +0300	[thread overview]
Message-ID: <20200721171316.1427582-3-codrin.ciubotariu@microchip.com> (raw)
In-Reply-To: <20200721171316.1427582-1-codrin.ciubotariu@microchip.com>

The MACB driver embeds an MDIO bus controller and for this reason there
was no need for an MDIO sub-node present to contain the PHY nodes. Adding
MDIO devies directly under an Ethernet node is deprecated, so an MDIO node
is included to contain of the PHY nodes (and other MDIO devices' nodes).

Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
---

Changes in v2:
 - patch renamed from "macb: bindings doc: use an MDIO node as a
   container for PHY nodes" to "dt-bindings: net: macb: use an MDIO
   node as a container for PHY nodes" 

 Documentation/devicetree/bindings/net/macb.txt | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
index 0b61a90f1592..88d5199c2279 100644
--- a/Documentation/devicetree/bindings/net/macb.txt
+++ b/Documentation/devicetree/bindings/net/macb.txt
@@ -32,6 +32,11 @@ Required properties:
 The MAC address will be determined using the optional properties
 defined in ethernet.txt.
 
+Optional subnodes:
+- mdio : specifies the MDIO bus in the MACB, used as a container for PHY nodes or other
+  nodes of devices present on the MDIO bus. Please see ethernet-phy.yaml in the same
+  directory for more details.
+
 Optional properties for PHY child node:
 - reset-gpios : Should specify the gpio for phy reset
 - magic-packet : If present, indicates that the hardware supports waking
@@ -48,8 +53,12 @@ Examples:
 		local-mac-address = [3a 0e 03 04 05 06];
 		clock-names = "pclk", "hclk", "tx_clk";
 		clocks = <&clkc 30>, <&clkc 30>, <&clkc 13>;
-		ethernet-phy@1 {
-			reg = <0x1>;
-			reset-gpios = <&pioE 6 1>;
+		mdio {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			ethernet-phy@1 {
+				reg = <0x1>;
+				reset-gpios = <&pioE 6 1>;
+			};
 		};
 	};
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
To: <netdev@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>
Cc: andrew@lunn.ch, alexandre.belloni@bootlin.com,
	f.fainelli@gmail.com, claudiu.beznea@microchip.com,
	ludovic.desroches@microchip.com, robh+dt@kernel.org,
	kuba@kernel.org,
	Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
	davem@davemloft.net
Subject: [PATCH net-next v2 2/7] dt-bindings: net: macb: use an MDIO node as a container for PHY nodes
Date: Tue, 21 Jul 2020 20:13:11 +0300	[thread overview]
Message-ID: <20200721171316.1427582-3-codrin.ciubotariu@microchip.com> (raw)
In-Reply-To: <20200721171316.1427582-1-codrin.ciubotariu@microchip.com>

The MACB driver embeds an MDIO bus controller and for this reason there
was no need for an MDIO sub-node present to contain the PHY nodes. Adding
MDIO devies directly under an Ethernet node is deprecated, so an MDIO node
is included to contain of the PHY nodes (and other MDIO devices' nodes).

Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
---

Changes in v2:
 - patch renamed from "macb: bindings doc: use an MDIO node as a
   container for PHY nodes" to "dt-bindings: net: macb: use an MDIO
   node as a container for PHY nodes" 

 Documentation/devicetree/bindings/net/macb.txt | 15 ++++++++++++---
 1 file changed, 12 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt
index 0b61a90f1592..88d5199c2279 100644
--- a/Documentation/devicetree/bindings/net/macb.txt
+++ b/Documentation/devicetree/bindings/net/macb.txt
@@ -32,6 +32,11 @@ Required properties:
 The MAC address will be determined using the optional properties
 defined in ethernet.txt.
 
+Optional subnodes:
+- mdio : specifies the MDIO bus in the MACB, used as a container for PHY nodes or other
+  nodes of devices present on the MDIO bus. Please see ethernet-phy.yaml in the same
+  directory for more details.
+
 Optional properties for PHY child node:
 - reset-gpios : Should specify the gpio for phy reset
 - magic-packet : If present, indicates that the hardware supports waking
@@ -48,8 +53,12 @@ Examples:
 		local-mac-address = [3a 0e 03 04 05 06];
 		clock-names = "pclk", "hclk", "tx_clk";
 		clocks = <&clkc 30>, <&clkc 30>, <&clkc 13>;
-		ethernet-phy@1 {
-			reg = <0x1>;
-			reset-gpios = <&pioE 6 1>;
+		mdio {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			ethernet-phy@1 {
+				reg = <0x1>;
+				reset-gpios = <&pioE 6 1>;
+			};
 		};
 	};
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2020-07-21 17:18 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21 17:13 [PATCH net-next v2 0/7] Add an MDIO sub-node under MACB Codrin Ciubotariu
2020-07-21 17:13 ` Codrin Ciubotariu
2020-07-21 17:13 ` [PATCH net-next v2 1/7] net: macb: use device-managed devm_mdiobus_alloc() Codrin Ciubotariu
2020-07-21 17:13   ` Codrin Ciubotariu
2020-07-23 18:55   ` Florian Fainelli
2020-07-23 18:55     ` Florian Fainelli
2020-07-21 17:13 ` Codrin Ciubotariu [this message]
2020-07-21 17:13   ` [PATCH net-next v2 2/7] dt-bindings: net: macb: use an MDIO node as a container for PHY nodes Codrin Ciubotariu
2020-07-23 17:51   ` Rob Herring
2020-07-23 17:51     ` Rob Herring
2020-07-23 18:56   ` Florian Fainelli
2020-07-23 18:56     ` Florian Fainelli
2020-07-21 17:13 ` [PATCH net-next v2 3/7] net: macb: parse PHY nodes found under an MDIO node Codrin Ciubotariu
2020-07-21 17:13   ` Codrin Ciubotariu
2020-07-23 18:59   ` Florian Fainelli
2020-07-23 18:59     ` Florian Fainelli
2020-07-23 22:08     ` Codrin.Ciubotariu
2020-07-23 22:08       ` Codrin.Ciubotariu
2020-07-23 22:33       ` Florian Fainelli
2020-07-23 22:33         ` Florian Fainelli
2020-07-24  7:28     ` Claudiu.Beznea
2020-07-24  7:28       ` Claudiu.Beznea
2020-07-21 17:13 ` [PATCH net-next v2 4/7] ARM: dts: at91: sama5d2: add an mdio sub-node to macb Codrin Ciubotariu
2020-07-21 17:13   ` Codrin Ciubotariu
2020-07-23 18:59   ` Florian Fainelli
2020-07-23 18:59     ` Florian Fainelli
2020-07-21 17:13 ` [PATCH net-next v2 5/7] ARM: dts: at91: sama5d3: " Codrin Ciubotariu
2020-07-21 17:13   ` Codrin Ciubotariu
2020-07-23 19:00   ` Florian Fainelli
2020-07-23 19:00     ` Florian Fainelli
2020-07-21 17:13 ` [PATCH net-next v2 6/7] ARM: dts: at91: sama5d4: " Codrin Ciubotariu
2020-07-21 17:13   ` Codrin Ciubotariu
2020-07-23 19:00   ` Florian Fainelli
2020-07-23 19:00     ` Florian Fainelli
2020-07-21 17:13 ` [PATCH net-next v2 7/7] ARM: dts: at91: sam9x60: " Codrin Ciubotariu
2020-07-21 17:13   ` Codrin Ciubotariu
2020-07-23 19:00   ` Florian Fainelli
2020-07-23 19:00     ` Florian Fainelli
2020-07-22 10:32 ` [PATCH net-next v2 0/7] Add an MDIO sub-node under MACB Claudiu.Beznea
2020-07-22 10:32   ` Claudiu.Beznea
2020-07-22 11:38   ` Codrin.Ciubotariu
2020-07-22 11:38     ` Codrin.Ciubotariu
2020-07-23  7:51     ` Claudiu.Beznea
2020-07-23  7:51       ` Claudiu.Beznea
2020-07-23 13:18       ` Codrin.Ciubotariu
2020-07-23 13:18         ` Codrin.Ciubotariu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200721171316.1427582-3-codrin.ciubotariu@microchip.com \
    --to=codrin.ciubotariu@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andrew@lunn.ch \
    --cc=claudiu.beznea@microchip.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.