From: Ram Pai <linuxram@us.ibm.com>
To: Laurent Dufour <ldufour@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
kvm-ppc@vger.kernel.org, mpe@ellerman.id.au, paulus@samba.org,
sukadev@linux.ibm.com, bauerman@linux.ibm.com,
bharata@linux.ibm.com, Paul Mackerras <paulus@ozlabs.org>
Subject: Re: [PATCH v2 1/2] KVM: PPC: Book3S HV: move kvmppc_svm_page_out up
Date: Tue, 21 Jul 2020 14:28:13 -0700 [thread overview]
Message-ID: <20200721212813.GF7339@oc0525413822.ibm.com> (raw)
In-Reply-To: <20200721104202.15727-2-ldufour@linux.ibm.com>
On Tue, Jul 21, 2020 at 12:42:01PM +0200, Laurent Dufour wrote:
> kvmppc_svm_page_out() will need to be called by kvmppc_uvmem_drop_pages()
> so move it upper in this file.
>
> Furthermore it will be interesting to call this function when already
> holding the kvm->arch.uvmem_lock, so prefix the original function with __
> and remove the locking in it, and introduce a wrapper which call that
> function with the lock held.
>
> There is no functional change.
Reviewed-by: Ram Pai <linuxram@us.ibm.com>
>
> Cc: Ram Pai <linuxram@us.ibm.com>
> Cc: Bharata B Rao <bharata@linux.ibm.com>
> Cc: Paul Mackerras <paulus@ozlabs.org>
> Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>
> ---
RP
WARNING: multiple messages have this Message-ID (diff)
From: Ram Pai <linuxram@us.ibm.com>
To: Laurent Dufour <ldufour@linux.ibm.com>
Cc: linux-kernel@vger.kernel.org, kvm-ppc@vger.kernel.org,
bharata@linux.ibm.com, paulus@samba.org, sukadev@linux.ibm.com,
linuxppc-dev@lists.ozlabs.org, bauerman@linux.ibm.com
Subject: Re: [PATCH v2 1/2] KVM: PPC: Book3S HV: move kvmppc_svm_page_out up
Date: Tue, 21 Jul 2020 14:28:13 -0700 [thread overview]
Message-ID: <20200721212813.GF7339@oc0525413822.ibm.com> (raw)
In-Reply-To: <20200721104202.15727-2-ldufour@linux.ibm.com>
On Tue, Jul 21, 2020 at 12:42:01PM +0200, Laurent Dufour wrote:
> kvmppc_svm_page_out() will need to be called by kvmppc_uvmem_drop_pages()
> so move it upper in this file.
>
> Furthermore it will be interesting to call this function when already
> holding the kvm->arch.uvmem_lock, so prefix the original function with __
> and remove the locking in it, and introduce a wrapper which call that
> function with the lock held.
>
> There is no functional change.
Reviewed-by: Ram Pai <linuxram@us.ibm.com>
>
> Cc: Ram Pai <linuxram@us.ibm.com>
> Cc: Bharata B Rao <bharata@linux.ibm.com>
> Cc: Paul Mackerras <paulus@ozlabs.org>
> Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>
> ---
RP
WARNING: multiple messages have this Message-ID (diff)
From: Ram Pai <linuxram@us.ibm.com>
To: Laurent Dufour <ldufour@linux.ibm.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org,
kvm-ppc@vger.kernel.org, mpe@ellerman.id.au, paulus@samba.org,
sukadev@linux.ibm.com, bauerman@linux.ibm.com,
bharata@linux.ibm.com, Paul Mackerras <paulus@ozlabs.org>
Subject: Re: [PATCH v2 1/2] KVM: PPC: Book3S HV: move kvmppc_svm_page_out up
Date: Tue, 21 Jul 2020 21:28:13 +0000 [thread overview]
Message-ID: <20200721212813.GF7339@oc0525413822.ibm.com> (raw)
In-Reply-To: <20200721104202.15727-2-ldufour@linux.ibm.com>
On Tue, Jul 21, 2020 at 12:42:01PM +0200, Laurent Dufour wrote:
> kvmppc_svm_page_out() will need to be called by kvmppc_uvmem_drop_pages()
> so move it upper in this file.
>
> Furthermore it will be interesting to call this function when already
> holding the kvm->arch.uvmem_lock, so prefix the original function with __
> and remove the locking in it, and introduce a wrapper which call that
> function with the lock held.
>
> There is no functional change.
Reviewed-by: Ram Pai <linuxram@us.ibm.com>
>
> Cc: Ram Pai <linuxram@us.ibm.com>
> Cc: Bharata B Rao <bharata@linux.ibm.com>
> Cc: Paul Mackerras <paulus@ozlabs.org>
> Signed-off-by: Laurent Dufour <ldufour@linux.ibm.com>
> ---
RP
next prev parent reply other threads:[~2020-07-21 21:28 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 10:42 [PATCH v2 0/2] Rework secure memslot dropping Laurent Dufour
2020-07-21 10:42 ` Laurent Dufour
2020-07-21 10:42 ` Laurent Dufour
2020-07-21 10:42 ` [PATCH v2 1/2] KVM: PPC: Book3S HV: move kvmppc_svm_page_out up Laurent Dufour
2020-07-21 10:42 ` Laurent Dufour
2020-07-21 10:42 ` Laurent Dufour
2020-07-21 21:28 ` Ram Pai [this message]
2020-07-21 21:28 ` Ram Pai
2020-07-21 21:28 ` Ram Pai
2020-07-21 10:42 ` [PATCH v2 2/2] KVM: PPC: Book3S HV: rework secure mem slot dropping Laurent Dufour
2020-07-21 10:42 ` Laurent Dufour
2020-07-21 10:42 ` Laurent Dufour
2020-07-21 21:37 ` Ram Pai
2020-07-21 21:37 ` Ram Pai
2020-07-21 21:37 ` Ram Pai
2020-07-22 7:18 ` Laurent Dufour
2020-07-22 7:18 ` Laurent Dufour
2020-07-22 7:18 ` Laurent Dufour
2020-07-23 3:36 ` Bharata B Rao
2020-07-23 3:48 ` Bharata B Rao
2020-07-23 3:36 ` Bharata B Rao
2020-07-23 12:32 ` Laurent Dufour
2020-07-23 12:32 ` Laurent Dufour
2020-07-23 12:32 ` Laurent Dufour
2020-07-23 14:06 ` Laurent Dufour
2020-07-23 14:06 ` Laurent Dufour
2020-07-27 19:24 [PATCH v2 0/2] Rework secure memslot dropping Ram Pai
2020-07-27 19:24 ` Ram Pai
2020-07-27 19:24 ` [PATCH v2 1/2] KVM: PPC: Book3S HV: move kvmppc_svm_page_out up Ram Pai
2020-07-27 19:24 ` Ram Pai
2020-07-27 19:24 ` [PATCH v2 2/2] KVM: PPC: Book3S HV: rework secure mem slot dropping Ram Pai
2020-07-27 19:24 ` Ram Pai
2020-07-28 5:52 ` [PATCH v2 0/2] Rework secure memslot dropping Paul Mackerras
2020-07-28 5:52 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200721212813.GF7339@oc0525413822.ibm.com \
--to=linuxram@us.ibm.com \
--cc=bauerman@linux.ibm.com \
--cc=bharata@linux.ibm.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@ozlabs.org \
--cc=paulus@samba.org \
--cc=sukadev@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.