[MPTCP] [PATCH net-next] mptcp: zero token hash at creation time.

[MPTCP] [PATCH net-next] mptcp: zero token hash at creation time.

[Paolo Abeni]

[-- Attachment #1: Type: text/plain, Size: 885 bytes --]

Otherwise the 'chain_len' filed will carry random values,
some token creation calls will fail due to excessive chain
length, causing unexpected fallback to TCP.

Fixes: 2c5ebd001d4f ("mptcp: refactor token container")
Reviewed-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>
Tested-by: Christoph Paasch <cpaasch(a)apple.com>
Signed-off-by: Paolo Abeni <pabeni(a)redhat.com>
---
 net/mptcp/token.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/mptcp/token.c b/net/mptcp/token.c
index b25b390dbbff..97cfc45bcc4f 100644
--- a/net/mptcp/token.c
+++ b/net/mptcp/token.c
@@ -368,7 +368,7 @@ void __init mptcp_token_init(void)
 					     sizeof(struct token_bucket),
 					     0,
 					     20,/* one slot per 1MB of memory */
-					     0,
+					     HASH_ZERO,
 					     NULL,
 					     &token_mask,
 					     0,
-- 
2.26.2

[PATCH net-next] mptcp: zero token hash at creation time.

[Paolo Abeni]

Otherwise the 'chain_len' filed will carry random values,
some token creation calls will fail due to excessive chain
length, causing unexpected fallback to TCP.

Fixes: 2c5ebd001d4f ("mptcp: refactor token container")
Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
Tested-by: Christoph Paasch <cpaasch@apple.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
---
 net/mptcp/token.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/mptcp/token.c b/net/mptcp/token.c
index b25b390dbbff..97cfc45bcc4f 100644
--- a/net/mptcp/token.c
+++ b/net/mptcp/token.c
@@ -368,7 +368,7 @@ void __init mptcp_token_init(void)
 					     sizeof(struct token_bucket),
 					     0,
 					     20,/* one slot per 1MB of memory */
-					     0,
+					     HASH_ZERO,
 					     NULL,
 					     &token_mask,
 					     0,
-- 
2.26.2

[MPTCP] Re: [PATCH net-next] mptcp: zero token hash at creation time.

[David Miller]

[-- Attachment #1: Type: text/plain, Size: 513 bytes --]

From: Paolo Abeni <pabeni(a)redhat.com>
Date: Wed, 22 Jul 2020 17:20:50 +0200

> Otherwise the 'chain_len' filed will carry random values,
> some token creation calls will fail due to excessive chain
> length, causing unexpected fallback to TCP.
> 
> Fixes: 2c5ebd001d4f ("mptcp: refactor token container")
> Reviewed-by: Mat Martineau <mathew.j.martineau(a)linux.intel.com>
> Tested-by: Christoph Paasch <cpaasch(a)apple.com>
> Signed-off-by: Paolo Abeni <pabeni(a)redhat.com>

Applied, thanks Paolo.

Re: [PATCH net-next] mptcp: zero token hash at creation time.

[David Miller]

From: Paolo Abeni <pabeni@redhat.com>
Date: Wed, 22 Jul 2020 17:20:50 +0200

> Otherwise the 'chain_len' filed will carry random values,
> some token creation calls will fail due to excessive chain
> length, causing unexpected fallback to TCP.
> 
> Fixes: 2c5ebd001d4f ("mptcp: refactor token container")
> Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
> Tested-by: Christoph Paasch <cpaasch@apple.com>
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>

Applied, thanks Paolo.