* [PATCH -next] soc: qcom: geni: Fix unused lable warning
@ 2020-07-22 2:06 YueHaibing
2020-07-22 4:29 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: YueHaibing @ 2020-07-22 2:06 UTC (permalink / raw)
To: agross, bjorn.andersson, akashast, mka
Cc: linux-arm-msm, linux-kernel, YueHaibing
If CONFIG_SERIAL_EARLYCON is not set, gcc warns this:
drivers/soc/qcom/qcom-geni-se.c: In function ‘geni_se_probe’:
drivers/soc/qcom/qcom-geni-se.c:914:1: warning: label ‘exit’ defined but not used [-Wunused-label]
exit:
^~~~
Fixes: 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect support to fix earlycon crash")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
drivers/soc/qcom/qcom-geni-se.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c
index 3413129d73ef..d0e4f520cff8 100644
--- a/drivers/soc/qcom/qcom-geni-se.c
+++ b/drivers/soc/qcom/qcom-geni-se.c
@@ -910,8 +910,8 @@ static int geni_se_probe(struct platform_device *pdev)
if (of_get_compatible_child(pdev->dev.of_node, "qcom,geni-debug-uart"))
earlycon_wrapper = wrapper;
of_node_put(pdev->dev.of_node);
-#endif
exit:
+#endif
dev_set_drvdata(dev, wrapper);
dev_dbg(dev, "GENI SE Driver probed\n");
return devm_of_platform_populate(dev);
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] soc: qcom: geni: Fix unused lable warning
2020-07-22 2:06 [PATCH -next] soc: qcom: geni: Fix unused lable warning YueHaibing
@ 2020-07-22 4:29 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2020-07-22 4:29 UTC (permalink / raw)
To: YueHaibing; +Cc: agross, akashast, mka, linux-arm-msm, linux-kernel
On Tue 21 Jul 19:06 PDT 2020, YueHaibing wrote:
> If CONFIG_SERIAL_EARLYCON is not set, gcc warns this:
>
> drivers/soc/qcom/qcom-geni-se.c: In function ‘geni_se_probe’:
> drivers/soc/qcom/qcom-geni-se.c:914:1: warning: label ‘exit’ defined but not used [-Wunused-label]
> exit:
> ^~~~
>
> Fixes: 048eb908a1f2 ("soc: qcom-geni-se: Add interconnect support to fix earlycon crash")
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
and applied.
Thanks,
Bjorn
> ---
> drivers/soc/qcom/qcom-geni-se.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c
> index 3413129d73ef..d0e4f520cff8 100644
> --- a/drivers/soc/qcom/qcom-geni-se.c
> +++ b/drivers/soc/qcom/qcom-geni-se.c
> @@ -910,8 +910,8 @@ static int geni_se_probe(struct platform_device *pdev)
> if (of_get_compatible_child(pdev->dev.of_node, "qcom,geni-debug-uart"))
> earlycon_wrapper = wrapper;
> of_node_put(pdev->dev.of_node);
> -#endif
> exit:
> +#endif
> dev_set_drvdata(dev, wrapper);
> dev_dbg(dev, "GENI SE Driver probed\n");
> return devm_of_platform_populate(dev);
> --
> 2.17.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-22 4:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-22 2:06 [PATCH -next] soc: qcom: geni: Fix unused lable warning YueHaibing
2020-07-22 4:29 ` Bjorn Andersson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.