From: Michael Tretter <m.tretter@pengutronix.de> To: Amit Sunil Dhamne <amit.sunil.dhamne@xilinx.com> Cc: mturquette@baylibre.com, sboyd@codeaurora.org, sboyd@kernel.org, michal.simek@xilinx.com, mark.rutland@arm.com, linux-clk@vger.kernel.org, rajanv@xilinx.com, jollys@xilinx.com, tejasp@xilinx.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rajan Vaja <rajan.vaja@xilinx.com>, Tejas Patel <tejas.patel@xilinx.com> Subject: Re: [PATCH v2 3/3] clk: zynqmp: Use firmware specific mux clock flags Date: Wed, 22 Jul 2020 15:28:38 +0200 [thread overview] Message-ID: <20200722132838.GE21264@pengutronix.de> (raw) In-Reply-To: <1595400932-303612-4-git-send-email-amit.sunil.dhamne@xilinx.com> On Tue, 21 Jul 2020 23:55:32 -0700, Amit Sunil Dhamne wrote: > From: Rajan Vaja <rajan.vaja@xilinx.com> > > Use ZynqMP specific mux clock flags instead of using CCF flags. > > Signed-off-by: Rajan Vaja <rajan.vaja@xilinx.com> > Signed-off-by: Tejas Patel <tejas.patel@xilinx.com> > Signed-off-by: Amit Sunil Dhamne <amit.sunil.dhamne@xilinx.com> > --- > drivers/clk/zynqmp/clk-mux-zynqmp.c | 14 +++++++++++++- > drivers/clk/zynqmp/clk-zynqmp.h | 8 ++++++++ > 2 files changed, 21 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/zynqmp/clk-mux-zynqmp.c b/drivers/clk/zynqmp/clk-mux-zynqmp.c > index 1dc17a0..10cf021 100644 > --- a/drivers/clk/zynqmp/clk-mux-zynqmp.c > +++ b/drivers/clk/zynqmp/clk-mux-zynqmp.c > @@ -125,7 +125,19 @@ struct clk_hw *zynqmp_clk_register_mux(const char *name, u32 clk_id, > > init.parent_names = parents; > init.num_parents = num_parents; > - mux->flags = nodes->type_flag; > + mux->flags = 0; > + mux->flags |= (nodes->type_flag & ZYNQMP_CLK_MUX_INDEX_ONE) ? > + CLK_MUX_INDEX_ONE : 0; > + mux->flags |= (nodes->type_flag & ZYNQMP_CLK_MUX_INDEX_BIT) ? > + CLK_MUX_INDEX_BIT : 0; > + mux->flags |= (nodes->type_flag & ZYNQMP_CLK_MUX_HIWORD_MASK) ? > + CLK_MUX_HIWORD_MASK : 0; > + mux->flags |= (nodes->type_flag & ZYNQMP_CLK_MUX_READ_ONLY) ? > + CLK_MUX_READ_ONLY : 0; > + mux->flags |= (nodes->type_flag & ZYNQMP_CLK_MUX_ROUND_CLOSEST) ? > + CLK_MUX_ROUND_CLOSEST : 0; > + mux->flags |= (nodes->type_flag & ZYNQMP_CLK_MUX_BIG_ENDIAN) ? > + CLK_MUX_BIG_ENDIAN : 0; Add a helper function for converting the flags. Michael > mux->hw.init = &init; > mux->clk_id = clk_id; > > diff --git a/drivers/clk/zynqmp/clk-zynqmp.h b/drivers/clk/zynqmp/clk-zynqmp.h > index ec33525..b1ac7e8 100644 > --- a/drivers/clk/zynqmp/clk-zynqmp.h > +++ b/drivers/clk/zynqmp/clk-zynqmp.h > @@ -41,6 +41,14 @@ > #define ZYNQMP_CLK_DIVIDER_READ_ONLY BIT(5) > #define ZYNQMP_CLK_DIVIDER_MAX_AT_ZERO BIT(6) > > +/* Type Flags for mux clock */ > +#define ZYNQMP_CLK_MUX_INDEX_ONE BIT(0) > +#define ZYNQMP_CLK_MUX_INDEX_BIT BIT(1) > +#define ZYNQMP_CLK_MUX_HIWORD_MASK BIT(2) > +#define ZYNQMP_CLK_MUX_READ_ONLY BIT(3) > +#define ZYNQMP_CLK_MUX_ROUND_CLOSEST BIT(4) > +#define ZYNQMP_CLK_MUX_BIG_ENDIAN BIT(5) > + > enum topology_type { > TYPE_INVALID, > TYPE_MUX, > -- > 2.7.4 > > This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately. > -- Pengutronix e.K. | Michael Tretter | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: Michael Tretter <m.tretter@pengutronix.de> To: Amit Sunil Dhamne <amit.sunil.dhamne@xilinx.com> Cc: mark.rutland@arm.com, Tejas Patel <tejas.patel@xilinx.com>, Rajan Vaja <rajan.vaja@xilinx.com>, tejasp@xilinx.com, sboyd@kernel.org, mturquette@baylibre.com, sboyd@codeaurora.org, michal.simek@xilinx.com, linux-kernel@vger.kernel.org, jollys@xilinx.com, rajanv@xilinx.com, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2 3/3] clk: zynqmp: Use firmware specific mux clock flags Date: Wed, 22 Jul 2020 15:28:38 +0200 [thread overview] Message-ID: <20200722132838.GE21264@pengutronix.de> (raw) In-Reply-To: <1595400932-303612-4-git-send-email-amit.sunil.dhamne@xilinx.com> On Tue, 21 Jul 2020 23:55:32 -0700, Amit Sunil Dhamne wrote: > From: Rajan Vaja <rajan.vaja@xilinx.com> > > Use ZynqMP specific mux clock flags instead of using CCF flags. > > Signed-off-by: Rajan Vaja <rajan.vaja@xilinx.com> > Signed-off-by: Tejas Patel <tejas.patel@xilinx.com> > Signed-off-by: Amit Sunil Dhamne <amit.sunil.dhamne@xilinx.com> > --- > drivers/clk/zynqmp/clk-mux-zynqmp.c | 14 +++++++++++++- > drivers/clk/zynqmp/clk-zynqmp.h | 8 ++++++++ > 2 files changed, 21 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/zynqmp/clk-mux-zynqmp.c b/drivers/clk/zynqmp/clk-mux-zynqmp.c > index 1dc17a0..10cf021 100644 > --- a/drivers/clk/zynqmp/clk-mux-zynqmp.c > +++ b/drivers/clk/zynqmp/clk-mux-zynqmp.c > @@ -125,7 +125,19 @@ struct clk_hw *zynqmp_clk_register_mux(const char *name, u32 clk_id, > > init.parent_names = parents; > init.num_parents = num_parents; > - mux->flags = nodes->type_flag; > + mux->flags = 0; > + mux->flags |= (nodes->type_flag & ZYNQMP_CLK_MUX_INDEX_ONE) ? > + CLK_MUX_INDEX_ONE : 0; > + mux->flags |= (nodes->type_flag & ZYNQMP_CLK_MUX_INDEX_BIT) ? > + CLK_MUX_INDEX_BIT : 0; > + mux->flags |= (nodes->type_flag & ZYNQMP_CLK_MUX_HIWORD_MASK) ? > + CLK_MUX_HIWORD_MASK : 0; > + mux->flags |= (nodes->type_flag & ZYNQMP_CLK_MUX_READ_ONLY) ? > + CLK_MUX_READ_ONLY : 0; > + mux->flags |= (nodes->type_flag & ZYNQMP_CLK_MUX_ROUND_CLOSEST) ? > + CLK_MUX_ROUND_CLOSEST : 0; > + mux->flags |= (nodes->type_flag & ZYNQMP_CLK_MUX_BIG_ENDIAN) ? > + CLK_MUX_BIG_ENDIAN : 0; Add a helper function for converting the flags. Michael > mux->hw.init = &init; > mux->clk_id = clk_id; > > diff --git a/drivers/clk/zynqmp/clk-zynqmp.h b/drivers/clk/zynqmp/clk-zynqmp.h > index ec33525..b1ac7e8 100644 > --- a/drivers/clk/zynqmp/clk-zynqmp.h > +++ b/drivers/clk/zynqmp/clk-zynqmp.h > @@ -41,6 +41,14 @@ > #define ZYNQMP_CLK_DIVIDER_READ_ONLY BIT(5) > #define ZYNQMP_CLK_DIVIDER_MAX_AT_ZERO BIT(6) > > +/* Type Flags for mux clock */ > +#define ZYNQMP_CLK_MUX_INDEX_ONE BIT(0) > +#define ZYNQMP_CLK_MUX_INDEX_BIT BIT(1) > +#define ZYNQMP_CLK_MUX_HIWORD_MASK BIT(2) > +#define ZYNQMP_CLK_MUX_READ_ONLY BIT(3) > +#define ZYNQMP_CLK_MUX_ROUND_CLOSEST BIT(4) > +#define ZYNQMP_CLK_MUX_BIG_ENDIAN BIT(5) > + > enum topology_type { > TYPE_INVALID, > TYPE_MUX, > -- > 2.7.4 > > This email and any attachments are intended for the sole use of the named recipient(s) and contain(s) confidential information that may be proprietary, privileged or copyrighted under applicable law. If you are not the intended recipient, do not read, copy, or forward this email message or any attachments. Delete this email message and any attachments immediately. > -- Pengutronix e.K. | Michael Tretter | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-22 13:28 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-22 6:55 [PATCH v2 0/3] clk: zynqmp: Add firmware specific clock flags Amit Sunil Dhamne 2020-07-22 6:55 ` Amit Sunil Dhamne 2020-07-22 6:55 ` [PATCH v2 1/3] clk: zynqmp: Use firmware specific common " Amit Sunil Dhamne 2020-07-22 6:55 ` Amit Sunil Dhamne 2020-07-22 13:22 ` Michael Tretter 2020-07-22 13:22 ` Michael Tretter 2020-07-23 23:46 ` Amit Sunil Dhamne 2020-07-23 23:46 ` Amit Sunil Dhamne 2020-07-22 6:55 ` [PATCH v2 2/3] clk: zynqmp: Use firmware specific divider " Amit Sunil Dhamne 2020-07-22 6:55 ` Amit Sunil Dhamne 2020-07-22 13:27 ` Michael Tretter 2020-07-22 13:27 ` Michael Tretter 2020-07-23 23:59 ` Amit Sunil Dhamne 2020-07-23 23:59 ` Amit Sunil Dhamne 2020-07-22 6:55 ` [PATCH v2 3/3] clk: zynqmp: Use firmware specific mux " Amit Sunil Dhamne 2020-07-22 6:55 ` Amit Sunil Dhamne 2020-07-22 13:28 ` Michael Tretter [this message] 2020-07-22 13:28 ` Michael Tretter 2020-07-23 22:35 ` [PATCH v2 0/3] clk: zynqmp: Add firmware specific " Stephen Boyd 2020-07-23 22:35 ` Stephen Boyd
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200722132838.GE21264@pengutronix.de \ --to=m.tretter@pengutronix.de \ --cc=amit.sunil.dhamne@xilinx.com \ --cc=jollys@xilinx.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=michal.simek@xilinx.com \ --cc=mturquette@baylibre.com \ --cc=rajan.vaja@xilinx.com \ --cc=rajanv@xilinx.com \ --cc=sboyd@codeaurora.org \ --cc=sboyd@kernel.org \ --cc=tejas.patel@xilinx.com \ --cc=tejasp@xilinx.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.