From: Joerg Roedel <joro@8bytes.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Hulk Robot <hulkci@huawei.com>,
Eric Auger <eric.auger@redhat.com>, Tom Murphy <murphyt7@tcd.ie>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] iommu: Make some functions static
Date: Wed, 22 Jul 2020 16:14:53 +0200 [thread overview]
Message-ID: <20200722141453.GL27672@8bytes.org> (raw)
In-Reply-To: <20200713142542.50294-1-weiyongjun1@huawei.com>
On Mon, Jul 13, 2020 at 10:25:42PM +0800, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/iommu/iommu.c:386:5: warning:
> symbol 'iommu_insert_resv_region' was not declared. Should it be static?
> drivers/iommu/iommu.c:2182:5: warning:
> symbol '__iommu_map' was not declared. Should it be static?
>
> Those functions are not used outside of iommu.c, so mark them static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/iommu/iommu.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Joerg Roedel <joro@8bytes.org>
To: Wei Yongjun <weiyongjun1@huawei.com>
Cc: Hulk Robot <hulkci@huawei.com>,
iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
Tom Murphy <murphyt7@tcd.ie>
Subject: Re: [PATCH -next] iommu: Make some functions static
Date: Wed, 22 Jul 2020 16:14:53 +0200 [thread overview]
Message-ID: <20200722141453.GL27672@8bytes.org> (raw)
In-Reply-To: <20200713142542.50294-1-weiyongjun1@huawei.com>
On Mon, Jul 13, 2020 at 10:25:42PM +0800, Wei Yongjun wrote:
> The sparse tool complains as follows:
>
> drivers/iommu/iommu.c:386:5: warning:
> symbol 'iommu_insert_resv_region' was not declared. Should it be static?
> drivers/iommu/iommu.c:2182:5: warning:
> symbol '__iommu_map' was not declared. Should it be static?
>
> Those functions are not used outside of iommu.c, so mark them static.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/iommu/iommu.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Applied, thanks.
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
next prev parent reply other threads:[~2020-07-22 14:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-13 14:25 [PATCH -next] iommu: Make some functions static Wei Yongjun
2020-07-13 14:25 ` Wei Yongjun
2020-07-22 14:14 ` Joerg Roedel [this message]
2020-07-22 14:14 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200722141453.GL27672@8bytes.org \
--to=joro@8bytes.org \
--cc=eric.auger@redhat.com \
--cc=hulkci@huawei.com \
--cc=iommu@lists.linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=murphyt7@tcd.ie \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.