All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Allen <john.allen@amd.com>
To: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	Bjorn Helgaas <bjorn@helgaas.com>,
	Vaibhav Gupta <vaibhav.varodek@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Tom Lendacky <thomas.lendacky@amd.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	linux-kernel@vger.kernel.org,
	linux-kernel-mentees@lists.linuxfoundation.org,
	Shuah Khan <skhan@linuxfoundation.org>,
	linux-crypto@vger.kernel.org
Subject: Re: [PATCH v2] crypto: ccp: sp-pci: use generic power management
Date: Wed, 22 Jul 2020 13:40:06 -0500	[thread overview]
Message-ID: <20200722184006.GA976732@mojo.amd.com> (raw)
In-Reply-To: <20200722093057.98551-1-vaibhavgupta40@gmail.com>

On Wed, Jul 22, 2020 at 03:00:58PM +0530, Vaibhav Gupta wrote:
> Drivers using legacy power management .suspen()/.resume() callbacks
> have to manage PCI states and device's PM states themselves. They also
> need to take care of standard configuration registers.
> 
> Switch to generic power management framework using a single
> "struct dev_pm_ops" variable to take the unnecessary load from the driver.
> This also avoids the need for the driver to directly call most of the PCI
> helper functions and device power state control functions as through
> the generic framework, PCI Core takes care of the necessary operations,
> and drivers are required to do only device-specific jobs.
> 
> Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>

Acked-by: John Allen <john.allen@amd.com>

WARNING: multiple messages have this Message-ID (diff)
From: John Allen <john.allen@amd.com>
To: Vaibhav Gupta <vaibhavgupta40@gmail.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	linux-kernel@vger.kernel.org, Bjorn Helgaas <helgaas@kernel.org>,
	linux-crypto@vger.kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
	linux-kernel-mentees@lists.linuxfoundation.org,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [Linux-kernel-mentees] [PATCH v2] crypto: ccp: sp-pci: use generic power management
Date: Wed, 22 Jul 2020 13:40:06 -0500	[thread overview]
Message-ID: <20200722184006.GA976732@mojo.amd.com> (raw)
In-Reply-To: <20200722093057.98551-1-vaibhavgupta40@gmail.com>

On Wed, Jul 22, 2020 at 03:00:58PM +0530, Vaibhav Gupta wrote:
> Drivers using legacy power management .suspen()/.resume() callbacks
> have to manage PCI states and device's PM states themselves. They also
> need to take care of standard configuration registers.
> 
> Switch to generic power management framework using a single
> "struct dev_pm_ops" variable to take the unnecessary load from the driver.
> This also avoids the need for the driver to directly call most of the PCI
> helper functions and device power state control functions as through
> the generic framework, PCI Core takes care of the necessary operations,
> and drivers are required to do only device-specific jobs.
> 
> Signed-off-by: Vaibhav Gupta <vaibhavgupta40@gmail.com>

Acked-by: John Allen <john.allen@amd.com>
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees

  reply	other threads:[~2020-07-22 18:40 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21 12:31 [PATCH v1] crypto: ccp: sp-pci: use generic power management Vaibhav Gupta
2020-07-21 12:31 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-21 12:34 ` Vaibhav Gupta
2020-07-21 12:34   ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-21 15:19 ` Tom Lendacky
2020-07-21 15:19   ` [Linux-kernel-mentees] " Tom Lendacky
2020-07-21 16:30   ` Vaibhav Gupta
2020-07-21 16:30     ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-21 17:15     ` Tom Lendacky
2020-07-21 17:15       ` [Linux-kernel-mentees] " Tom Lendacky
2020-07-21 17:43       ` Vaibhav Gupta
2020-07-21 17:43         ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-22  9:30       ` [PATCH v2] " Vaibhav Gupta
2020-07-22  9:30         ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-22 18:40         ` John Allen [this message]
2020-07-22 18:40           ` John Allen
2020-07-31 13:30         ` Herbert Xu
2020-07-31 13:30           ` [Linux-kernel-mentees] " Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200722184006.GA976732@mojo.amd.com \
    --to=john.allen@amd.com \
    --cc=bhelgaas@google.com \
    --cc=bjorn@helgaas.com \
    --cc=davem@davemloft.net \
    --cc=helgaas@kernel.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel-mentees@lists.linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=skhan@linuxfoundation.org \
    --cc=thomas.lendacky@amd.com \
    --cc=vaibhav.varodek@gmail.com \
    --cc=vaibhavgupta40@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.