* [igt-dev] [PATCH i-g-t v2] tests/kms_big_fb: Use igt_assert on bufmgr
@ 2020-07-22 13:47 Pankaj Bharadiya
2020-07-22 14:19 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_big_fb: Use igt_assert on bufmgr (rev2) Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Pankaj Bharadiya @ 2020-07-22 13:47 UTC (permalink / raw)
To: igt-dev, petri.latvala, pankaj.laxminarayan.bharadiya
NULL bufmgr pointer leads to SIGSEGV. Assert on NULL bufmgr so that
correct failure reason will get dumped in the stack trace.
Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>
---
* changes since v1:
- Make the error message more helpful [Petri]
tests/kms_big_fb.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c
index a754b2997..48caa5cd1 100644
--- a/tests/kms_big_fb.c
+++ b/tests/kms_big_fb.c
@@ -607,6 +607,7 @@ igt_main
{
igt_fixture {
drmModeResPtr res;
+ const struct intel_device_info *info;
data.drm_fd = drm_open_driver_master(DRIVER_INTEL);
@@ -649,6 +650,10 @@ igt_main
data.render_copy = igt_get_render_copyfunc(data.devid);
data.bufmgr = drm_intel_bufmgr_gem_init(data.drm_fd, 4096);
+ info = intel_get_device_info(data.devid);
+ igt_assert_f(data.bufmgr, "Update libdrm for %s support\n",
+ info->gen ? info->codename : "<unknown chipset>");
+
data.batch = intel_batchbuffer_alloc(data.bufmgr, data.devid);
}
--
2.23.0
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 6+ messages in thread* [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_big_fb: Use igt_assert on bufmgr (rev2) 2020-07-22 13:47 [igt-dev] [PATCH i-g-t v2] tests/kms_big_fb: Use igt_assert on bufmgr Pankaj Bharadiya @ 2020-07-22 14:19 ` Patchwork 2020-07-22 15:40 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork ` (2 subsequent siblings) 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2020-07-22 14:19 UTC (permalink / raw) To: Pankaj Bharadiya; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 7077 bytes --] == Series Details == Series: tests/kms_big_fb: Use igt_assert on bufmgr (rev2) URL : https://patchwork.freedesktop.org/series/79518/ State : success == Summary == CI Bug Log - changes from CI_DRM_8776 -> IGTPW_4789 ==================================================== Summary ------- **SUCCESS** No regressions found. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/index.html Known issues ------------ Here are the changes found in IGTPW_4789 that come from known issues: ### IGT changes ### #### Issues hit #### * igt@gem_flink_basic@basic: - fi-tgl-y: [PASS][1] -> [DMESG-WARN][2] ([i915#402]) +1 similar issue [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/fi-tgl-y/igt@gem_flink_basic@basic.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/fi-tgl-y/igt@gem_flink_basic@basic.html * igt@i915_pm_rpm@module-reload: - fi-bsw-n3050: [PASS][3] -> [DMESG-WARN][4] ([i915#1982]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/fi-bsw-n3050/igt@i915_pm_rpm@module-reload.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/fi-bsw-n3050/igt@i915_pm_rpm@module-reload.html * igt@kms_chamelium@dp-crc-fast: - fi-kbl-7500u: [PASS][5] -> [DMESG-WARN][6] ([i915#1982]) [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html - fi-icl-u2: [PASS][7] -> [FAIL][8] ([i915#262]) [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/fi-icl-u2/igt@kms_chamelium@dp-crc-fast.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/fi-icl-u2/igt@kms_chamelium@dp-crc-fast.html * igt@kms_frontbuffer_tracking@basic: - fi-tgl-y: [PASS][9] -> [DMESG-WARN][10] ([i915#1982]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/fi-tgl-y/igt@kms_frontbuffer_tracking@basic.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/fi-tgl-y/igt@kms_frontbuffer_tracking@basic.html #### Possible fixes #### * igt@debugfs_test@read_all_entries: - fi-kbl-soraka: [DMESG-WARN][11] ([i915#1982]) -> [PASS][12] [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/fi-kbl-soraka/igt@debugfs_test@read_all_entries.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/fi-kbl-soraka/igt@debugfs_test@read_all_entries.html * igt@gem_exec_suspend@basic-s3: - fi-tgl-u2: [FAIL][13] ([i915#1888]) -> [PASS][14] [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/fi-tgl-u2/igt@gem_exec_suspend@basic-s3.html * igt@i915_module_load@reload: - fi-apl-guc: [DMESG-WARN][15] ([i915#1635] / [i915#1982]) -> [PASS][16] +1 similar issue [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/fi-apl-guc/igt@i915_module_load@reload.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/fi-apl-guc/igt@i915_module_load@reload.html * igt@i915_pm_rpm@basic-pci-d3-state: - fi-byt-j1900: [DMESG-WARN][17] ([i915#1982]) -> [PASS][18] [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/fi-byt-j1900/igt@i915_pm_rpm@basic-pci-d3-state.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/fi-byt-j1900/igt@i915_pm_rpm@basic-pci-d3-state.html * igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2: - fi-skl-guc: [DMESG-WARN][19] ([i915#2203]) -> [PASS][20] [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/fi-skl-guc/igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/fi-skl-guc/igt@kms_flip@basic-flip-vs-wf_vblank@c-hdmi-a2.html * igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence: - fi-tgl-u2: [DMESG-WARN][21] ([i915#402]) -> [PASS][22] [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/fi-tgl-u2/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/fi-tgl-u2/igt@kms_pipe_crc_basic@read-crc-pipe-a-frame-sequence.html * igt@vgem_basic@setversion: - fi-tgl-y: [DMESG-WARN][23] ([i915#402]) -> [PASS][24] +1 similar issue [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/fi-tgl-y/igt@vgem_basic@setversion.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/fi-tgl-y/igt@vgem_basic@setversion.html #### Warnings #### * igt@i915_module_load@reload: - fi-tgl-u2: [DMESG-WARN][25] ([i915#1982]) -> [DMESG-WARN][26] ([i915#402]) [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/fi-tgl-u2/igt@i915_module_load@reload.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/fi-tgl-u2/igt@i915_module_load@reload.html * igt@kms_cursor_legacy@basic-flip-after-cursor-legacy: - fi-kbl-x1275: [DMESG-WARN][27] ([i915#62] / [i915#92]) -> [DMESG-WARN][28] ([i915#62] / [i915#92] / [i915#95]) +1 similar issue [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/fi-kbl-x1275/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html * igt@prime_vgem@basic-fence-flip: - fi-kbl-x1275: [DMESG-WARN][29] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][30] ([i915#62] / [i915#92]) +3 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/fi-kbl-x1275/igt@prime_vgem@basic-fence-flip.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/fi-kbl-x1275/igt@prime_vgem@basic-fence-flip.html [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635 [i915#1888]: https://gitlab.freedesktop.org/drm/intel/issues/1888 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2203]: https://gitlab.freedesktop.org/drm/intel/issues/2203 [i915#262]: https://gitlab.freedesktop.org/drm/intel/issues/262 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (47 -> 40) ------------------------------ Missing (7): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5744 -> IGTPW_4789 CI-20190529: 20190529 CI_DRM_8776: 74b7f6c16ef8b25eeced90397c82376071d3a12a @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_4789: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/index.html IGT_5744: 89ef04d90cf2b96c72820c1927034cf716ea37f7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/index.html [-- Attachment #1.2: Type: text/html, Size: 9089 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 6+ messages in thread
* [igt-dev] ✓ Fi.CI.IGT: success for tests/kms_big_fb: Use igt_assert on bufmgr (rev2) 2020-07-22 13:47 [igt-dev] [PATCH i-g-t v2] tests/kms_big_fb: Use igt_assert on bufmgr Pankaj Bharadiya 2020-07-22 14:19 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_big_fb: Use igt_assert on bufmgr (rev2) Patchwork @ 2020-07-22 15:40 ` Patchwork 2020-07-23 7:34 ` [igt-dev] [PATCH i-g-t v2] tests/kms_big_fb: Use igt_assert on bufmgr Petri Latvala 2020-07-23 12:14 ` Ville Syrjälä 3 siblings, 0 replies; 6+ messages in thread From: Patchwork @ 2020-07-22 15:40 UTC (permalink / raw) To: Pankaj Bharadiya; +Cc: igt-dev [-- Attachment #1.1: Type: text/plain, Size: 15255 bytes --] == Series Details == Series: tests/kms_big_fb: Use igt_assert on bufmgr (rev2) URL : https://patchwork.freedesktop.org/series/79518/ State : success == Summary == CI Bug Log - changes from CI_DRM_8776_full -> IGTPW_4789_full ==================================================== Summary ------- **WARNING** Minor unknown changes coming with IGTPW_4789_full need to be verified manually. If you think the reported changes have nothing to do with the changes introduced in IGTPW_4789_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI. External URL: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/index.html Possible new issues ------------------- Here are the unknown changes that may have been introduced in IGTPW_4789_full: ### IGT changes ### #### Warnings #### * igt@kms_cursor_legacy@cursorb-vs-flipb-varying-size: - shard-kbl: [SKIP][1] ([fdo#109271]) -> [INCOMPLETE][2] [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-kbl3/igt@kms_cursor_legacy@cursorb-vs-flipb-varying-size.html [2]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-kbl3/igt@kms_cursor_legacy@cursorb-vs-flipb-varying-size.html Known issues ------------ Here are the changes found in IGTPW_4789_full that come from known issues: ### IGT changes ### #### Issues hit #### * igt@i915_pm_rc6_residency@rc6-fence: - shard-hsw: [PASS][3] -> [WARN][4] ([i915#1519]) [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-hsw8/igt@i915_pm_rc6_residency@rc6-fence.html [4]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-hsw6/igt@i915_pm_rc6_residency@rc6-fence.html * igt@kms_big_fb@linear-64bpp-rotate-180: - shard-glk: [PASS][5] -> [DMESG-FAIL][6] ([i915#118] / [i915#95]) +1 similar issue [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-glk6/igt@kms_big_fb@linear-64bpp-rotate-180.html [6]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-glk8/igt@kms_big_fb@linear-64bpp-rotate-180.html * igt@kms_cursor_crc@pipe-a-cursor-suspend: - shard-kbl: [PASS][7] -> [DMESG-WARN][8] ([i915#180]) +3 similar issues [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-kbl4/igt@kms_cursor_crc@pipe-a-cursor-suspend.html [8]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-kbl3/igt@kms_cursor_crc@pipe-a-cursor-suspend.html * igt@kms_flip@flip-vs-suspend-interruptible@c-hdmi-a1: - shard-hsw: [PASS][9] -> [INCOMPLETE][10] ([i915#2055]) [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-hsw8/igt@kms_flip@flip-vs-suspend-interruptible@c-hdmi-a1.html [10]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-hsw1/igt@kms_flip@flip-vs-suspend-interruptible@c-hdmi-a1.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt: - shard-tglb: [PASS][11] -> [DMESG-WARN][12] ([i915#402]) +4 similar issues [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-tglb6/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt.html [12]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-tglb2/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-indfb-pgflip-blt.html * igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-blt: - shard-tglb: [PASS][13] -> [DMESG-WARN][14] ([i915#1982]) [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-tglb5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-blt.html [14]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-tglb7/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-spr-indfb-draw-blt.html * igt@kms_psr@psr2_sprite_plane_move: - shard-iclb: [PASS][15] -> [SKIP][16] ([fdo#109441]) +1 similar issue [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-iclb2/igt@kms_psr@psr2_sprite_plane_move.html [16]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-iclb6/igt@kms_psr@psr2_sprite_plane_move.html * igt@kms_setmode@basic-clone-single-crtc: - shard-hsw: [PASS][17] -> [TIMEOUT][18] ([i915#1958] / [i915#2119]) +1 similar issue [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-hsw2/igt@kms_setmode@basic-clone-single-crtc.html [18]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-hsw4/igt@kms_setmode@basic-clone-single-crtc.html * igt@kms_vblank@pipe-b-query-forked-busy: - shard-apl: [PASS][19] -> [DMESG-WARN][20] ([i915#1635] / [i915#1982]) [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-apl2/igt@kms_vblank@pipe-b-query-forked-busy.html [20]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-apl3/igt@kms_vblank@pipe-b-query-forked-busy.html * igt@perf_pmu@semaphore-busy@rcs0: - shard-kbl: [PASS][21] -> [FAIL][22] ([i915#1820]) [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-kbl4/igt@perf_pmu@semaphore-busy@rcs0.html [22]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-kbl6/igt@perf_pmu@semaphore-busy@rcs0.html #### Possible fixes #### * igt@gem_exec_reloc@basic-concurrent0: - shard-glk: [FAIL][23] ([i915#1930]) -> [PASS][24] [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-glk5/igt@gem_exec_reloc@basic-concurrent0.html [24]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-glk5/igt@gem_exec_reloc@basic-concurrent0.html * igt@gem_exec_whisper@basic-contexts-forked: - shard-snb: [TIMEOUT][25] ([i915#1958] / [i915#2119]) -> [PASS][26] [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-snb2/igt@gem_exec_whisper@basic-contexts-forked.html [26]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-snb5/igt@gem_exec_whisper@basic-contexts-forked.html - shard-hsw: [TIMEOUT][27] ([i915#1958] / [i915#2119]) -> [PASS][28] +1 similar issue [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-hsw2/igt@gem_exec_whisper@basic-contexts-forked.html [28]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-hsw4/igt@gem_exec_whisper@basic-contexts-forked.html - shard-glk: [TIMEOUT][29] ([i915#1958] / [i915#2119]) -> [PASS][30] +3 similar issues [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-glk8/igt@gem_exec_whisper@basic-contexts-forked.html [30]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-glk8/igt@gem_exec_whisper@basic-contexts-forked.html * igt@gem_exec_whisper@basic-queues: - shard-glk: [DMESG-WARN][31] ([i915#118] / [i915#95]) -> [PASS][32] +1 similar issue [31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-glk3/igt@gem_exec_whisper@basic-queues.html [32]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-glk6/igt@gem_exec_whisper@basic-queues.html * igt@i915_pm_dc@dc6-psr: - shard-iclb: [FAIL][33] ([i915#454]) -> [PASS][34] [33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-iclb8/igt@i915_pm_dc@dc6-psr.html [34]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-iclb4/igt@i915_pm_dc@dc6-psr.html * igt@kms_addfb_basic@bad-pitch-0: - shard-tglb: [DMESG-WARN][35] ([i915#402]) -> [PASS][36] +1 similar issue [35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-tglb6/igt@kms_addfb_basic@bad-pitch-0.html [36]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-tglb7/igt@kms_addfb_basic@bad-pitch-0.html * igt@kms_cursor_edge_walk@pipe-c-64x64-right-edge: - shard-glk: [DMESG-WARN][37] ([i915#1982]) -> [PASS][38] [37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-glk6/igt@kms_cursor_edge_walk@pipe-c-64x64-right-edge.html [38]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-glk1/igt@kms_cursor_edge_walk@pipe-c-64x64-right-edge.html * igt@kms_flip@flip-vs-suspend@c-dp1: - shard-kbl: [DMESG-WARN][39] ([i915#180]) -> [PASS][40] +6 similar issues [39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-kbl6/igt@kms_flip@flip-vs-suspend@c-dp1.html [40]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-kbl2/igt@kms_flip@flip-vs-suspend@c-dp1.html * igt@kms_flip_tiling@flip-changes-tiling-yf: - shard-kbl: [DMESG-WARN][41] ([i915#1982]) -> [PASS][42] [41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-kbl6/igt@kms_flip_tiling@flip-changes-tiling-yf.html [42]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-kbl6/igt@kms_flip_tiling@flip-changes-tiling-yf.html * igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack: - shard-tglb: [DMESG-WARN][43] ([i915#1982]) -> [PASS][44] +2 similar issues [43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-tglb7/igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack.html [44]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-tglb8/igt@kms_frontbuffer_tracking@fbc-1p-shrfb-fliptrack.html * igt@kms_psr2_su@page_flip: - shard-iclb: [SKIP][45] ([fdo#109642] / [fdo#111068]) -> [PASS][46] [45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-iclb8/igt@kms_psr2_su@page_flip.html [46]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-iclb2/igt@kms_psr2_su@page_flip.html * igt@kms_psr@psr2_primary_page_flip: - shard-iclb: [SKIP][47] ([fdo#109441]) -> [PASS][48] +3 similar issues [47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-iclb5/igt@kms_psr@psr2_primary_page_flip.html [48]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-iclb2/igt@kms_psr@psr2_primary_page_flip.html * igt@kms_setmode@basic: - shard-hsw: [FAIL][49] ([i915#31]) -> [PASS][50] [49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-hsw4/igt@kms_setmode@basic.html [50]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-hsw8/igt@kms_setmode@basic.html #### Warnings #### * igt@gem_exec_reloc@basic-concurrent16: - shard-snb: [TIMEOUT][51] ([i915#1958] / [i915#2119]) -> [FAIL][52] ([i915#1930]) [51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-snb2/igt@gem_exec_reloc@basic-concurrent16.html [52]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-snb1/igt@gem_exec_reloc@basic-concurrent16.html - shard-glk: [TIMEOUT][53] ([i915#1958] / [i915#2119]) -> [INCOMPLETE][54] ([i915#1958]) [53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-glk8/igt@gem_exec_reloc@basic-concurrent16.html [54]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-glk1/igt@gem_exec_reloc@basic-concurrent16.html * igt@gem_exec_schedule@preempt-hang: - shard-hsw: [TIMEOUT][55] ([i915#1958] / [i915#2119]) -> [SKIP][56] ([fdo#109271]) +2 similar issues [55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-hsw2/igt@gem_exec_schedule@preempt-hang.html [56]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-hsw4/igt@gem_exec_schedule@preempt-hang.html * igt@kms_color_chamelium@pipe-a-ctm-max: - shard-hsw: [TIMEOUT][57] ([i915#1958] / [i915#2119]) -> [SKIP][58] ([fdo#109271] / [fdo#111827]) [57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-hsw2/igt@kms_color_chamelium@pipe-a-ctm-max.html [58]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-hsw6/igt@kms_color_chamelium@pipe-a-ctm-max.html - shard-glk: [TIMEOUT][59] ([i915#1366] / [i915#1958] / [i915#2119]) -> [SKIP][60] ([fdo#109271] / [fdo#111827]) [59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-glk8/igt@kms_color_chamelium@pipe-a-ctm-max.html [60]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-glk9/igt@kms_color_chamelium@pipe-a-ctm-max.html - shard-snb: [TIMEOUT][61] ([i915#1958] / [i915#2119]) -> [SKIP][62] ([fdo#109271] / [fdo#111827]) [61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-snb2/igt@kms_color_chamelium@pipe-a-ctm-max.html [62]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-snb5/igt@kms_color_chamelium@pipe-a-ctm-max.html * igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled: - shard-snb: [TIMEOUT][63] ([i915#1958] / [i915#2119]) -> [SKIP][64] ([fdo#109271]) +3 similar issues [63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-snb2/igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled.html [64]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-snb2/igt@kms_draw_crc@draw-method-xrgb8888-render-ytiled.html * igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence: - shard-hsw: [SKIP][65] ([fdo#109271]) -> [TIMEOUT][66] ([i915#1958] / [i915#2119]) +1 similar issue [65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_8776/shard-hsw2/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html [66]: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/shard-hsw4/igt@kms_pipe_crc_basic@nonblocking-crc-pipe-d-frame-sequence.html [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271 [fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441 [fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642 [fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068 [fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827 [i915#118]: https://gitlab.freedesktop.org/drm/intel/issues/118 [i915#1366]: https://gitlab.freedesktop.org/drm/intel/issues/1366 [i915#1519]: https://gitlab.freedesktop.org/drm/intel/issues/1519 [i915#1635]: https://gitlab.freedesktop.org/drm/intel/issues/1635 [i915#180]: https://gitlab.freedesktop.org/drm/intel/issues/180 [i915#1820]: https://gitlab.freedesktop.org/drm/intel/issues/1820 [i915#1930]: https://gitlab.freedesktop.org/drm/intel/issues/1930 [i915#1958]: https://gitlab.freedesktop.org/drm/intel/issues/1958 [i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982 [i915#2055]: https://gitlab.freedesktop.org/drm/intel/issues/2055 [i915#2119]: https://gitlab.freedesktop.org/drm/intel/issues/2119 [i915#31]: https://gitlab.freedesktop.org/drm/intel/issues/31 [i915#402]: https://gitlab.freedesktop.org/drm/intel/issues/402 [i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454 [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 Participating hosts (11 -> 8) ------------------------------ Missing (3): pig-skl-6260u pig-glk-j5005 pig-icl-1065g7 Build changes ------------- * CI: CI-20190529 -> None * IGT: IGT_5744 -> IGTPW_4789 * Piglit: piglit_4509 -> None CI-20190529: 20190529 CI_DRM_8776: 74b7f6c16ef8b25eeced90397c82376071d3a12a @ git://anongit.freedesktop.org/gfx-ci/linux IGTPW_4789: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/index.html IGT_5744: 89ef04d90cf2b96c72820c1927034cf716ea37f7 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit == Logs == For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_4789/index.html [-- Attachment #1.2: Type: text/html, Size: 19342 bytes --] [-- Attachment #2: Type: text/plain, Size: 154 bytes --] _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] tests/kms_big_fb: Use igt_assert on bufmgr 2020-07-22 13:47 [igt-dev] [PATCH i-g-t v2] tests/kms_big_fb: Use igt_assert on bufmgr Pankaj Bharadiya 2020-07-22 14:19 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_big_fb: Use igt_assert on bufmgr (rev2) Patchwork 2020-07-22 15:40 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork @ 2020-07-23 7:34 ` Petri Latvala 2020-07-23 12:14 ` Ville Syrjälä 3 siblings, 0 replies; 6+ messages in thread From: Petri Latvala @ 2020-07-23 7:34 UTC (permalink / raw) To: Pankaj Bharadiya; +Cc: igt-dev On Wed, Jul 22, 2020 at 07:17:58PM +0530, Pankaj Bharadiya wrote: > NULL bufmgr pointer leads to SIGSEGV. Assert on NULL bufmgr so that > correct failure reason will get dumped in the stack trace. > > Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> Reviewed-by: Petri Latvala <petri.latvala@intel.com> (For the audience following along; libdrm_intel usage is still on its way out slowly but surely) _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] tests/kms_big_fb: Use igt_assert on bufmgr 2020-07-22 13:47 [igt-dev] [PATCH i-g-t v2] tests/kms_big_fb: Use igt_assert on bufmgr Pankaj Bharadiya ` (2 preceding siblings ...) 2020-07-23 7:34 ` [igt-dev] [PATCH i-g-t v2] tests/kms_big_fb: Use igt_assert on bufmgr Petri Latvala @ 2020-07-23 12:14 ` Ville Syrjälä 2020-07-28 12:18 ` Laxminarayan Bharadiya, Pankaj 3 siblings, 1 reply; 6+ messages in thread From: Ville Syrjälä @ 2020-07-23 12:14 UTC (permalink / raw) To: Pankaj Bharadiya; +Cc: igt-dev, petri.latvala On Wed, Jul 22, 2020 at 07:17:58PM +0530, Pankaj Bharadiya wrote: > NULL bufmgr pointer leads to SIGSEGV. Assert on NULL bufmgr so that > correct failure reason will get dumped in the stack trace. > > Signed-off-by: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com> > --- > * changes since v1: > - Make the error message more helpful [Petri] > > tests/kms_big_fb.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c > index a754b2997..48caa5cd1 100644 > --- a/tests/kms_big_fb.c > +++ b/tests/kms_big_fb.c > @@ -607,6 +607,7 @@ igt_main > { > igt_fixture { > drmModeResPtr res; > + const struct intel_device_info *info; > > data.drm_fd = drm_open_driver_master(DRIVER_INTEL); > > @@ -649,6 +650,10 @@ igt_main > data.render_copy = igt_get_render_copyfunc(data.devid); > > data.bufmgr = drm_intel_bufmgr_gem_init(data.drm_fd, 4096); > + info = intel_get_device_info(data.devid); > + igt_assert_f(data.bufmgr, "Update libdrm for %s support\n", > + info->gen ? info->codename : "<unknown chipset>"); > + How many individual tests are you going to have to patch like this? Would probably make more sense to plop this into some wrapper. > data.batch = intel_batchbuffer_alloc(data.bufmgr, data.devid); > } > > -- > 2.23.0 > > _______________________________________________ > igt-dev mailing list > igt-dev@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/igt-dev -- Ville Syrjälä Intel _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [igt-dev] [PATCH i-g-t v2] tests/kms_big_fb: Use igt_assert on bufmgr 2020-07-23 12:14 ` Ville Syrjälä @ 2020-07-28 12:18 ` Laxminarayan Bharadiya, Pankaj 0 siblings, 0 replies; 6+ messages in thread From: Laxminarayan Bharadiya, Pankaj @ 2020-07-28 12:18 UTC (permalink / raw) To: Ville Syrjälä; +Cc: igt-dev, Latvala, Petri > -----Original Message----- > From: Ville Syrjälä <ville.syrjala@linux.intel.com> > Sent: 23 July 2020 17:44 > To: Laxminarayan Bharadiya, Pankaj > <pankaj.laxminarayan.bharadiya@intel.com> > Cc: igt-dev@lists.freedesktop.org; Latvala, Petri <petri.latvala@intel.com> > Subject: Re: [igt-dev] [PATCH i-g-t v2] tests/kms_big_fb: Use igt_assert on > bufmgr > > On Wed, Jul 22, 2020 at 07:17:58PM +0530, Pankaj Bharadiya wrote: > > NULL bufmgr pointer leads to SIGSEGV. Assert on NULL bufmgr so that > > correct failure reason will get dumped in the stack trace. > > > > Signed-off-by: Pankaj Bharadiya > > <pankaj.laxminarayan.bharadiya@intel.com> > > --- > > * changes since v1: > > - Make the error message more helpful [Petri] > > > > tests/kms_big_fb.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/tests/kms_big_fb.c b/tests/kms_big_fb.c index > > a754b2997..48caa5cd1 100644 > > --- a/tests/kms_big_fb.c > > +++ b/tests/kms_big_fb.c > > @@ -607,6 +607,7 @@ igt_main > > { > > igt_fixture { > > drmModeResPtr res; > > + const struct intel_device_info *info; > > > > data.drm_fd = drm_open_driver_master(DRIVER_INTEL); > > > > @@ -649,6 +650,10 @@ igt_main > > data.render_copy = > igt_get_render_copyfunc(data.devid); > > > > data.bufmgr = drm_intel_bufmgr_gem_init(data.drm_fd, 4096); > > + info = intel_get_device_info(data.devid); > > + igt_assert_f(data.bufmgr, "Update libdrm for %s support\n", > > + info->gen ? info->codename : "<unknown chipset>"); > > + > > How many individual tests are you going to have to patch like this? > Would probably make more sense to plop this into some wrapper. Creating a wrapper only for drm_intel_bufmgr_gem_init() and leaving behind other drm_intel_bufmgr_* calls unwrapped will lead to confusion. Any suggestions here? Thanks, Pankaj > > > data.batch = intel_batchbuffer_alloc(data.bufmgr, data.devid); > > } > > > > -- > > 2.23.0 > > > > _______________________________________________ > > igt-dev mailing list > > igt-dev@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/igt-dev > > -- > Ville Syrjälä > Intel _______________________________________________ igt-dev mailing list igt-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/igt-dev ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-28 12:18 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-07-22 13:47 [igt-dev] [PATCH i-g-t v2] tests/kms_big_fb: Use igt_assert on bufmgr Pankaj Bharadiya 2020-07-22 14:19 ` [igt-dev] ✓ Fi.CI.BAT: success for tests/kms_big_fb: Use igt_assert on bufmgr (rev2) Patchwork 2020-07-22 15:40 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork 2020-07-23 7:34 ` [igt-dev] [PATCH i-g-t v2] tests/kms_big_fb: Use igt_assert on bufmgr Petri Latvala 2020-07-23 12:14 ` Ville Syrjälä 2020-07-28 12:18 ` Laxminarayan Bharadiya, Pankaj
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.