All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Kurt Kanzenbach <kurt@linutronix.de>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	netdev@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org,
	Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
	Richard Cochran <richardcochran@gmail.com>,
	Kamil Alkhouri <kamil.alkhouri@hs-offenburg.de>,
	ilias.apalodimas@linaro.org, Vladimir Oltean <olteanv@gmail.com>
Subject: Re: [PATCH v2 0/8] Hirschmann Hellcreek DSA driver
Date: Thu, 23 Jul 2020 09:33:39 -0700	[thread overview]
Message-ID: <20200723093339.7f2b6e27@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20200723081714.16005-1-kurt@linutronix.de>

On Thu, 23 Jul 2020 10:17:06 +0200 Kurt Kanzenbach wrote:
> Hi,
> 
> this series adds a DSA driver for the Hirschmann Hellcreek TSN switch
> IP. Characteristics of that IP:
> 
>  * Full duplex Ethernet interface at 100/1000 Mbps on three ports
>  * IEEE 802.1Q-compliant Ethernet Switch
>  * IEEE 802.1Qbv Time-Aware scheduling support
>  * IEEE 1588 and IEEE 802.1AS support
> 
> That IP is used e.g. in
> 
>  https://www.arrow.com/en/campaigns/arrow-kairos
> 
> Due to the hardware setup the switch driver is implemented using DSA. A special
> tagging protocol is leveraged. Furthermore, this driver supports PTP, hardware
> timestamping and TAPRIO offloading.
> 
> This work is part of the AccessTSN project: https://www.accesstsn.com/
> 
> The previous versions can be found here:
> 
>  * https://lkml.kernel.org/netdev/20200618064029.32168-1-kurt@linutronix.de/
>  * https://lkml.kernel.org/netdev/20200710113611.3398-1-kurt@linutronix.de/
> 
> This series depends on:
> 
>  * https://lkml.kernel.org/netdev/20200723074946.14253-1-kurt@linutronix.de/
> 
> Changes since v1:
> 
>  * Code simplifications (Florian Fainelli, Vladimir Oltean)
>  * Fix issues with hellcreek.yaml bindings (Florian Fainelli)
>  * Clear reserved field in ptp v2 event messages (Richard Cochran)
>  * Make use of generic ptp parsing function (Richard Cochran, Vladimir Oltean)
>  * Fix Kconfig (Florian Fainelli)
>  * Add tags (Florian Fainelli, Rob Herring, Richard Cochran) 
> 
> I didn't change the bridge/tagging setup, as I didn't find a better way to do it.

Appears not to build:

drivers/net/dsa/hirschmann/hellcreek_hwtstamp.c: In function ‘hellcreek_get_reserved_field’:
drivers/net/dsa/hirschmann/hellcreek_hwtstamp.c:177:24: error: invalid use of undefined type ‘const struct ptp_header’
  177 |  return be32_to_cpu(hdr->reserved2);
      |                        ^~

  parent reply	other threads:[~2020-07-23 16:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-23  8:17 [PATCH v2 0/8] Hirschmann Hellcreek DSA driver Kurt Kanzenbach
2020-07-23  8:17 ` [PATCH v2 1/8] net: dsa: Add tag handling for Hirschmann Hellcreek switches Kurt Kanzenbach
2020-07-23  8:17 ` [PATCH v2 2/8] net: dsa: Add DSA driver " Kurt Kanzenbach
2020-07-23  8:17 ` [PATCH v2 3/8] net: dsa: hellcreek: Add PTP clock support Kurt Kanzenbach
2020-07-23  8:17 ` [PATCH v2 4/8] net: dsa: hellcreek: Add support for hardware timestamping Kurt Kanzenbach
2020-07-24  2:34   ` kernel test robot
2020-07-24  2:34     ` kernel test robot
2020-07-23  8:17 ` [PATCH v2 5/8] net: dsa: hellcreek: Add TAPRIO offloading support Kurt Kanzenbach
2020-07-23  8:17 ` [PATCH v2 6/8] net: dsa: hellcreek: Add PTP status LEDs Kurt Kanzenbach
2020-07-23  8:17 ` [PATCH v2 7/8] dt-bindings: Add vendor prefix for Hirschmann Kurt Kanzenbach
2020-07-23  8:17 ` [PATCH v2 8/8] dt-bindings: net: dsa: Add documentation for Hellcreek switches Kurt Kanzenbach
2020-07-23 20:37   ` Rob Herring
2020-07-23 16:33 ` Jakub Kicinski [this message]
2020-07-24  6:04   ` [PATCH v2 0/8] Hirschmann Hellcreek DSA driver Kurt Kanzenbach
2020-07-24 23:47     ` David Miller
2020-07-25  7:02       ` Kurt Kanzenbach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200723093339.7f2b6e27@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=andrew@lunn.ch \
    --cc=bigeasy@linutronix.de \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=f.fainelli@gmail.com \
    --cc=ilias.apalodimas@linaro.org \
    --cc=kamil.alkhouri@hs-offenburg.de \
    --cc=kurt@linutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=richardcochran@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.