* [PATCH] mfd: max14577: remove redundant initialization of variable current_bits
@ 2020-07-23 16:15 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2020-07-23 16:15 UTC (permalink / raw)
To: Chanwoo Choi, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, Lee Jones
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable current_bits is being initialized with a value that is
never read and it is being updated later with a new value. The
initialization is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/mfd/max14577.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c
index fd8864cafd25..be185e9d5f16 100644
--- a/drivers/mfd/max14577.c
+++ b/drivers/mfd/max14577.c
@@ -61,7 +61,7 @@ EXPORT_SYMBOL_GPL(maxim_charger_currents);
int maxim_charger_calc_reg_current(const struct maxim_charger_current *limits,
unsigned int min_ua, unsigned int max_ua, u8 *dst)
{
- unsigned int current_bits = 0xf;
+ unsigned int current_bits;
if (min_ua > max_ua)
return -EINVAL;
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH] mfd: max14577: remove redundant initialization of variable current_bits
@ 2020-07-23 16:15 ` Colin King
0 siblings, 0 replies; 6+ messages in thread
From: Colin King @ 2020-07-23 16:15 UTC (permalink / raw)
To: Chanwoo Choi, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz, Lee Jones
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The variable current_bits is being initialized with a value that is
never read and it is being updated later with a new value. The
initialization is redundant and can be removed.
Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/mfd/max14577.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c
index fd8864cafd25..be185e9d5f16 100644
--- a/drivers/mfd/max14577.c
+++ b/drivers/mfd/max14577.c
@@ -61,7 +61,7 @@ EXPORT_SYMBOL_GPL(maxim_charger_currents);
int maxim_charger_calc_reg_current(const struct maxim_charger_current *limits,
unsigned int min_ua, unsigned int max_ua, u8 *dst)
{
- unsigned int current_bits = 0xf;
+ unsigned int current_bits;
if (min_ua > max_ua)
return -EINVAL;
--
2.27.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] mfd: max14577: remove redundant initialization of variable current_bits
2020-07-23 16:15 ` Colin King
@ 2020-07-23 16:18 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-07-23 16:18 UTC (permalink / raw)
To: Colin King
Cc: Chanwoo Choi, Bartlomiej Zolnierkiewicz, Lee Jones,
kernel-janitors, linux-kernel
On Thu, Jul 23, 2020 at 05:15:41PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable current_bits is being initialized with a value that is
> never read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/mfd/max14577.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mfd: max14577: remove redundant initialization of variable current_bits
@ 2020-07-23 16:18 ` Krzysztof Kozlowski
0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2020-07-23 16:18 UTC (permalink / raw)
To: Colin King
Cc: Chanwoo Choi, Bartlomiej Zolnierkiewicz, Lee Jones,
kernel-janitors, linux-kernel
On Thu, Jul 23, 2020 at 05:15:41PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable current_bits is being initialized with a value that is
> never read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/mfd/max14577.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mfd: max14577: remove redundant initialization of variable current_bits
2020-07-23 16:15 ` Colin King
@ 2020-07-23 17:21 ` Lee Jones
-1 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2020-07-23 17:21 UTC (permalink / raw)
To: Colin King
Cc: Chanwoo Choi, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz,
kernel-janitors, linux-kernel
On Thu, 23 Jul 2020, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable current_bits is being initialized with a value that is
> never read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/mfd/max14577.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] mfd: max14577: remove redundant initialization of variable current_bits
@ 2020-07-23 17:21 ` Lee Jones
0 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2020-07-23 17:21 UTC (permalink / raw)
To: Colin King
Cc: Chanwoo Choi, Krzysztof Kozlowski, Bartlomiej Zolnierkiewicz,
kernel-janitors, linux-kernel
On Thu, 23 Jul 2020, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> The variable current_bits is being initialized with a value that is
> never read and it is being updated later with a new value. The
> initialization is redundant and can be removed.
>
> Addresses-Coverity: ("Unused value")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/mfd/max14577.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied, thanks.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-23 17:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-23 16:15 [PATCH] mfd: max14577: remove redundant initialization of variable current_bits Colin King
2020-07-23 16:15 ` Colin King
2020-07-23 16:18 ` Krzysztof Kozlowski
2020-07-23 16:18 ` Krzysztof Kozlowski
2020-07-23 17:21 ` Lee Jones
2020-07-23 17:21 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.