From: Stephan Gerhold <stephan@gerhold.net>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Cheng-Yi Chiang <cychiang@chromium.org>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Taniya Das <tdas@codeaurora.org>,
Rohit kumar <rohitkr@codeaurora.org>,
Banajit Goswami <bgoswami@codeaurora.org>,
Patrick Lai <plai@codeaurora.org>, Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
dianders@chromium.org, dgreid@chromium.org, tzungbi@chromium.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
alsa-devel@alsa-project.org, Ajit Pandey <ajitp@codeaurora.org>
Subject: Re: [PATCH v2 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration
Date: Thu, 23 Jul 2020 20:44:36 +0200 [thread overview]
Message-ID: <20200723184432.GA321518@gerhold.net> (raw)
In-Reply-To: <ce029818-5082-643b-ff63-25aafea3de6c@linaro.org>
On Wed, Jul 22, 2020 at 10:25:14AM +0100, Srinivas Kandagatla wrote:
> > +static int sc7180_parse_of(struct snd_soc_card *card)
> > +{
>
> This code is getting duplicated in various places like apq8016_sbc_parse_of,
> it will be nice to common this up, if possible!
>
FYI, I started work on making apq8016_sbc use qcom_snd_parse_of()
a while ago already, but didn't find the time to finish it up.
I have now sent it, this should make it possible to use the common
qcom_snd_parse_of() function in this driver as well.
See: https://lore.kernel.org/alsa-devel/20200723183904.321040-1-stephan@gerhold.net/
Stephan
WARNING: multiple messages have this Message-ID (diff)
From: Stephan Gerhold <stephan@gerhold.net>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Taniya Das <tdas@codeaurora.org>,
devicetree@vger.kernel.org, tzungbi@chromium.org,
Banajit Goswami <bgoswami@codeaurora.org>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-arm-msm@vger.kernel.org, Patrick Lai <plai@codeaurora.org>,
Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mark Brown <broonie@kernel.org>,
Rohit kumar <rohitkr@codeaurora.org>,
Andy Gross <agross@kernel.org>,
dianders@chromium.org, Ajit Pandey <ajitp@codeaurora.org>,
dgreid@chromium.org, linux-arm-kernel@lists.infradead.org,
Cheng-Yi Chiang <cychiang@chromium.org>
Subject: Re: [PATCH v2 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration
Date: Thu, 23 Jul 2020 20:44:36 +0200 [thread overview]
Message-ID: <20200723184432.GA321518@gerhold.net> (raw)
In-Reply-To: <ce029818-5082-643b-ff63-25aafea3de6c@linaro.org>
On Wed, Jul 22, 2020 at 10:25:14AM +0100, Srinivas Kandagatla wrote:
> > +static int sc7180_parse_of(struct snd_soc_card *card)
> > +{
>
> This code is getting duplicated in various places like apq8016_sbc_parse_of,
> it will be nice to common this up, if possible!
>
FYI, I started work on making apq8016_sbc use qcom_snd_parse_of()
a while ago already, but didn't find the time to finish it up.
I have now sent it, this should make it possible to use the common
qcom_snd_parse_of() function in this driver as well.
See: https://lore.kernel.org/alsa-devel/20200723183904.321040-1-stephan@gerhold.net/
Stephan
WARNING: multiple messages have this Message-ID (diff)
From: Stephan Gerhold <stephan@gerhold.net>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Cc: Taniya Das <tdas@codeaurora.org>,
devicetree@vger.kernel.org, tzungbi@chromium.org,
Banajit Goswami <bgoswami@codeaurora.org>,
alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-arm-msm@vger.kernel.org, Patrick Lai <plai@codeaurora.org>,
Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Mark Brown <broonie@kernel.org>,
Rohit kumar <rohitkr@codeaurora.org>,
Andy Gross <agross@kernel.org>,
dianders@chromium.org, Ajit Pandey <ajitp@codeaurora.org>,
dgreid@chromium.org, Jaroslav Kysela <perex@perex.cz>,
linux-arm-kernel@lists.infradead.org,
Cheng-Yi Chiang <cychiang@chromium.org>
Subject: Re: [PATCH v2 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration
Date: Thu, 23 Jul 2020 20:44:36 +0200 [thread overview]
Message-ID: <20200723184432.GA321518@gerhold.net> (raw)
In-Reply-To: <ce029818-5082-643b-ff63-25aafea3de6c@linaro.org>
On Wed, Jul 22, 2020 at 10:25:14AM +0100, Srinivas Kandagatla wrote:
> > +static int sc7180_parse_of(struct snd_soc_card *card)
> > +{
>
> This code is getting duplicated in various places like apq8016_sbc_parse_of,
> it will be nice to common this up, if possible!
>
FYI, I started work on making apq8016_sbc use qcom_snd_parse_of()
a while ago already, but didn't find the time to finish it up.
I have now sent it, this should make it possible to use the common
qcom_snd_parse_of() function in this driver as well.
See: https://lore.kernel.org/alsa-devel/20200723183904.321040-1-stephan@gerhold.net/
Stephan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-23 18:45 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 10:44 [PATCH v2 0/2] Add documentation and machine driver for SC7180 sound card Cheng-Yi Chiang
2020-07-21 10:44 ` Cheng-Yi Chiang
2020-07-21 10:44 ` Cheng-Yi Chiang
2020-07-21 10:44 ` [PATCH v2 1/2] ASoC: qcom: dt-bindings: Add sc7180 machine bindings Cheng-Yi Chiang
2020-07-21 10:44 ` Cheng-Yi Chiang
2020-07-21 10:44 ` Cheng-Yi Chiang
2020-07-22 9:25 ` Srinivas Kandagatla
2020-07-22 9:25 ` Srinivas Kandagatla
2020-07-22 9:25 ` Srinivas Kandagatla
2020-07-31 8:55 ` Cheng-yi Chiang
2020-07-31 8:55 ` Cheng-yi Chiang
2020-07-31 8:55 ` Cheng-yi Chiang
2020-07-21 10:44 ` [PATCH v2 2/2] ASoC: qcom: sc7180: Add machine driver for sound card registration Cheng-Yi Chiang
2020-07-21 10:44 ` Cheng-Yi Chiang
2020-07-21 10:44 ` Cheng-Yi Chiang
2020-07-21 18:34 ` kernel test robot
2020-07-21 18:34 ` kernel test robot
2020-07-22 3:15 ` Tzung-Bi Shih
2020-07-22 3:15 ` Tzung-Bi Shih
2020-07-22 3:15 ` Tzung-Bi Shih
2020-07-31 8:55 ` Cheng-yi Chiang
2020-07-31 8:55 ` Cheng-yi Chiang
2020-07-31 8:55 ` Cheng-yi Chiang
2020-07-22 9:25 ` Srinivas Kandagatla
2020-07-22 9:25 ` Srinivas Kandagatla
2020-07-22 9:25 ` Srinivas Kandagatla
2020-07-23 18:44 ` Stephan Gerhold [this message]
2020-07-23 18:44 ` Stephan Gerhold
2020-07-23 18:44 ` Stephan Gerhold
2020-07-31 8:55 ` Cheng-yi Chiang
2020-07-31 8:55 ` Cheng-yi Chiang
2020-07-31 8:55 ` Cheng-yi Chiang
2020-07-31 8:55 ` Cheng-yi Chiang
2020-07-31 8:55 ` Cheng-yi Chiang
2020-07-31 8:55 ` Cheng-yi Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200723184432.GA321518@gerhold.net \
--to=stephan@gerhold.net \
--cc=agross@kernel.org \
--cc=ajitp@codeaurora.org \
--cc=alsa-devel@alsa-project.org \
--cc=bgoswami@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=broonie@kernel.org \
--cc=cychiang@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dgreid@chromium.org \
--cc=dianders@chromium.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=plai@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=rohitkr@codeaurora.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tdas@codeaurora.org \
--cc=tiwai@suse.com \
--cc=tzungbi@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.