* [PATCH] drm: bridge: adv7511: Add missing bridge type
@ 2020-07-23 10:45 ` Vinod Koul
0 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2020-07-23 10:45 UTC (permalink / raw)
To: Sam Ravnborg, Laurent Pinchart
Cc: linux-arm-msm, Bjorn Andersson, Vinod Koul, Andrzej Hajda,
Neil Armstrong, Jonas Karlman, Jernej Skrabec, David Airlie,
Daniel Vetter, Bogdan Togorean, Tomi Valkeinen, Rob Clark,
Wolfram Sang, dri-devel, linux-kernel
Add bridge type as DRM_MODE_CONNECTOR_HDMIA
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
I found this when testing Dragon-board 410c which uses this bridge
[ 6.671913] msm 1a00000.mdss: [drm:msm_dsi_manager_ext_bridge_init [msm]] *ERROR* drm_bridge_connector_init failed: -22
[ 6.678879] msm 1a00000.mdss: [drm:msm_dsi_modeset_init [msm]] *ERROR* failed to create dsi connector: -19
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index f45cdca9cce5..a0d392c338da 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -1283,6 +1283,7 @@ static int adv7511_probe(struct i2c_client *i2c, const struct i2c_device_id *id)
adv7511->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID
| DRM_BRIDGE_OP_HPD;
adv7511->bridge.of_node = dev->of_node;
+ adv7511->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
drm_bridge_add(&adv7511->bridge);
--
2.26.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] drm: bridge: adv7511: Add missing bridge type
@ 2020-07-23 10:45 ` Vinod Koul
0 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2020-07-23 10:45 UTC (permalink / raw)
To: Sam Ravnborg, Laurent Pinchart
Cc: Rob Clark, Jernej Skrabec, Neil Armstrong, David Airlie,
linux-arm-msm, Jonas Karlman, Wolfram Sang, linux-kernel,
dri-devel, Bjorn Andersson, Andrzej Hajda, Vinod Koul,
Tomi Valkeinen, Bogdan Togorean
Add bridge type as DRM_MODE_CONNECTOR_HDMIA
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
I found this when testing Dragon-board 410c which uses this bridge
[ 6.671913] msm 1a00000.mdss: [drm:msm_dsi_manager_ext_bridge_init [msm]] *ERROR* drm_bridge_connector_init failed: -22
[ 6.678879] msm 1a00000.mdss: [drm:msm_dsi_modeset_init [msm]] *ERROR* failed to create dsi connector: -19
drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
index f45cdca9cce5..a0d392c338da 100644
--- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
+++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
@@ -1283,6 +1283,7 @@ static int adv7511_probe(struct i2c_client *i2c, const struct i2c_device_id *id)
adv7511->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID
| DRM_BRIDGE_OP_HPD;
adv7511->bridge.of_node = dev->of_node;
+ adv7511->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
drm_bridge_add(&adv7511->bridge);
--
2.26.2
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: bridge: adv7511: Add missing bridge type
2020-07-23 10:45 ` Vinod Koul
@ 2020-07-24 1:30 ` Laurent Pinchart
-1 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2020-07-24 1:30 UTC (permalink / raw)
To: Vinod Koul
Cc: Sam Ravnborg, linux-arm-msm, Bjorn Andersson, Andrzej Hajda,
Neil Armstrong, Jonas Karlman, Jernej Skrabec, David Airlie,
Daniel Vetter, Bogdan Togorean, Tomi Valkeinen, Rob Clark,
Wolfram Sang, dri-devel, linux-kernel
Hi Vinod,
Thank you for the patch.
On Thu, Jul 23, 2020 at 04:15:23PM +0530, Vinod Koul wrote:
> Add bridge type as DRM_MODE_CONNECTOR_HDMIA
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
This has already been submitted: https://lore.kernel.org/dri-devel/20200720124228.12552-1-laurentiu.palcu@oss.nxp.com/
> ---
>
> I found this when testing Dragon-board 410c which uses this bridge
> [ 6.671913] msm 1a00000.mdss: [drm:msm_dsi_manager_ext_bridge_init [msm]] *ERROR* drm_bridge_connector_init failed: -22
> [ 6.678879] msm 1a00000.mdss: [drm:msm_dsi_modeset_init [msm]] *ERROR* failed to create dsi connector: -19
>
> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> index f45cdca9cce5..a0d392c338da 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> @@ -1283,6 +1283,7 @@ static int adv7511_probe(struct i2c_client *i2c, const struct i2c_device_id *id)
> adv7511->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID
> | DRM_BRIDGE_OP_HPD;
> adv7511->bridge.of_node = dev->of_node;
> + adv7511->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
>
> drm_bridge_add(&adv7511->bridge);
>
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: bridge: adv7511: Add missing bridge type
@ 2020-07-24 1:30 ` Laurent Pinchart
0 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2020-07-24 1:30 UTC (permalink / raw)
To: Vinod Koul
Cc: Rob Clark, Jernej Skrabec, Jonas Karlman, David Airlie,
linux-arm-msm, Neil Armstrong, Wolfram Sang, linux-kernel,
dri-devel, Bjorn Andersson, Andrzej Hajda, Tomi Valkeinen,
Bogdan Togorean, Sam Ravnborg
Hi Vinod,
Thank you for the patch.
On Thu, Jul 23, 2020 at 04:15:23PM +0530, Vinod Koul wrote:
> Add bridge type as DRM_MODE_CONNECTOR_HDMIA
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
This has already been submitted: https://lore.kernel.org/dri-devel/20200720124228.12552-1-laurentiu.palcu@oss.nxp.com/
> ---
>
> I found this when testing Dragon-board 410c which uses this bridge
> [ 6.671913] msm 1a00000.mdss: [drm:msm_dsi_manager_ext_bridge_init [msm]] *ERROR* drm_bridge_connector_init failed: -22
> [ 6.678879] msm 1a00000.mdss: [drm:msm_dsi_modeset_init [msm]] *ERROR* failed to create dsi connector: -19
>
> drivers/gpu/drm/bridge/adv7511/adv7511_drv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> index f45cdca9cce5..a0d392c338da 100644
> --- a/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> +++ b/drivers/gpu/drm/bridge/adv7511/adv7511_drv.c
> @@ -1283,6 +1283,7 @@ static int adv7511_probe(struct i2c_client *i2c, const struct i2c_device_id *id)
> adv7511->bridge.ops = DRM_BRIDGE_OP_DETECT | DRM_BRIDGE_OP_EDID
> | DRM_BRIDGE_OP_HPD;
> adv7511->bridge.of_node = dev->of_node;
> + adv7511->bridge.type = DRM_MODE_CONNECTOR_HDMIA;
>
> drm_bridge_add(&adv7511->bridge);
>
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: bridge: adv7511: Add missing bridge type
2020-07-24 1:30 ` Laurent Pinchart
@ 2020-07-24 4:23 ` Vinod Koul
-1 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2020-07-24 4:23 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Sam Ravnborg, linux-arm-msm, Bjorn Andersson, Andrzej Hajda,
Neil Armstrong, Jonas Karlman, Jernej Skrabec, David Airlie,
Daniel Vetter, Bogdan Togorean, Tomi Valkeinen, Rob Clark,
Wolfram Sang, dri-devel, linux-kernel
On 24-07-20, 04:30, Laurent Pinchart wrote:
> Hi Vinod,
>
> Thank you for the patch.
>
> On Thu, Jul 23, 2020 at 04:15:23PM +0530, Vinod Koul wrote:
> > Add bridge type as DRM_MODE_CONNECTOR_HDMIA
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
>
> This has already been submitted: https://lore.kernel.org/dri-devel/20200720124228.12552-1-laurentiu.palcu@oss.nxp.com/
OKay lets drop this one then
--
~Vinod
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] drm: bridge: adv7511: Add missing bridge type
@ 2020-07-24 4:23 ` Vinod Koul
0 siblings, 0 replies; 6+ messages in thread
From: Vinod Koul @ 2020-07-24 4:23 UTC (permalink / raw)
To: Laurent Pinchart
Cc: Rob Clark, Jernej Skrabec, Jonas Karlman, David Airlie,
linux-arm-msm, Neil Armstrong, Wolfram Sang, linux-kernel,
dri-devel, Bjorn Andersson, Andrzej Hajda, Tomi Valkeinen,
Bogdan Togorean, Sam Ravnborg
On 24-07-20, 04:30, Laurent Pinchart wrote:
> Hi Vinod,
>
> Thank you for the patch.
>
> On Thu, Jul 23, 2020 at 04:15:23PM +0530, Vinod Koul wrote:
> > Add bridge type as DRM_MODE_CONNECTOR_HDMIA
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
>
> This has already been submitted: https://lore.kernel.org/dri-devel/20200720124228.12552-1-laurentiu.palcu@oss.nxp.com/
OKay lets drop this one then
--
~Vinod
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-24 4:23 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-23 10:45 [PATCH] drm: bridge: adv7511: Add missing bridge type Vinod Koul
2020-07-23 10:45 ` Vinod Koul
2020-07-24 1:30 ` Laurent Pinchart
2020-07-24 1:30 ` Laurent Pinchart
2020-07-24 4:23 ` Vinod Koul
2020-07-24 4:23 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.