From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> To: Ard Biesheuvel <ardb@kernel.org> Cc: Catalin Marinas <catalin.marinas@arm.com>, Kefeng Wang <wangkefeng.wang@huawei.com>, Paul Mackerras <paulus@samba.org>, Zong Li <zong.li@sifive.com>, Andi Kleen <ak@linux.intel.com>, Paul Burton <paulburton@kernel.org>, Vincent Whitchurch <vincent.whitchurch@axis.com>, Christophe Leroy <christophe.leroy@csgroup.eu>, Petr Mladek <pmladek@suse.com>, Brian Gerst <brgerst@gmail.com>, Andy Lutomirski <luto@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Jiri Kosina <jkosina@suse.cz>, Anup Patel <anup.patel@wdc.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Philipp Rudo <prudo@linux.ibm.com>, Torsten Duwe <duwe@lst.de>, Masami Hiramatsu <mhiramat@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, Mark Rutland <mark.rutland@arm.com>, "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, Vincent Chen <deanbo422@gmail.com>, Omar Sandoval <osandov@fb.com>, "open list:S390" <linux-s390@vger.kernel.org>, Joe Lawrence <joe.lawrence@redhat.com>, Helge Deller <deller@gmx.de>, John Fastabend <john.fastabend@gmail.com>, Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>, Yonghong Song <yhs@fb.com>, Iurii Zaikin <yzaikin@google.com>, Andrii Nakryiko <andriin@fb.com>, Thomas Huth <thuth@redhat.com>, Vasily Gorbik <gor@linux.ibm.com>, "moderated list:ARM PORT" <linux-arm-kernel@lists.infradead.org>, Daniel Axtens <dja@axtens.net>, Damien Le Moal <damien.lemoal@wdc.com>, Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>, Josh Poimboeuf <jpoimboe@redhat.com>, Heiko Carstens <heiko.carstens@de.ibm.com>, Alexei Starovoitov <ast@kernel.org>, Atish Patra <atish.patra@wdc.com>, Will Deacon <will@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, Masahiro Yamada <masahiroy@kernel.org>, Nayna Jain <nayna@linux.ibm.com>, Ley Foon Tan <ley.foon.tan@intel.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Sami Tolvanen <samitolvanen@google.com>, "Naveen N. Rao" <naveen.n.rao@linux.ibm.com>, Mao Han <han_mao@c-sky.com>, Marco Elver <elver@google.com>, Steven Rostedt <rostedt@goodmis.org>, Babu Moger <Babu.Moger@amd.com>, Borislav Petkov <bp@alien8.de>, Greentime Hu <green.hu@gmail.com>, Ben Dooks <ben-linux@fluff.org>, Guan Xuetao <gxt@pku.edu.cn>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, "open list:PARISC ARCHITECTURE" <linux-parisc@vger.kernel.org>, Jessica Yu <jeyu@kernel.org>, "open list:BPF JIT for MIPS 32-BIT AND 64-BIT" <bpf@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>, Thiago Jung Bauermann <bauerman@linux.ibm.com>, Peter Zijlstra <peterz@infradead.org>, David Howells <dhowells@redhat.com>, Amit Daniel Kachhap <amit.kachhap@arm.com>, Sandipan Das <sandipan@linux.ibm.com>, "H. Peter Anvin" <hpa@zytor.com>, "open list:SPARC + UltraSPARC sparc/sparc64" <sparclinux@vger.kernel.org>, "open list:RISC-V ARCHITECTURE" <linux-riscv@lists.infradead.org>, Miroslav Benes <mbenes@suse.cz>, Jiri Olsa <jolsa@redhat.com>, Tiezhu Yang <yangtiezhu@loongson.cn>, Vincenzo Frascino <vincenzo.frascino@arm.com>, Anders Roxell <anders.roxell@linaro.org>, Sven Schnelle <svens@stackframe.org>, "maintainer:X86 ARCHITECTURE 32-BIT AND 64-BIT" <x86@kernel.org>, Russell King <linux@armlinux.org.uk>, Mike Rapoport <rppt@linux.ibm.com>, Ingo Molnar <mingo@redhat.com>, Albert Ou <aou@eecs.berkeley.edu>, "Paul E. McKenney" <paulmck@kernel.org>, Paul Walmsley <paul.walmsley@sifive.com>, KP Singh <kpsingh@chromium.org>, Dmitry Vyukov <dvyukov@google.com>, Nick Hu <nickhu@andestech.com>, "open list:BPF JIT for MIPS 32-BIT AND 64-BIT" <netdev@vger.kernel.org>, "open list:MIPS" <linux-mips@vger.kernel.org>, Palmer Dabbelt <palmer@dabbelt.com>, "open list:LINUX FOR POWERPC 32-BIT AND 64-BIT" <linuxppc-dev@lists.ozlabs.org> Subject: Re: [PATCH v2 1/3] module: Rename module_alloc() to text_alloc() and move to kernel proper Date: Fri, 24 Jul 2020 10:36:21 +0300 [thread overview] Message-ID: <20200724073621.GC1872662@linux.intel.com> (raw) In-Reply-To: <CAMj1kXGJhqC+asc6JUNeEkRsHYTzNQVe4-65vKqigbW03gO9Jg@mail.gmail.com> On Thu, Jul 23, 2020 at 03:42:09PM +0300, Ard Biesheuvel wrote: > On Thu, 23 Jul 2020 at 04:52, Jarkko Sakkinen > <jarkko.sakkinen@linux.intel.com> wrote: > > > > On Thu, Jul 16, 2020 at 06:49:09PM +0200, Christophe Leroy wrote: > > > Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> a écrit : > > > > > > > Rename module_alloc() to text_alloc() and module_memfree() to > > > > text_memfree(), and move them to kernel/text.c, which is unconditionally > > > > compiled to the kernel proper. This allows kprobes, ftrace and bpf to > > > > allocate space for executable code without requiring to compile the modules > > > > support (CONFIG_MODULES=y) in. > > > > > > You are not changing enough in powerpc to have this work. > > > On powerpc 32 bits (6xx), when STRICT_KERNEL_RWX is selected, the vmalloc > > > space is set to NX (no exec) at segment level (ie by 256Mbytes zone) unless > > > CONFIG_MODULES is selected. > > > > > > Christophe > > > > This has been deduced down to: > > > > https://lore.kernel.org/lkml/20200717030422.679972-1-jarkko.sakkinen@linux.intel.com/ > > > > I.e. not intruding PPC anymore :-) > > > > Ok, so after the elaborate discussion we had between Jessica, Russell, > Peter, Will, Mark, you and myself, where we pointed out that > a) a single text_alloc() abstraction for bpf, kprobes and ftrace does > not fit other architectures very well, and > b) that module_alloc() is not suitable as a default to base text_alloc() on, In the latest iteration (v5) it is conditionally available only if arch defines and fallback has been removed. > you went ahead and implemented that anyway, but only cc'ing Peter, > akpm, Masami and the mm list this time? No problems with that. Actually each patch gets everything that get_maintainer.pl gives with a cc cmd script, not just the ones explicitly listed in the patch. Should I explicitly CC you to the next version? I'm happy to grow the list when requested. > Sorry, but that is not how it works. Once people get pulled into a > discussion, you cannot dismiss them or their feedback like that and go > off and do your own thing anyway. Generic features like this are > tricky to get right, and it will likely take many iterations and input > from many different people. Sure. I'm not expecting this move quickly. I don't think I've at least purposely done that. As you said it's tricky to get this right. /Jarkko _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> To: Ard Biesheuvel <ardb@kernel.org> Cc: Catalin Marinas <catalin.marinas@arm.com>, Kefeng Wang <wangkefeng.wang@huawei.com>, Paul Mackerras <paulus@samba.org>, Zong Li <zong.li@sifive.com>, Andi Kleen <ak@linux.intel.com>, Paul Burton <paulburton@kernel.org>, Vincent Whitchurch <vincent.whitchurch@axis.com>, Petr Mladek <pmladek@suse.com>, Brian Gerst <brgerst@gmail.com>, Andy Lutomirski <luto@kernel.org>, Thomas Gleixner <tglx@linutronix.de>, Jiri Kosina <jkosina@suse.cz>, Anup Patel <anup.patel@wdc.com>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Philipp Rudo <prudo@linux.ibm.com>, Torsten Duwe <duwe@lst.de>, Masami Hiramatsu <mhiramat@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, Mark Rutland <mark.rutland@arm.com>, "James E.J. Bottomley" <James.Bottomley@hansenpartnership.com>, Vincent Chen <deanbo422@gmail.com>, Omar Sandoval <osandov@fb.com>, "open list:S390" <linux-s390@vger.kernel.org>, Joe Lawrence <joe.lawrence@redhat.com>, Helge Deller <deller@gmx.de>, John Fastabend <john.fastabend@gmail.com>, Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>, Yonghong Song <yhs@fb.com>, Iurii Zaikin <yzaikin@google.com>, Andrii Nakryiko <andriin@fb.com>, Thomas Huth <thuth@redhat.com>, Vasily Gorbik <gor@linux.ibm.com>, "moderated list:ARM PORT" <linux-arm-kernel@lists.infradead.org>, Daniel Axtens <dja@axtens.net>, Damien Le Moal <damien.lemoal@wdc.com>, Martin KaFai Lau <kafai@fb.com>, Song Liu <songliubraving@fb.com>, Josh Poimboeuf <jpoimboe@redhat.com>, Heiko Carstens <heiko.carstens@de.ibm.com>, Alexei Starovoitov <ast@kernel.org>, Atish Patra <atish.patra@wdc.com>, Will Deacon <will@kernel.org>, Daniel Borkmann <daniel@iogearbox.net>, Masahiro Yamada <masahiroy@kernel.org>, Nayna Jain <nayna@linux.ibm.com>, Ley Foon Tan <ley.foon.tan@intel.com>, Christian Borntraeger <borntraeger@de.ibm.com>, Sami Tolvanen <samitolvanen@google.com>, "Naveen N. Rao" <naveen.n.rao@linux.ibm.com>, Mao Han <han_mao@c-sky.com>, Marco Elver <elver@google.com>, Steven Rostedt <rostedt@goodmis.org>, Babu Moger <Babu.Moger@amd.com>, Borislav Petkov <bp@alien8.de>, Greentime Hu <green.hu@gmail.com>, Ben Dooks <ben-linux@fluff.org>, Guan Xuetao <gxt@pku.edu.cn>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, "open list:PARISC ARCHITECTURE" <linux-parisc@vger.kernel.org>, Jessica Yu <jeyu@kernel.org>, "open list:BPF JIT for MIPS 32-BIT AND 64-BIT" <bpf@vger.kernel.org>, "David S. Miller" <davem@davemloft.net>, Thiago Jung Bauermann <bauerman@linux.ibm.com>, Peter Zijlstra <peterz@infradead.org>, David Howells <dhowells@redhat.com>, Amit Daniel Kachhap <amit.kachhap@arm.com>, Sandipan Das <sandipan@linux.ibm.com>, "H. Peter Anvin" <hpa@zytor.com>, "open list:SPARC + UltraSPARC sparc/sparc64" <sparclinux@vger.kernel.org>, "open list:RISC-V ARCHITECTURE" <linux-riscv@lists.infradead.org>, Miroslav Benes <mbenes@suse.cz>, Jiri Olsa <jolsa@redhat.com>, Tiezhu Yang <yangtiezhu@loongson.cn>, Vincenzo Frascino <vincenzo.frascino@arm.com>, Anders Roxell <anders.roxell@linaro.org>, Sven Schnelle <svens@stackframe.org>, "maintainer:X86 ARCHITECTURE 32-BIT AND 64-BIT" <x86@kernel.org>, Russell King <linux@armlinux.org.uk>, Mike Rapoport <rppt@linux.ibm.com>, Ingo Molnar <mingo@redhat.com>, Albert Ou <aou@eecs.berkeley.edu>, "Paul E. McKenney" <paulmck@kernel.org>, Paul Walmsley <paul.walmsley@sifive.com>, KP Singh <kpsingh@chromium.org>, Dmitry Vyukov <dvyukov@google.com>, Nick Hu <nickhu@andestech.com>, "open list:BPF JIT for MIPS 32-BIT AND 64-BIT" <netdev@vger.kernel.org>, "open list:MIPS" <linux-mips@vger.kernel.org>, Palmer Dabbelt <palmer@dabbelt.com>, "open list:LINUX FOR POWERPC 32-BIT AND 64-BIT" <linuxppc-dev@lists.ozlabs.org> Subject: Re: [PATCH v2 1/3] module: Rename module_alloc() to text_alloc() and move to kernel proper Date: Fri, 24 Jul 2020 10:36:21 +0300 [thread overview] Message-ID: <20200724073621.GC1872662@linux.intel.com> (raw) In-Reply-To: <CAMj1kXGJhqC+asc6JUNeEkRsHYTzNQVe4-65vKqigbW03gO9Jg@mail.gmail.com> On Thu, Jul 23, 2020 at 03:42:09PM +0300, Ard Biesheuvel wrote: > On Thu, 23 Jul 2020 at 04:52, Jarkko Sakkinen > <jarkko.sakkinen@linux.intel.com> wrote: > > > > On Thu, Jul 16, 2020 at 06:49:09PM +0200, Christophe Leroy wrote: > > > Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com> a écrit : > > > > > > > Rename module_alloc() to text_alloc() and module_memfree() to > > > > text_memfree(), and move them to kernel/text.c, which is unconditionally > > > > compiled to the kernel proper. This allows kprobes, ftrace and bpf to > > > > allocate space for executable code without requiring to compile the modules > > > > support (CONFIG_MODULES=y) in. > > > > > > You are not changing enough in powerpc to have this work. > > > On powerpc 32 bits (6xx), when STRICT_KERNEL_RWX is selected, the vmalloc > > > space is set to NX (no exec) at segment level (ie by 256Mbytes zone) unless > > > CONFIG_MODULES is selected. > > > > > > Christophe > > > > This has been deduced down to: > > > > https://lore.kernel.org/lkml/20200717030422.679972-1-jarkko.sakkinen@linux.intel.com/ > > > > I.e. not intruding PPC anymore :-) > > > > Ok, so after the elaborate discussion we had between Jessica, Russell, > Peter, Will, Mark, you and myself, where we pointed out that > a) a single text_alloc() abstraction for bpf, kprobes and ftrace does > not fit other architectures very well, and > b) that module_alloc() is not suitable as a default to base text_alloc() on, In the latest iteration (v5) it is conditionally available only if arch defines and fallback has been removed. > you went ahead and implemented that anyway, but only cc'ing Peter, > akpm, Masami and the mm list this time? No problems with that. Actually each patch gets everything that get_maintainer.pl gives with a cc cmd script, not just the ones explicitly listed in the patch. Should I explicitly CC you to the next version? I'm happy to grow the list when requested. > Sorry, but that is not how it works. Once people get pulled into a > discussion, you cannot dismiss them or their feedback like that and go > off and do your own thing anyway. Generic features like this are > tricky to get right, and it will likely take many iterations and input > from many different people. Sure. I'm not expecting this move quickly. I don't think I've at least purposely done that. As you said it's tricky to get this right. /Jarkko
next prev parent reply other threads:[~2020-07-24 7:37 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-14 9:45 [PATCH v2 0/3] kprobes: Remove MODULE dependency Jarkko Sakkinen 2020-07-14 9:45 ` Jarkko Sakkinen 2020-07-14 9:45 ` [PATCH v2 1/3] module: Rename module_alloc() to text_alloc() and move to kernel proper Jarkko Sakkinen 2020-07-14 9:45 ` Jarkko Sakkinen 2020-07-14 9:50 ` Russell King - ARM Linux admin 2020-07-14 9:50 ` Russell King - ARM Linux admin 2020-07-14 10:28 ` Will Deacon 2020-07-14 10:28 ` Will Deacon 2020-07-14 11:29 ` Peter Zijlstra 2020-07-14 11:29 ` Peter Zijlstra 2020-07-14 12:19 ` Ard Biesheuvel 2020-07-14 12:19 ` Ard Biesheuvel 2020-07-14 13:01 ` Peter Zijlstra 2020-07-14 13:01 ` Peter Zijlstra 2020-07-14 13:33 ` Mark Rutland 2020-07-14 13:33 ` Mark Rutland 2020-07-14 13:47 ` Ard Biesheuvel 2020-07-14 13:47 ` Ard Biesheuvel 2020-07-14 14:03 ` Steven Rostedt 2020-07-14 14:03 ` Steven Rostedt 2020-07-15 5:03 ` Masami Hiramatsu 2020-07-15 5:03 ` Masami Hiramatsu 2020-07-14 16:31 ` Jarkko Sakkinen 2020-07-14 16:31 ` Jarkko Sakkinen 2020-07-14 16:46 ` Peter Zijlstra 2020-07-14 16:46 ` Peter Zijlstra 2020-07-15 8:15 ` David Laight 2020-07-15 8:15 ` David Laight 2020-07-14 16:42 ` Russell King - ARM Linux admin 2020-07-14 16:42 ` Russell King - ARM Linux admin 2020-07-14 12:25 ` Jarkko Sakkinen 2020-07-14 12:25 ` Jarkko Sakkinen 2020-07-14 13:56 ` Jessica Yu 2020-07-14 13:56 ` Jessica Yu 2020-07-14 15:44 ` Steven Rostedt 2020-07-14 15:44 ` Steven Rostedt 2020-07-14 16:37 ` Jarkko Sakkinen 2020-07-14 16:37 ` Jarkko Sakkinen 2020-07-14 14:35 ` kernel test robot 2020-07-14 14:35 ` kernel test robot 2020-07-16 16:49 ` Christophe Leroy 2020-07-16 16:49 ` Christophe Leroy 2020-07-23 1:51 ` Jarkko Sakkinen 2020-07-23 1:51 ` Jarkko Sakkinen 2020-07-23 12:42 ` Ard Biesheuvel 2020-07-23 12:42 ` Ard Biesheuvel 2020-07-24 7:36 ` Jarkko Sakkinen [this message] 2020-07-24 7:36 ` Jarkko Sakkinen 2020-07-24 8:05 ` Jessica Yu 2020-07-24 8:05 ` Jessica Yu 2020-07-24 15:46 ` Jarkko Sakkinen 2020-07-24 15:46 ` Jarkko Sakkinen 2020-07-14 9:45 ` [PATCH v2 2/3] module: Add lock_modules() and unlock_modules() Jarkko Sakkinen 2020-07-14 9:45 ` [PATCH v2 3/3] kprobes: Flag out CONFIG_MODULES dependent code Jarkko Sakkinen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200724073621.GC1872662@linux.intel.com \ --to=jarkko.sakkinen@linux.intel.com \ --cc=Babu.Moger@amd.com \ --cc=James.Bottomley@hansenpartnership.com \ --cc=ak@linux.intel.com \ --cc=akpm@linux-foundation.org \ --cc=amit.kachhap@arm.com \ --cc=anders.roxell@linaro.org \ --cc=andriin@fb.com \ --cc=anil.s.keshavamurthy@intel.com \ --cc=anup.patel@wdc.com \ --cc=aou@eecs.berkeley.edu \ --cc=ardb@kernel.org \ --cc=ast@kernel.org \ --cc=atish.patra@wdc.com \ --cc=bauerman@linux.ibm.com \ --cc=ben-linux@fluff.org \ --cc=borntraeger@de.ibm.com \ --cc=bp@alien8.de \ --cc=bpf@vger.kernel.org \ --cc=brgerst@gmail.com \ --cc=catalin.marinas@arm.com \ --cc=christophe.leroy@csgroup.eu \ --cc=damien.lemoal@wdc.com \ --cc=daniel@iogearbox.net \ --cc=davem@davemloft.net \ --cc=deanbo422@gmail.com \ --cc=deller@gmx.de \ --cc=dhowells@redhat.com \ --cc=dja@axtens.net \ --cc=duwe@lst.de \ --cc=dvyukov@google.com \ --cc=elver@google.com \ --cc=gor@linux.ibm.com \ --cc=green.hu@gmail.com \ --cc=gxt@pku.edu.cn \ --cc=han_mao@c-sky.com \ --cc=heiko.carstens@de.ibm.com \ --cc=hpa@zytor.com \ --cc=jeyu@kernel.org \ --cc=jkosina@suse.cz \ --cc=joe.lawrence@redhat.com \ --cc=john.fastabend@gmail.com \ --cc=jolsa@redhat.com \ --cc=jpoimboe@redhat.com \ --cc=kafai@fb.com \ --cc=kpsingh@chromium.org \ --cc=ley.foon.tan@intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@vger.kernel.org \ --cc=linux-parisc@vger.kernel.org \ --cc=linux-riscv@lists.infradead.org \ --cc=linux-s390@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=luto@kernel.org \ --cc=mark.rutland@arm.com \ --cc=masahiroy@kernel.org \ --cc=mbenes@suse.cz \ --cc=mhiramat@kernel.org \ --cc=mingo@redhat.com \ --cc=naveen.n.rao@linux.ibm.com \ --cc=nayna@linux.ibm.com \ --cc=netdev@vger.kernel.org \ --cc=nickhu@andestech.com \ --cc=osandov@fb.com \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=paulburton@kernel.org \ --cc=paulmck@kernel.org \ --cc=paulus@samba.org \ --cc=peterz@infradead.org \ --cc=pmladek@suse.com \ --cc=prudo@linux.ibm.com \ --cc=rostedt@goodmis.org \ --cc=rppt@linux.ibm.com \ --cc=samitolvanen@google.com \ --cc=sandipan@linux.ibm.com \ --cc=songliubraving@fb.com \ --cc=sparclinux@vger.kernel.org \ --cc=svens@stackframe.org \ --cc=tglx@linutronix.de \ --cc=thuth@redhat.com \ --cc=tsbogend@alpha.franken.de \ --cc=vincent.whitchurch@axis.com \ --cc=vincenzo.frascino@arm.com \ --cc=wangkefeng.wang@huawei.com \ --cc=will@kernel.org \ --cc=x86@kernel.org \ --cc=yangtiezhu@loongson.cn \ --cc=yhs@fb.com \ --cc=yzaikin@google.com \ --cc=zong.li@sifive.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.