From: kernel test robot <lkp@intel.com>
To: Vaibhav Gupta <vaibhavgupta40@gmail.com>,
Bjorn Helgaas <helgaas@kernel.org>,
Vaibhav Gupta <vaibhav.varodek@gmail.com>,
Jens Axboe <axboe@kernel.dk>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: kbuild-all@lists.01.org, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v1] ata: use generic power management
Date: Sat, 25 Jul 2020 07:49:01 +0800 [thread overview]
Message-ID: <202007250755.VwQW72Pe%lkp@intel.com> (raw)
In-Reply-To: <20200724110630.1219882-1-vaibhavgupta40@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3074 bytes --]
Hi Vaibhav,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on block/for-next]
[also build test WARNING on v5.8-rc6 next-20200724]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Vaibhav-Gupta/ata-use-generic-power-management/20200724-190929
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/ata/pata_triflex.c: In function 'triflex_init_one':
>> drivers/ata/pata_triflex.c:186:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
186 | static const struct ata_port_info info = {
| ^~~~~~
vim +186 drivers/ata/pata_triflex.c
669a5db411d85a1 Jeff Garzik 2006-08-29 176
669a5db411d85a1 Jeff Garzik 2006-08-29 177 static int triflex_init_one(struct pci_dev *dev, const struct pci_device_id *id)
669a5db411d85a1 Jeff Garzik 2006-08-29 178 {
5acd74b592933fd Vaibhav Gupta 2020-07-24 179 /*
5acd74b592933fd Vaibhav Gupta 2020-07-24 180 * We must not disable or powerdown the device.
5acd74b592933fd Vaibhav Gupta 2020-07-24 181 * APM bios refuses to suspend if IDE is not accessible.
5acd74b592933fd Vaibhav Gupta 2020-07-24 182 */
5acd74b592933fd Vaibhav Gupta 2020-07-24 183 dev->pm_cap = 0;
5acd74b592933fd Vaibhav Gupta 2020-07-24 184 dev_info(&dev->dev, "Disable triflex to be turned off by PCI CORE\n");
5acd74b592933fd Vaibhav Gupta 2020-07-24 185
1626aeb881236c8 Tejun Heo 2007-05-04 @186 static const struct ata_port_info info = {
1d2808fd3d2d5d2 Jeff Garzik 2007-05-28 187 .flags = ATA_FLAG_SLAVE_POSS,
14bdef982caeda1 Erik Inge Bolsø 2009-03-14 188 .pio_mask = ATA_PIO4,
14bdef982caeda1 Erik Inge Bolsø 2009-03-14 189 .mwdma_mask = ATA_MWDMA2,
669a5db411d85a1 Jeff Garzik 2006-08-29 190 .port_ops = &triflex_port_ops
669a5db411d85a1 Jeff Garzik 2006-08-29 191 };
1626aeb881236c8 Tejun Heo 2007-05-04 192 const struct ata_port_info *ppi[] = { &info, NULL };
669a5db411d85a1 Jeff Garzik 2006-08-29 193
06296a1e684bcd4 Joe Perches 2011-04-15 194 ata_print_version_once(&dev->dev, DRV_VERSION);
669a5db411d85a1 Jeff Garzik 2006-08-29 195
1c5afdf7a629d2e Tejun Heo 2010-05-19 196 return ata_pci_bmdma_init_one(dev, ppi, &triflex_sht, NULL, 0);
669a5db411d85a1 Jeff Garzik 2006-08-29 197 }
669a5db411d85a1 Jeff Garzik 2006-08-29 198
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 74062 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Vaibhav Gupta <vaibhavgupta40@gmail.com>,
Bjorn Helgaas <helgaas@kernel.org>,
Vaibhav Gupta <vaibhav.varodek@gmail.com>,
Jens Axboe <axboe@kernel.dk>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Cc: linux-ide@vger.kernel.org, kbuild-all@lists.01.org,
linux-kernel@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [Linux-kernel-mentees] [PATCH v1] ata: use generic power management
Date: Sat, 25 Jul 2020 07:49:01 +0800 [thread overview]
Message-ID: <202007250755.VwQW72Pe%lkp@intel.com> (raw)
In-Reply-To: <20200724110630.1219882-1-vaibhavgupta40@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3074 bytes --]
Hi Vaibhav,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on block/for-next]
[also build test WARNING on v5.8-rc6 next-20200724]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Vaibhav-Gupta/ata-use-generic-power-management/20200724-190929
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/ata/pata_triflex.c: In function 'triflex_init_one':
>> drivers/ata/pata_triflex.c:186:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
186 | static const struct ata_port_info info = {
| ^~~~~~
vim +186 drivers/ata/pata_triflex.c
669a5db411d85a1 Jeff Garzik 2006-08-29 176
669a5db411d85a1 Jeff Garzik 2006-08-29 177 static int triflex_init_one(struct pci_dev *dev, const struct pci_device_id *id)
669a5db411d85a1 Jeff Garzik 2006-08-29 178 {
5acd74b592933fd Vaibhav Gupta 2020-07-24 179 /*
5acd74b592933fd Vaibhav Gupta 2020-07-24 180 * We must not disable or powerdown the device.
5acd74b592933fd Vaibhav Gupta 2020-07-24 181 * APM bios refuses to suspend if IDE is not accessible.
5acd74b592933fd Vaibhav Gupta 2020-07-24 182 */
5acd74b592933fd Vaibhav Gupta 2020-07-24 183 dev->pm_cap = 0;
5acd74b592933fd Vaibhav Gupta 2020-07-24 184 dev_info(&dev->dev, "Disable triflex to be turned off by PCI CORE\n");
5acd74b592933fd Vaibhav Gupta 2020-07-24 185
1626aeb881236c8 Tejun Heo 2007-05-04 @186 static const struct ata_port_info info = {
1d2808fd3d2d5d2 Jeff Garzik 2007-05-28 187 .flags = ATA_FLAG_SLAVE_POSS,
14bdef982caeda1 Erik Inge Bolsø 2009-03-14 188 .pio_mask = ATA_PIO4,
14bdef982caeda1 Erik Inge Bolsø 2009-03-14 189 .mwdma_mask = ATA_MWDMA2,
669a5db411d85a1 Jeff Garzik 2006-08-29 190 .port_ops = &triflex_port_ops
669a5db411d85a1 Jeff Garzik 2006-08-29 191 };
1626aeb881236c8 Tejun Heo 2007-05-04 192 const struct ata_port_info *ppi[] = { &info, NULL };
669a5db411d85a1 Jeff Garzik 2006-08-29 193
06296a1e684bcd4 Joe Perches 2011-04-15 194 ata_print_version_once(&dev->dev, DRV_VERSION);
669a5db411d85a1 Jeff Garzik 2006-08-29 195
1c5afdf7a629d2e Tejun Heo 2010-05-19 196 return ata_pci_bmdma_init_one(dev, ppi, &triflex_sht, NULL, 0);
669a5db411d85a1 Jeff Garzik 2006-08-29 197 }
669a5db411d85a1 Jeff Garzik 2006-08-29 198
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 74062 bytes --]
[-- Attachment #3: Type: text/plain, Size: 201 bytes --]
_______________________________________________
Linux-kernel-mentees mailing list
Linux-kernel-mentees@lists.linuxfoundation.org
https://lists.linuxfoundation.org/mailman/listinfo/linux-kernel-mentees
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v1] ata: use generic power management
Date: Sat, 25 Jul 2020 07:49:01 +0800 [thread overview]
Message-ID: <202007250755.VwQW72Pe%lkp@intel.com> (raw)
In-Reply-To: <20200724110630.1219882-1-vaibhavgupta40@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 3135 bytes --]
Hi Vaibhav,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on block/for-next]
[also build test WARNING on v5.8-rc6 next-20200724]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Vaibhav-Gupta/ata-use-generic-power-management/20200724-190929
base: https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
# save the attached .config to linux build tree
make W=1 ARCH=i386
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/ata/pata_triflex.c: In function 'triflex_init_one':
>> drivers/ata/pata_triflex.c:186:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
186 | static const struct ata_port_info info = {
| ^~~~~~
vim +186 drivers/ata/pata_triflex.c
669a5db411d85a1 Jeff Garzik 2006-08-29 176
669a5db411d85a1 Jeff Garzik 2006-08-29 177 static int triflex_init_one(struct pci_dev *dev, const struct pci_device_id *id)
669a5db411d85a1 Jeff Garzik 2006-08-29 178 {
5acd74b592933fd Vaibhav Gupta 2020-07-24 179 /*
5acd74b592933fd Vaibhav Gupta 2020-07-24 180 * We must not disable or powerdown the device.
5acd74b592933fd Vaibhav Gupta 2020-07-24 181 * APM bios refuses to suspend if IDE is not accessible.
5acd74b592933fd Vaibhav Gupta 2020-07-24 182 */
5acd74b592933fd Vaibhav Gupta 2020-07-24 183 dev->pm_cap = 0;
5acd74b592933fd Vaibhav Gupta 2020-07-24 184 dev_info(&dev->dev, "Disable triflex to be turned off by PCI CORE\n");
5acd74b592933fd Vaibhav Gupta 2020-07-24 185
1626aeb881236c8 Tejun Heo 2007-05-04 @186 static const struct ata_port_info info = {
1d2808fd3d2d5d2 Jeff Garzik 2007-05-28 187 .flags = ATA_FLAG_SLAVE_POSS,
14bdef982caeda1 Erik Inge Bolsø 2009-03-14 188 .pio_mask = ATA_PIO4,
14bdef982caeda1 Erik Inge Bolsø 2009-03-14 189 .mwdma_mask = ATA_MWDMA2,
669a5db411d85a1 Jeff Garzik 2006-08-29 190 .port_ops = &triflex_port_ops
669a5db411d85a1 Jeff Garzik 2006-08-29 191 };
1626aeb881236c8 Tejun Heo 2007-05-04 192 const struct ata_port_info *ppi[] = { &info, NULL };
669a5db411d85a1 Jeff Garzik 2006-08-29 193
06296a1e684bcd4 Joe Perches 2011-04-15 194 ata_print_version_once(&dev->dev, DRV_VERSION);
669a5db411d85a1 Jeff Garzik 2006-08-29 195
1c5afdf7a629d2e Tejun Heo 2010-05-19 196 return ata_pci_bmdma_init_one(dev, ppi, &triflex_sht, NULL, 0);
669a5db411d85a1 Jeff Garzik 2006-08-29 197 }
669a5db411d85a1 Jeff Garzik 2006-08-29 198
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 74062 bytes --]
next prev parent reply other threads:[~2020-07-24 23:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 11:06 [PATCH v1] ata: use generic power management Vaibhav Gupta
2020-07-24 11:06 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-24 11:11 ` Vaibhav Gupta
2020-07-24 11:11 ` [Linux-kernel-mentees] " Vaibhav Gupta
2020-07-24 23:49 ` kernel test robot [this message]
2020-07-24 23:49 ` kernel test robot
2020-07-24 23:49 ` [Linux-kernel-mentees] " kernel test robot
2020-07-25 1:00 ` kernel test robot
2020-07-25 1:00 ` kernel test robot
2020-07-25 1:00 ` [Linux-kernel-mentees] " kernel test robot
2020-07-27 7:19 ` Vaibhav Gupta
2020-07-27 7:19 ` [Linux-kernel-mentees] " Vaibhav Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202007250755.VwQW72Pe%lkp@intel.com \
--to=lkp@intel.com \
--cc=axboe@kernel.dk \
--cc=b.zolnierkie@samsung.com \
--cc=helgaas@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=vaibhav.varodek@gmail.com \
--cc=vaibhavgupta40@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.