[PATCH -next] sched/uclamp: kill unnecessary mutex_init()

[PATCH -next] sched/uclamp: kill unnecessary mutex_init()

[Qinglang Miao]

The mutex uclamp_mutex is initialized statically. It is
unnecessary to initialize by mutex_init().

Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
---
 kernel/sched/core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 29d557c1f..9a8b7ed3a 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -1331,8 +1331,6 @@ static void __init init_uclamp(void)
 	enum uclamp_id clamp_id;
 	int cpu;
 
-	mutex_init(&uclamp_mutex);
-
 	for_each_possible_cpu(cpu)
 		init_uclamp_rq(cpu_rq(cpu));
 
-- 
2.25.1

[tip: sched/core] sched/uclamp: Remove unnecessary mutex_init()

[tip-bot2 for Qinglang Miao]

The following commit has been merged into the sched/core branch of tip:

Commit-ID:     13efa616124f7eec7d6a58adeeef31864aa03879
Gitweb:        https://git.kernel.org/tip/13efa616124f7eec7d6a58adeeef31864aa03879
Author:        Qinglang Miao <miaoqinglang@huawei.com>
AuthorDate:    Sat, 25 Jul 2020 16:56:29 +08:00
Committer:     Ingo Molnar <mingo@kernel.org>
CommitterDate: Sat, 25 Jul 2020 12:10:36 +02:00

sched/uclamp: Remove unnecessary mutex_init()

The uclamp_mutex lock is initialized statically via DEFINE_MUTEX(),
it is unnecessary to initialize it runtime via mutex_init().

Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: Patrick Bellasi <patrick.bellasi@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Dietmar Eggemann <dietmar.eggemann@arm.com>
Link: https://lore.kernel.org/r/20200725085629.98292-1-miaoqinglang@huawei.com
---
 kernel/sched/core.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index bd8e521..6782534 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -1425,8 +1425,6 @@ static void __init init_uclamp(void)
 	enum uclamp_id clamp_id;
 	int cpu;
 
-	mutex_init(&uclamp_mutex);
-
 	for_each_possible_cpu(cpu)
 		init_uclamp_rq(cpu_rq(cpu));
 

Re: [PATCH -next] sched/uclamp: kill unnecessary mutex_init()

[Steven Rostedt]

On Sat, 25 Jul 2020 16:56:29 +0800
Qinglang Miao <miaoqinglang@huawei.com> wrote:

> The mutex uclamp_mutex is initialized statically. It is
> unnecessary to initialize by mutex_init().
> 

Seems reasonable.

Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

> Signed-off-by: Qinglang Miao <miaoqinglang@huawei.com>
> ---
>  kernel/sched/core.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/kernel/sched/core.c b/kernel/sched/core.c
> index 29d557c1f..9a8b7ed3a 100644
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -1331,8 +1331,6 @@ static void __init init_uclamp(void)
>  	enum uclamp_id clamp_id;
>  	int cpu;
>  
> -	mutex_init(&uclamp_mutex);
> -
>  	for_each_possible_cpu(cpu)
>  		init_uclamp_rq(cpu_rq(cpu));
>