From: John Oldman <john.oldman@polehill.co.uk> To: gregkh@linuxfoundation.org Cc: gustavo@embeddedor.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, John Oldman <john.oldman@polehill.co.uk> Subject: [PATCH V2] Subject: [PATCH] staging: rtl8723bs: core: Using comparison to true is error prone Date: Sat, 25 Jul 2020 14:28:06 +0100 [thread overview] Message-ID: <20200725132806.15019-1-john.oldman@polehill.co.uk> (raw) clear below issues reported by checkpatch.pl: CHECK: Using comparison to true is error prone Signed-off-by: John Oldman <john.oldman@polehill.co.uk> --- v1: Initial attempt. v2: Removed unneccessary parentheses around 'pregistrypriv->ht_enable' Also considered clearing 'CHECK: Logical continuations should be on the previous line' report but this results in exceeding line length guideline. drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c index ca98274ae390..7aacbe1b763e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c @@ -363,8 +363,9 @@ int rtw_generate_ie(struct registry_priv *pregistrypriv) } /* HT Cap. */ - if (((pregistrypriv->wireless_mode&WIRELESS_11_5N) || (pregistrypriv->wireless_mode&WIRELESS_11_24N)) - && (pregistrypriv->ht_enable == true)) { + if (((pregistrypriv->wireless_mode & WIRELESS_11_5N) + || (pregistrypriv->wireless_mode & WIRELESS_11_24N)) + && pregistrypriv->ht_enable) { /* todo: */ } -- 2.17.1
WARNING: multiple messages have this Message-ID (diff)
From: John Oldman <john.oldman@polehill.co.uk> To: gregkh@linuxfoundation.org Cc: devel@driverdev.osuosl.org, John Oldman <john.oldman@polehill.co.uk>, linux-kernel@vger.kernel.org, gustavo@embeddedor.com Subject: [PATCH V2] Subject: [PATCH] staging: rtl8723bs: core: Using comparison to true is error prone Date: Sat, 25 Jul 2020 14:28:06 +0100 [thread overview] Message-ID: <20200725132806.15019-1-john.oldman@polehill.co.uk> (raw) clear below issues reported by checkpatch.pl: CHECK: Using comparison to true is error prone Signed-off-by: John Oldman <john.oldman@polehill.co.uk> --- v1: Initial attempt. v2: Removed unneccessary parentheses around 'pregistrypriv->ht_enable' Also considered clearing 'CHECK: Logical continuations should be on the previous line' report but this results in exceeding line length guideline. drivers/staging/rtl8723bs/core/rtw_ieee80211.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c index ca98274ae390..7aacbe1b763e 100644 --- a/drivers/staging/rtl8723bs/core/rtw_ieee80211.c +++ b/drivers/staging/rtl8723bs/core/rtw_ieee80211.c @@ -363,8 +363,9 @@ int rtw_generate_ie(struct registry_priv *pregistrypriv) } /* HT Cap. */ - if (((pregistrypriv->wireless_mode&WIRELESS_11_5N) || (pregistrypriv->wireless_mode&WIRELESS_11_24N)) - && (pregistrypriv->ht_enable == true)) { + if (((pregistrypriv->wireless_mode & WIRELESS_11_5N) + || (pregistrypriv->wireless_mode & WIRELESS_11_24N)) + && pregistrypriv->ht_enable) { /* todo: */ } -- 2.17.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next reply other threads:[~2020-07-25 13:28 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-25 13:28 John Oldman [this message] 2020-07-25 13:28 ` [PATCH V2] Subject: [PATCH] staging: rtl8723bs: core: Using comparison to true is error prone John Oldman 2020-07-25 13:34 ` Greg KH 2020-07-25 13:34 ` Greg KH 2020-07-25 14:07 ` <John Oldman> 2020-07-25 14:07 ` <John Oldman>
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20200725132806.15019-1-john.oldman@polehill.co.uk \ --to=john.oldman@polehill.co.uk \ --cc=devel@driverdev.osuosl.org \ --cc=gregkh@linuxfoundation.org \ --cc=gustavo@embeddedor.com \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.