* [Buildroot] [PATCH] package/cegui: fix selecting the default OpenGL renderer
@ 2020-06-23 19:19 Bartosz Bilas
2020-07-27 15:25 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Bartosz Bilas @ 2020-06-23 19:19 UTC (permalink / raw)
To: buildroot
According to the cegui requirements select explicit the default
OpenGL renderer based on available possibilities.
Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
---
package/cegui/Config.in | 1 +
package/cegui/cegui.mk | 18 ++++++++++++++----
2 files changed, 15 insertions(+), 4 deletions(-)
diff --git a/package/cegui/Config.in b/package/cegui/Config.in
index f917be0cc5..1bd0ee1cc3 100644
--- a/package/cegui/Config.in
+++ b/package/cegui/Config.in
@@ -9,6 +9,7 @@ config BR2_PACKAGE_CEGUI
depends on BR2_TOOLCHAIN_HAS_THREADS
depends on BR2_USE_WCHAR
select BR2_PACKAGE_GLM
+ select BR2_PACKAGE_LIBGLFW if BR2_PACKAGE_HAS_LIBGL # SampleBrowser dependency
select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
help
Crazy Eddie's GUI System is a free library providing windowing
diff --git a/package/cegui/cegui.mk b/package/cegui/cegui.mk
index 6158ef129c..505d67656a 100644
--- a/package/cegui/cegui.mk
+++ b/package/cegui/cegui.mk
@@ -16,15 +16,25 @@ CEGUI_DEPENDENCIES = glm \
$(if $(BR2_PACKAGE_LIBGLFW),libglfw) \
$(if $(BR2_PACKAGE_HAS_LIBGL),libgl) \
$(if $(BR2_PACKAGE_HAS_LIBGLES),libgles) \
- $(if $(BR2_PACKAGE_LIBGLEW),libglew) \
+ $(if $(BR2_PACKAGE_LIBGLFW),libglfw) \
$(if $(BR2_PACKAGE_LIBICONV),libiconv)
# libepoxy support cannot be enabled together with libglew
-ifeq ($(BR2_PACKAGE_LIBEPOXY):$(BR2_PACKAGE_LIBGLEW),y:)
+ifeq ($(BR2_PACKAGE_LIBGLEW)$(BR2_PACKAGE_LIBGLU),yy)
+CEGUI_DEPENDENCIES += libglew libglu
+CEGUI_CONF_OPTS += -DCEGUI_USE_GLEW=ON -DCEGUI_USE_EPOXY=OFF \
+ -DCEGUI_BUILD_RENDERER_OPENGL=ON \
+ -DCEGUI_BUILD_RENDERER_OPENGL3=ON
+else ifeq ($(BR2_PACKAGE_LIBEPOXY),y)
CEGUI_DEPENDENCIES += libepoxy
-CEGUI_CONF_OPTS += -DCEGUI_USE_EPOXY=ON
+# old OpenGL renderer module is only supported using GLEW
+CEGUI_CONF_OPTS += -DCEGUI_USE_EPOXY=ON -DCEGUI_USE_GLEW=OFF \
+ -DCEGUI_BUILD_RENDERER_OPENGL=OFF \
+ -DCEGUI_BUILD_RENDERER_OPENGL3=ON
else
-CEGUI_CONF_OPTS += -DCEGUI_USE_EPOXY=OFF
+CEGUI_CONF_OPTS += -DCEGUI_USE_EPOXY=OFF -DCEGUI_USE_GLEW=OFF \
+ -DCEGUI_BUILD_RENDERER_OPENGL=OFF \
+ -DCEGUI_BUILD_RENDERER_OPENGL3=OFF
endif
ifeq ($(BR2_PACKAGE_EXPAT),y)
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] package/cegui: fix selecting the default OpenGL renderer
2020-06-23 19:19 [Buildroot] [PATCH] package/cegui: fix selecting the default OpenGL renderer Bartosz Bilas
@ 2020-07-27 15:25 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2020-07-27 15:25 UTC (permalink / raw)
To: buildroot
On Tue, 23 Jun 2020 21:19:07 +0200
Bartosz Bilas <b.bilas@grinn-global.com> wrote:
> According to the cegui requirements select explicit the default
> OpenGL renderer based on available possibilities.
>
> Signed-off-by: Bartosz Bilas <b.bilas@grinn-global.com>
Applied, with one change. See below.
> diff --git a/package/cegui/cegui.mk b/package/cegui/cegui.mk
> index 6158ef129c..505d67656a 100644
> --- a/package/cegui/cegui.mk
> +++ b/package/cegui/cegui.mk
> @@ -16,15 +16,25 @@ CEGUI_DEPENDENCIES = glm \
> $(if $(BR2_PACKAGE_LIBGLFW),libglfw) \
We have this here...
> $(if $(BR2_PACKAGE_HAS_LIBGL),libgl) \
> $(if $(BR2_PACKAGE_HAS_LIBGLES),libgles) \
> - $(if $(BR2_PACKAGE_LIBGLEW),libglew) \
> + $(if $(BR2_PACKAGE_LIBGLFW),libglfw) \
and you're adding it again here. So I dropped this new addition.
I also made a few indentation fixes.
Thanks for your contribution!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-27 15:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-23 19:19 [Buildroot] [PATCH] package/cegui: fix selecting the default OpenGL renderer Bartosz Bilas
2020-07-27 15:25 ` Thomas Petazzoni
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.