Re: [PATCH v4] kvm,x86: Exit to user space in case page fault error

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Vivek Goyal <vgoyal@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
	virtio-fs-list <virtio-fs@redhat.com>,
	pbonzini@redhat.com, sean.j.christopherson@intel.com
Subject: Re: [PATCH v4] kvm,x86: Exit to user space in case page fault error
Date: Mon, 27 Jul 2020 14:40:53 -0400	[thread overview]
Message-ID: <20200727184053.GB39559@redhat.com> (raw)
In-Reply-To: <87ft9dlz2b.fsf@vitty.brq.redhat.com>

On Mon, Jul 27, 2020 at 06:09:32PM +0200, Vitaly Kuznetsov wrote:
> Vivek Goyal <vgoyal@redhat.com> writes:
> 
> > On Mon, Jul 20, 2020 at 05:13:59PM -0400, Vivek Goyal wrote:
> >> Page fault error handling behavior in kvm seems little inconsistent when
> >> page fault reports error. If we are doing fault synchronously
> >> then we capture error (-EFAULT) returned by __gfn_to_pfn_memslot() and
> >> exit to user space and qemu reports error, "error: kvm run failed Bad address".
> >
> > Hi Vitaly,
> >
> > A gentle reminder. How does this patch look now?
> >
> 
> Sorry, I even reviewd it but never replied. It looks good to me!
> 
> Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>

Thanks Vitaly.

Paolo, what do you think about this patch. Do you have concerns with
this. Can this be merged.

Thanks
Vivek

WARNING: multiple messages have this Message-ID (diff)

From: Vivek Goyal <vgoyal@redhat.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: virtio-fs-list <virtio-fs@redhat.com>,
	pbonzini@redhat.com, sean.j.christopherson@intel.com,
	linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [Virtio-fs] [PATCH v4] kvm, x86: Exit to user space in case page fault error
Date: Mon, 27 Jul 2020 14:40:53 -0400	[thread overview]
Message-ID: <20200727184053.GB39559@redhat.com> (raw)
In-Reply-To: <87ft9dlz2b.fsf@vitty.brq.redhat.com>

On Mon, Jul 27, 2020 at 06:09:32PM +0200, Vitaly Kuznetsov wrote:
> Vivek Goyal <vgoyal@redhat.com> writes:
> 
> > On Mon, Jul 20, 2020 at 05:13:59PM -0400, Vivek Goyal wrote:
> >> Page fault error handling behavior in kvm seems little inconsistent when
> >> page fault reports error. If we are doing fault synchronously
> >> then we capture error (-EFAULT) returned by __gfn_to_pfn_memslot() and
> >> exit to user space and qemu reports error, "error: kvm run failed Bad address".
> >
> > Hi Vitaly,
> >
> > A gentle reminder. How does this patch look now?
> >
> 
> Sorry, I even reviewd it but never replied. It looks good to me!
> 
> Reviewed-by: Vitaly Kuznetsov <vkuznets@redhat.com>

Thanks Vitaly.

Paolo, what do you think about this patch. Do you have concerns with
this. Can this be merged.

Thanks
Vivek

next prev parent reply	other threads:[~2020-07-27 18:41 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-20 21:13 [PATCH v4] kvm,x86: Exit to user space in case page fault error Vivek Goyal
2020-07-20 21:13 ` [Virtio-fs] [PATCH v4] kvm, x86: " Vivek Goyal
2020-07-27 13:56 ` [PATCH v4] kvm,x86: " Vivek Goyal
2020-07-27 13:56   ` [Virtio-fs] [PATCH v4] kvm, x86: " Vivek Goyal
2020-07-27 16:09   ` [PATCH v4] kvm,x86: " Vitaly Kuznetsov
2020-07-27 16:09     ` [Virtio-fs] [PATCH v4] kvm, x86: " Vitaly Kuznetsov
2020-07-27 18:40     ` Vivek Goyal [this message]
2020-07-27 18:40       ` Vivek Goyal
2020-07-30  5:01 ` [PATCH v4] kvm,x86: " Pankaj Gupta
2020-07-30  5:01   ` [Virtio-fs] [PATCH v4] kvm, x86: " Pankaj Gupta
2020-08-07 17:51 ` [PATCH v4] kvm,x86: " Vivek Goyal
2020-08-07 17:51   ` [Virtio-fs] [PATCH v4] kvm, x86: " Vivek Goyal
2020-09-29  4:37 ` [PATCH v4] kvm,x86: " Sean Christopherson
2020-09-29  4:37   ` [Virtio-fs] [PATCH v4] kvm, x86: " Sean Christopherson
2020-10-01 21:55   ` [PATCH v4] kvm,x86: " Vivek Goyal
2020-10-01 21:55     ` [Virtio-fs] [PATCH v4] kvm, x86: " Vivek Goyal
2020-10-01 22:33     ` [PATCH v4] kvm,x86: " Sean Christopherson
2020-10-01 22:33       ` [Virtio-fs] [PATCH v4] kvm, x86: " Sean Christopherson
2020-10-02 15:38       ` [PATCH v4] kvm,x86: " Vivek Goyal
2020-10-02 15:38         ` [Virtio-fs] [PATCH v4] kvm, x86: " Vivek Goyal
2020-10-02 18:30         ` [PATCH v4] kvm,x86: " Sean Christopherson
2020-10-02 18:30           ` [Virtio-fs] [PATCH v4] kvm, x86: " Sean Christopherson
2020-10-02 19:27           ` [PATCH v4] kvm,x86: " Vivek Goyal
2020-10-02 19:27             ` [Virtio-fs] [PATCH v4] kvm, x86: " Vivek Goyal
2020-10-02 19:45             ` [PATCH v4] kvm,x86: " Sean Christopherson
2020-10-02 19:45               ` [Virtio-fs] [PATCH v4] kvm, x86: " Sean Christopherson
2020-10-02 20:02               ` [PATCH v4] kvm,x86: " Vivek Goyal
2020-10-02 20:02                 ` [Virtio-fs] [PATCH v4] kvm, x86: " Vivek Goyal
2020-10-02 21:13                 ` [PATCH v4] kvm,x86: " Sean Christopherson
2020-10-02 21:13                   ` [Virtio-fs] [PATCH v4] kvm, x86: " Sean Christopherson
2020-10-05 15:33                   ` [PATCH v4] kvm,x86: " Vivek Goyal
2020-10-05 15:33                     ` [Virtio-fs] [PATCH v4] kvm, x86: " Vivek Goyal
2020-10-05 16:16                     ` [PATCH v4] kvm,x86: " Sean Christopherson
2020-10-05 16:16                       ` [Virtio-fs] [PATCH v4] kvm, x86: " Sean Christopherson
2020-10-06 13:46                       ` [PATCH v4] kvm,x86: " Vivek Goyal
2020-10-06 13:46                         ` [Virtio-fs] [PATCH v4] kvm, x86: " Vivek Goyal
2020-10-06 14:05                         ` [PATCH v4] kvm,x86: " Vitaly Kuznetsov
2020-10-06 14:05                           ` [Virtio-fs] [PATCH v4] kvm, x86: " Vitaly Kuznetsov
2020-10-06 14:15                           ` [PATCH v4] kvm,x86: " Vivek Goyal
2020-10-06 14:15                             ` [Virtio-fs] [PATCH v4] kvm, x86: " Vivek Goyal
2020-10-06 14:50                             ` [PATCH v4] kvm,x86: " Vitaly Kuznetsov
2020-10-06 14:50                               ` [Virtio-fs] [PATCH v4] kvm, x86: " Vitaly Kuznetsov
2020-10-06 15:08                               ` [PATCH v4] kvm,x86: " Vivek Goyal
2020-10-06 15:08                                 ` [Virtio-fs] [PATCH v4] kvm, x86: " Vivek Goyal
2020-10-06 15:24                                 ` [PATCH v4] kvm,x86: " Vitaly Kuznetsov
2020-10-06 15:24                                   ` [Virtio-fs] [PATCH v4] kvm, x86: " Vitaly Kuznetsov
2020-10-06 16:12                                   ` [PATCH v4] kvm,x86: " Sean Christopherson
2020-10-06 16:12                                     ` [Virtio-fs] [PATCH v4] kvm, x86: " Sean Christopherson
2020-10-06 16:24                                     ` [PATCH v4] kvm,x86: " Vivek Goyal
2020-10-06 16:24                                       ` [Virtio-fs] [PATCH v4] kvm, x86: " Vivek Goyal
2020-10-06 16:39                                     ` [PATCH v4] kvm,x86: " Vitaly Kuznetsov
2020-10-06 16:39                                       ` [Virtio-fs] [PATCH v4] kvm, x86: " Vitaly Kuznetsov
2020-10-06 17:17                                       ` [PATCH v4] kvm,x86: " Sean Christopherson
2020-10-06 17:17                                         ` [Virtio-fs] [PATCH v4] kvm, x86: " Sean Christopherson
2020-10-06 17:21                                         ` Dr. David Alan Gilbert
2020-10-06 17:21                                           ` Dr. David Alan Gilbert
2020-10-06 17:28                                           ` Vivek Goyal
2020-10-06 17:28                                             ` Vivek Goyal
2020-10-06 17:35                                         ` [PATCH v4] kvm,x86: " Vivek Goyal
2020-10-06 17:35                                           ` [Virtio-fs] [PATCH v4] kvm, x86: " Vivek Goyal
2020-10-07  0:04                                           ` [PATCH v4] kvm,x86: " Sean Christopherson
2020-10-07  0:04                                             ` [Virtio-fs] [PATCH v4] kvm, x86: " Sean Christopherson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200727184053.GB39559@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    --cc=sean.j.christopherson@intel.com \
    --cc=virtio-fs@redhat.com \
    --cc=vkuznets@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.