[PATCH 8/8] Initial Pine64 Pinephone support

From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [PATCH 8/8] Initial Pine64 Pinephone support
Date: Mon, 27 Jul 2020 16:43:55 -0400	[thread overview]
Message-ID: <20200727204355.GE6965@bill-the-cat> (raw)
In-Reply-To: <1562d29f-3063-d6ca-bc84-cb7b57237391@arm.com>

On Mon, Jul 27, 2020 at 09:08:40PM +0100, Andr? Przywara wrote:
> On 27/07/2020 14:49, Peter Robinson wrote:
> 
> Hi,
> 
> thanks for piecing this together. As Maxime mentioned, many options are
> not necessary (see below).
> 
> Some options are now set by ARCH_SUNXI, since 48313fe51008.
> 
> >> On Wed, Jul 22, 2020 at 03:18:40PM +0100, Peter Robinson wrote:
> >>> The Pine64 Pinephone is a smartphone based on the AllWinner A64 SoC.
> >>> It has the following features:
> >>> * 2GB LPDDR3 SDRAM
> >>> * 5.95 inch 1440x720 HD IPS capacitive touchscreen
> >>> * 16GB eMMC, mSD slot
> >>> * Quectel EG25 LTE Modem
> >>> * Realtek RTL8723CS WiFi/BT
> >>> * Front and read cameras
> >>> * Accelerometer, gyro, proximity, ambient light, compass sensors
> >>> * A USB Type-C, USB Host, DisplayPort alt mode output, 15W 5V 3A Quick Charge, follows USB PD specification
> >>>
> >>> Signed-off-by: Peter Robinson <pbrobinson@gmail.com>
> >>> ---
> >>>  arch/arm/Kconfig            |  2 +-
> >>>  configs/pinephone_defconfig | 38 +++++++++++++++++++++++++++++++++++++
> >>>  2 files changed, 39 insertions(+), 1 deletion(-)
> >>>  create mode 100644 configs/pinephone_defconfig
> >>>
> >>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> >>> index e16fe03887..636ba26938 100644
> >>> --- a/arch/arm/Kconfig
> >>> +++ b/arch/arm/Kconfig
> >>> @@ -1004,7 +1004,7 @@ config ARCH_SUNXI
> >>>       bool "Support sunxi (Allwinner) SoCs"
> >>>       select BINMAN
> >>>       select CMD_GPIO
> >>> -     select CMD_MMC if MMC
> >>> +select CMD_MMC if MMC
> >>
> >> That looks like a typo?
> > 
> > Yes, it is.
> > 
> >>>       select CMD_USB if DISTRO_DEFAULTS
> >>>       select CLK
> >>>       select DM
> >>> diff --git a/configs/pinephone_defconfig b/configs/pinephone_defconfig
> >>> new file mode 100644
> >>> index 0000000000..d5750aa954
> >>> --- /dev/null
> >>> +++ b/configs/pinephone_defconfig
> >>> @@ -0,0 +1,38 @@
> >>> +CONFIG_ARM=y
> >>> +CONFIG_ARCH_SUNXI=y
> >>> +CONFIG_SPL=y
> >>> +CONFIG_MACH_SUN50I=y
> >>> +CONFIG_SUNXI_DRAM_LPDDR3_STOCK=y
> >>> +CONFIG_DRAM_CLK=552
> >>> +CONFIG_DRAM_ZQ=3881949
> >>> +CONFIG_NR_DRAM_BANKS=1
> 
> defaults to 1 now for ARCH_SUNXI

So really, one needs to run `make savedefconfig`, copy defconfig to
configs/foo_defconfig and then see if there's some changes / settings
there that are unexpected.  Because if you put a change in there, and
then run `make foo_defconfig` and don't see what you want in the new
.config file, there's a missing dependency or similar.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200727/e0174f45/attachment.sig>