[PATCH] staging/speakup: Update TODO list

[PATCH] staging/speakup: Update TODO list

[Samuel Thibault]

Thanks to Okash's latest work, the TODO list is essentially empty, so
the way out from staging now seems open.

The status of the remaining issue mentioned in TODO is not clear, we
asked the speakup user mailing list for reproducer cases, but didn't get
a really specific scenario. One serious bug was fixed by 9d32c0cde4e2
("staging/speakup: fix get_word non-space look-ahead"), which does not
seem to really be related to the bug mentioned in TODO. Possibly the bug
mentioned in TODO has been fixed long ago and people have been thinking
that it was not because they can not distinguish the symptoms mentioned
in TODO from the symptoms of the bug fixed by 9d32c0cde4e2.

Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>

diff --git a/drivers/staging/speakup/TODO b/drivers/staging/speakup/TODO
index 993410c3e531..d4ca093bf0bd 100644
--- a/drivers/staging/speakup/TODO
+++ b/drivers/staging/speakup/TODO
@@ -6,35 +6,11 @@ Speakup is a kernel based screen review package for the linux operating
 system.  It allows blind users to interact with applications on the
 linux console by means of synthetic speech.
 
-Currently, speakup has several issues we know of.
+Currently, speakup has one issue we know of.
 
-The first issue has to do with the way speakup communicates with serial
-ports.  Currently, we communicate directly with the hardware
-ports. This however conflicts with the standard serial port drivers,
-which poses various problems. This is also not working for modern hardware
-such as PCI-based serial ports.  Also, there is not a way we can
-communicate with USB devices.  The current serial port handling code is
-in serialio.c in this directory.
-
-Some places are currently using in_atomic() because speakup functions
-are called in various contexts, and a couple of things can't happen
-in these cases. Pushing work to some worker thread would probably help,
-as was already done for the serial port driving part.
-
-There is a duplication of the selection functions in selections.c. These
-functions should get exported from drivers/char/selection.c (clear_selection
-notably) and used from there instead.
-
-The kobjects may have to move to a more proper place in /sys. The
-discussion on lkml resulted to putting speech synthesizers in the
-"speech" class, and the speakup screen reader itself into
-/sys/class/vtconsole/vtcon0/speakup, the nasty path being handled by
-userland tools.
-
-Another issue seems to only happen on SMP systems.  It seems
-that text in the output buffer gets garbled because a lock is not set.
-This bug happens regularly, but no one has been able to find a situation
-which produces it consistently.
+It seems to only happen on SMP systems. It seems that text in the output buffer
+gets garbled because a lock is not set. This bug happens regularly, but no one
+has been able to find a situation which produces it consistently.
 
 Patches, suggestions, corrections, etc, are definitely welcome.
 
@@ -42,6 +18,5 @@ We prefer that you contact us on the mailing list; however, if you do
 not want to subscribe to a mailing list, send your email to all of the
 following:
 
-w.d.hubbs@gmail.com, chris@the-brannons.com, kirk@reisers.ca and
-samuel.thibault@ens-lyon.org.
-
+okash.khawaja@gmail.com, w.d.hubbs@gmail.com, chris@the-brannons.com,
+kirk@reisers.ca and samuel.thibault@ens-lyon.org.

Re: [PATCH] staging/speakup: Update TODO list

[Greg KH]

On Sun, Jul 26, 2020 at 06:54:52PM +0200, Samuel Thibault wrote:
> Thanks to Okash's latest work, the TODO list is essentially empty, so
> the way out from staging now seems open.
> 
> The status of the remaining issue mentioned in TODO is not clear, we
> asked the speakup user mailing list for reproducer cases, but didn't get
> a really specific scenario. One serious bug was fixed by 9d32c0cde4e2
> ("staging/speakup: fix get_word non-space look-ahead"), which does not
> seem to really be related to the bug mentioned in TODO. Possibly the bug
> mentioned in TODO has been fixed long ago and people have been thinking
> that it was not because they can not distinguish the symptoms mentioned
> in TODO from the symptoms of the bug fixed by 9d32c0cde4e2.

I think it's time we move speakup out of staging.  Care to submit a
patch series that does this?

thanks,

greg k-h

Re: [PATCH] staging/speakup: Update TODO list

[Samuel Thibault]

Greg KH, le mar. 28 juil. 2020 10:18:42 +0200, a ecrit:
> On Sun, Jul 26, 2020 at 06:54:52PM +0200, Samuel Thibault wrote:
> > Thanks to Okash's latest work, the TODO list is essentially empty, so
> > the way out from staging now seems open.
> > 
> > The status of the remaining issue mentioned in TODO is not clear, we
> > asked the speakup user mailing list for reproducer cases, but didn't get
> > a really specific scenario. One serious bug was fixed by 9d32c0cde4e2
> > ("staging/speakup: fix get_word non-space look-ahead"), which does not
> > seem to really be related to the bug mentioned in TODO. Possibly the bug
> > mentioned in TODO has been fixed long ago and people have been thinking
> > that it was not because they can not distinguish the symptoms mentioned
> > in TODO from the symptoms of the bug fixed by 9d32c0cde4e2.
> 
> I think it's time we move speakup out of staging.  Care to submit a
> patch series that does this?

Yes!

Done so.

Samuel