From: Jakub Kicinski <kuba@kernel.org>
To: Saeed Mahameed <saeedm@mellanox.com>
Cc: "mkubecek@suse.cz" <mkubecek@suse.cz>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH net-next 2/2] mlx5: convert to new udp_tunnel infrastructure
Date: Tue, 28 Jul 2020 09:59:17 -0700 [thread overview]
Message-ID: <20200728095917.2e290d57@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <b9e4f45f6478b4447d5fa34bc7e02716d0f77d89.camel@mellanox.com>
On Tue, 28 Jul 2020 08:35:53 +0000 Saeed Mahameed wrote:
> On Fri, 2020-07-24 at 19:51 -0700, Jakub Kicinski wrote:
> > Allocate nic_info dynamically - n_entries is not constant.
> >
> > Drop the ndo callbacks from the reprs, those should be local to
> > the same netns as the main netdev, no need to get the same callbacks
> > multiple times.
>
> Isn't this a problem ? so it seems this is the root cause of the
> regression failure we saw with this patch.
>
> in a switchdev mode the "main" netdev is unregistered
Oh! I didn't realize you unregister the "main" one!
> and we register
> another netdev with ndos: "mlx5e_netdev_ops_uplink_rep" as the new main
> netdev (the uplink representor) where you removed the vxlan ndos,
> see below..
>
> > .ndo_has_offload_stats = mlx5e_rep_has_offload_stats,
> > .ndo_get_offload_stats = mlx5e_rep_get_offload_stats,
> > .ndo_change_mtu = mlx5e_uplink_rep_change_mtu,
> > - .ndo_udp_tunnel_add = mlx5e_add_vxlan_port,
> > - .ndo_udp_tunnel_del = mlx5e_del_vxlan_port,
>
> Here, this is uplink representor (i.e main netdev).
> we need the udp_tunnel_ndos.
>
> also we need to add:
> mlx5_vxlan_set_netdev_info(mdev->vxlan, netdev);
>
> in mlx5e_build_rep_netdev() under
> if (rep->vport == MLX5_VPORT_UPLINK) statement.
Makes sense, thanks for the review!
next prev parent reply other threads:[~2020-07-28 16:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-25 2:51 [PATCH net-next 0/2] udp_tunnel: convert mlx5 to the new udp_tunnel infrastructure Jakub Kicinski
2020-07-25 2:51 ` [PATCH net-next 1/2] udp_tunnel: add the ability to hard-code IANA VXLAN Jakub Kicinski
2020-07-25 2:51 ` [PATCH net-next 2/2] mlx5: convert to new udp_tunnel infrastructure Jakub Kicinski
2020-07-28 8:35 ` Saeed Mahameed
2020-07-28 16:59 ` Jakub Kicinski [this message]
2020-07-28 7:57 ` [PATCH net-next 0/2] udp_tunnel: convert mlx5 to the " Saeed Mahameed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200728095917.2e290d57@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=mkubecek@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.