All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saeed Mahameed <saeedm@mellanox.com>
To: "kuba@kernel.org" <kuba@kernel.org>
Cc: "mkubecek@suse.cz" <mkubecek@suse.cz>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH net-next 0/2] udp_tunnel: convert mlx5 to the new udp_tunnel infrastructure
Date: Tue, 28 Jul 2020 07:57:46 +0000	[thread overview]
Message-ID: <c5ee0e70b0263ebcf70534f2329cf55083021dfe.camel@mellanox.com> (raw)
In-Reply-To: <20200725025146.3770263-1-kuba@kernel.org>

On Fri, 2020-07-24 at 19:51 -0700, Jakub Kicinski wrote:
> This set converts mlx5 to the new infrastructure.
> 
> We need a small amount of special handling as mlx5 expects IANA VXLAN
> port to always be programmed into the device. ethtool will show such
> ports in a separate, type-less, fake table, at the end:
> 
> Tunnel information for eth0:
>   UDP port table 0: 
>     Size: 7
>     Types: vxlan
>     No entries
>   UDP port table 1: 
>     Size: 1
>     Types: none (static entries)
>     Entries (1):
>         port 4789, vxlan
> 
> Saeed - this should apply on top of net-next, independently of
> the Intel patches, would you mind taking this in for testing
> and review? I'll post the netdevsim & test once Intel patches
> re-emerge.
> 

Hi Jakub, thanks for the patches.

We had some failures in our internal regression and it seems to be
related to these patches, something with vxlan test case with
representors and switchdev mode, we will be debugging and will let you
know.

> Jakub Kicinski (2):
>   udp_tunnel: add the ability to hard-code IANA VXLAN
>   mlx5: convert to new udp_tunnel infrastructure
> 
>  Documentation/networking/ethtool-netlink.rst  |  3 +
>  drivers/net/ethernet/mellanox/mlx5/core/en.h  |  2 -
>  .../net/ethernet/mellanox/mlx5/core/en_main.c | 88 ++---------------
> --
>  .../net/ethernet/mellanox/mlx5/core/en_rep.c  |  2 -
>  .../ethernet/mellanox/mlx5/core/lib/vxlan.c   | 87 +++++++++------
> ---
>  .../ethernet/mellanox/mlx5/core/lib/vxlan.h   |  6 +-
>  include/net/udp_tunnel.h                      |  5 ++
>  net/ethtool/tunnels.c                         | 69 +++++++++++++--
>  net/ipv4/udp_tunnel_nic.c                     |  7 ++
>  9 files changed, 126 insertions(+), 143 deletions(-)
> 

      parent reply	other threads:[~2020-07-28  7:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-25  2:51 [PATCH net-next 0/2] udp_tunnel: convert mlx5 to the new udp_tunnel infrastructure Jakub Kicinski
2020-07-25  2:51 ` [PATCH net-next 1/2] udp_tunnel: add the ability to hard-code IANA VXLAN Jakub Kicinski
2020-07-25  2:51 ` [PATCH net-next 2/2] mlx5: convert to new udp_tunnel infrastructure Jakub Kicinski
2020-07-28  8:35   ` Saeed Mahameed
2020-07-28 16:59     ` Jakub Kicinski
2020-07-28  7:57 ` Saeed Mahameed [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5ee0e70b0263ebcf70534f2329cf55083021dfe.camel@mellanox.com \
    --to=saeedm@mellanox.com \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=mkubecek@suse.cz \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.