All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] configs: pico-imx6: convert ethernet function to DM_ETH
@ 2020-07-28 10:37 wig.cheng at technexion.com
  2020-07-28 12:42 ` Fabio Estevam
  0 siblings, 1 reply; 4+ messages in thread
From: wig.cheng at technexion.com @ 2020-07-28 10:37 UTC (permalink / raw)
  To: u-boot

From: Wig Cheng <wig.cheng@technexion.com>

Before enable _DM_ETH:
    Net:   FEC [PRIME]

After enable DM_ETH:
    Net:   eth0: ethernet at 2188000

Here is the test commands:
    => dhcp
    BOOTP broadcast 1
    DHCP client bound to address 10.88.88.152 (146 ms)
    *** ERROR: `serverip' not set
    Cannot autoload with TFTPGET
    => ping 8.8.8.8
    Using ethernet at 2188000 device
    host 8.8.8.8 is alive

Signed-off-by: Wig Cheng <wig.cheng@technexion.com>
---
 configs/pico-imx6_defconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/configs/pico-imx6_defconfig b/configs/pico-imx6_defconfig
index 04c132b474..5fe2850086 100644
--- a/configs/pico-imx6_defconfig
+++ b/configs/pico-imx6_defconfig
@@ -64,6 +64,9 @@ CONFIG_DM_MMC=y
 CONFIG_FSL_USDHC=y
 CONFIG_PHYLIB=y
 CONFIG_PHY_ATHEROS=y
+CONFIG_DM_ETH=y
+CONFIG_DM_MDIO=y
+CONFIG_RGMII=y
 CONFIG_PINCTRL=y
 CONFIG_PINCTRL_IMX6=y
 CONFIG_MXC_UART=y
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH v1] configs: pico-imx6: convert ethernet function to DM_ETH
  2020-07-28 10:37 [PATCH v1] configs: pico-imx6: convert ethernet function to DM_ETH wig.cheng at technexion.com
@ 2020-07-28 12:42 ` Fabio Estevam
  0 siblings, 0 replies; 4+ messages in thread
From: Fabio Estevam @ 2020-07-28 12:42 UTC (permalink / raw)
  To: u-boot

HI Wig,

On Tue, Jul 28, 2020 at 7:37 AM <wig.cheng@technexion.com> wrote:
>
> From: Wig Cheng <wig.cheng@technexion.com>
>
> Before enable _DM_ETH:
>     Net:   FEC [PRIME]
>
> After enable DM_ETH:
>     Net:   eth0: ethernet at 2188000
>
> Here is the test commands:
>     => dhcp
>     BOOTP broadcast 1
>     DHCP client bound to address 10.88.88.152 (146 ms)
>     *** ERROR: `serverip' not set
>     Cannot autoload with TFTPGET
>     => ping 8.8.8.8
>     Using ethernet at 2188000 device
>     host 8.8.8.8 is alive
>
> Signed-off-by: Wig Cheng <wig.cheng@technexion.com>
> ---
>  configs/pico-imx6_defconfig | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/configs/pico-imx6_defconfig b/configs/pico-imx6_defconfig
> index 04c132b474..5fe2850086 100644
> --- a/configs/pico-imx6_defconfig
> +++ b/configs/pico-imx6_defconfig
> @@ -64,6 +64,9 @@ CONFIG_DM_MMC=y
>  CONFIG_FSL_USDHC=y
>  CONFIG_PHYLIB=y
>  CONFIG_PHY_ATHEROS=y
> +CONFIG_DM_ETH=y
> +CONFIG_DM_MDIO=y

mx6 has only a single FEC instance, so there is no need for selecting DM_MDIO.

Please see this patch I have recently submitted:
https://gitlab.denx.de/u-boot/custodians/u-boot-imx/-/commit/45032991194239991726cafe4dfa6a72ddf45956

Other than that your patch looks good.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v1] configs: pico-imx6: convert ethernet function to DM_ETH
  2020-07-28  8:15 wig.cheng at technexion.com
@ 2020-08-04  8:52 ` sbabic at denx.de
  0 siblings, 0 replies; 4+ messages in thread
From: sbabic at denx.de @ 2020-08-04  8:52 UTC (permalink / raw)
  To: u-boot

> From: Wig Cheng <wig.cheng@technexion.com>
> Before enable _DM_ETH:
>     Net:   FEC [PRIME]
> After enable DM_ETH:
>     Net:   eth0: ethernet at 2188000
> Here is the test commands:
>     => dhcp
>     BOOTP broadcast 1
>     DHCP client bound to address 10.88.88.152 (146 ms)
>     *** ERROR: `serverip' not set
>     Cannot autoload with TFTPGET
>     => ping 8.8.8.8
>     Using ethernet at 2188000 device
>     host 8.8.8.8 is alive
> Signed-off-by: Wig Cheng <wig.cheng@technexion.com>
Applied to u-boot-imx, master, thanks !

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH v1] configs: pico-imx6: convert ethernet function to DM_ETH
@ 2020-07-28  8:15 wig.cheng at technexion.com
  2020-08-04  8:52 ` sbabic at denx.de
  0 siblings, 1 reply; 4+ messages in thread
From: wig.cheng at technexion.com @ 2020-07-28  8:15 UTC (permalink / raw)
  To: u-boot

From: Wig Cheng <wig.cheng@technexion.com>

Before enable _DM_ETH:
    Net:   FEC [PRIME]

After enable DM_ETH:
    Net:   eth0: ethernet at 2188000

Here is the test commands:
    => dhcp
    BOOTP broadcast 1
    DHCP client bound to address 10.88.88.152 (146 ms)
    *** ERROR: `serverip' not set
    Cannot autoload with TFTPGET
    => ping 8.8.8.8
    Using ethernet at 2188000 device
    host 8.8.8.8 is alive

Signed-off-by: Wig Cheng <wig.cheng@technexion.com>
---
 configs/pico-imx6_defconfig | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/configs/pico-imx6_defconfig b/configs/pico-imx6_defconfig
index 04c132b474..5fe2850086 100644
--- a/configs/pico-imx6_defconfig
+++ b/configs/pico-imx6_defconfig
@@ -64,6 +64,9 @@ CONFIG_DM_MMC=y
 CONFIG_FSL_USDHC=y
 CONFIG_PHYLIB=y
 CONFIG_PHY_ATHEROS=y
+CONFIG_DM_ETH=y
+CONFIG_DM_MDIO=y
+CONFIG_RGMII=y
 CONFIG_PINCTRL=y
 CONFIG_PINCTRL_IMX6=y
 CONFIG_MXC_UART=y
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-08-04  8:52 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-28 10:37 [PATCH v1] configs: pico-imx6: convert ethernet function to DM_ETH wig.cheng at technexion.com
2020-07-28 12:42 ` Fabio Estevam
  -- strict thread matches above, loose matches on Subject: below --
2020-07-28  8:15 wig.cheng at technexion.com
2020-08-04  8:52 ` sbabic at denx.de

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.